From 8f0f2ad3c02996ce2362eab5383f0a4ab9175427 Mon Sep 17 00:00:00 2001 From: Ted Gould Date: Tue, 1 Dec 2009 10:40:17 -0600 Subject: Making the timeout a failure case, and making it so that we want a graceful shutdown. --- tests/service-manager-connect-service.c | 6 +++--- tests/service-manager-connect.c | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) (limited to 'tests') diff --git a/tests/service-manager-connect-service.c b/tests/service-manager-connect-service.c index 297f3ba..dbdf4fa 100644 --- a/tests/service-manager-connect-service.c +++ b/tests/service-manager-connect-service.c @@ -8,7 +8,7 @@ static gboolean passed = FALSE; gboolean timeout (gpointer data) { - passed = TRUE; + passed = FALSE; g_debug("Timeout with no shutdown."); g_main_loop_quit(mainloop); return FALSE; @@ -17,8 +17,8 @@ timeout (gpointer data) void shutdown (void) { - g_error("Shutdown"); - passed = FALSE; + g_debug("Shutdown"); + passed = TRUE; g_main_loop_quit(mainloop); return; } diff --git a/tests/service-manager-connect.c b/tests/service-manager-connect.c index c252542..b62c2c9 100644 --- a/tests/service-manager-connect.c +++ b/tests/service-manager-connect.c @@ -37,6 +37,8 @@ main (int argc, char ** argv) mainloop = g_main_loop_new(NULL, FALSE); g_main_loop_run(mainloop); + g_object_unref(is); + g_debug("Quiting"); if (passed) { g_debug("Passed"); -- cgit v1.2.3 From d69de93483b5ad9e709f59dac00af7ff7f4df477 Mon Sep 17 00:00:00 2001 From: Ted Gould Date: Tue, 1 Dec 2009 10:43:10 -0600 Subject: Updating connection prototype to get all the data. --- tests/service-manager-connect.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tests') diff --git a/tests/service-manager-connect.c b/tests/service-manager-connect.c index b62c2c9..4519b83 100644 --- a/tests/service-manager-connect.c +++ b/tests/service-manager-connect.c @@ -15,7 +15,7 @@ timeout (gpointer data) } void -connection (void) +connection (IndicatorServiceManager * sm, gboolean connected, gpointer user_data) { g_debug("Connection"); passed = TRUE; @@ -30,7 +30,7 @@ main (int argc, char ** argv) g_log_set_always_fatal(G_LOG_LEVEL_CRITICAL); IndicatorServiceManager * is = indicator_service_manager_new("org.ayatana.test"); - g_signal_connect(G_OBJECT(is), INDICATOR_SERVICE_MANAGER_SIGNAL_CONNECTION_CHANGE, connection, NULL); + g_signal_connect(G_OBJECT(is), INDICATOR_SERVICE_MANAGER_SIGNAL_CONNECTION_CHANGE, G_CALLBACK(connection), NULL); g_timeout_add_seconds(1, timeout, NULL); -- cgit v1.2.3 From 6e89bf096ce0c261e2fece0cbeb6289ea21e8c5a Mon Sep 17 00:00:00 2001 From: Ted Gould Date: Tue, 1 Dec 2009 10:47:13 -0600 Subject: Checking to make sure we don't get connected twice, that'd be an error. --- tests/service-manager-connect.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'tests') diff --git a/tests/service-manager-connect.c b/tests/service-manager-connect.c index 4519b83..91d2bad 100644 --- a/tests/service-manager-connect.c +++ b/tests/service-manager-connect.c @@ -17,6 +17,20 @@ timeout (gpointer data) void connection (IndicatorServiceManager * sm, gboolean connected, gpointer user_data) { + static gboolean has_connected = FALSE; + + if (has_connected && connected) { + g_warning("We got two connected signals. FAIL."); + passed = FALSE; + return; + } + + if (!connected) { + g_debug("Not connected"); + return; + } + + has_connected = TRUE; g_debug("Connection"); passed = TRUE; g_main_loop_quit(mainloop); -- cgit v1.2.3 From 1b1a50d5d5075929eb18622eb0e8b6fc7bff9814 Mon Sep 17 00:00:00 2001 From: Ted Gould Date: Tue, 1 Dec 2009 13:35:30 -0600 Subject: Adding a test to ensure that a service gets shutdown by someone unwatching it. --- tests/Makefile.am | 24 ++++++++++++ tests/service-manager-connect-service.c | 2 + tests/service-manager-nostart-connect.c | 65 +++++++++++++++++++++++++++++++++ 3 files changed, 91 insertions(+) create mode 100644 tests/service-manager-nostart-connect.c (limited to 'tests') diff --git a/tests/Makefile.am b/tests/Makefile.am index 80c4191..09a227d 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -6,6 +6,7 @@ check_PROGRAMS = \ service-manager-no-connect \ service-manager-connect \ service-manager-connect-service \ + service-manager-nostart-connect \ service-shutdown-timeout lib_LTLIBRARIES = \ @@ -199,6 +200,29 @@ service-manager-connect-tester: service-manager-connect service-manager-connect- TESTS += service-manager-connect-tester DISTCLEANFILES += service-manager-connect-tester session.conf service-manager-connect.service +############################# +# Service Manager Shutdown +############################# + +service_manager_nostart_connect_SOURCES = \ + service-manager-nostart-connect.c + +service_manager_nostart_connect_CFLAGS = \ + -Wall -Werror \ + $(LIBINDICATOR_CFLAGS) -I$(top_srcdir) + +service_manager_nostart_connect_LDADD = \ + $(LIBINDICATOR_LIBS) \ + $(top_builddir)/libindicator/.libs/libindicator.a + +service-manager-connect-nostart-tester: service-manager-nostart-connect service-manager-connect-service Makefile.am + @echo "#!/bin/sh" > $@ + @echo dbus-test-runner --task ./service-manager-nostart-connect --task ./service-manager-connect-service >> $@ + @chmod +x $@ + +TESTS += service-manager-connect-nostart-tester +DISTCLEANFILES += service-manager-connect-nostart-tester + ############################# # Test stuff ############################# diff --git a/tests/service-manager-connect-service.c b/tests/service-manager-connect-service.c index dbdf4fa..d60e414 100644 --- a/tests/service-manager-connect-service.c +++ b/tests/service-manager-connect-service.c @@ -28,6 +28,8 @@ main (int argc, char ** argv) { g_type_init(); + g_debug("Starting service"); + IndicatorService * is = indicator_service_new("org.ayatana.test"); g_signal_connect(G_OBJECT(is), INDICATOR_SERVICE_SIGNAL_SHUTDOWN, shutdown, NULL); diff --git a/tests/service-manager-nostart-connect.c b/tests/service-manager-nostart-connect.c new file mode 100644 index 0000000..7107f42 --- /dev/null +++ b/tests/service-manager-nostart-connect.c @@ -0,0 +1,65 @@ + +#include +#include "libindicator/indicator-service-manager.h" + +static GMainLoop * mainloop = NULL; +static gboolean passed = FALSE; + +gboolean +timeout (gpointer data) +{ + passed = FALSE; + g_error("Timeout with no connection."); + g_main_loop_quit(mainloop); + return FALSE; +} + +void +connection (IndicatorServiceManager * sm, gboolean connected, gpointer user_data) +{ + static gboolean has_connected = FALSE; + + if (has_connected && connected) { + g_warning("We got two connected signals. FAIL."); + passed = FALSE; + return; + } + + if (!connected) { + g_debug("Not connected"); + return; + } + + has_connected = TRUE; + g_debug("Connection"); + passed = TRUE; + g_main_loop_quit(mainloop); + return; +} + +int +main (int argc, char ** argv) +{ + g_type_init(); + g_log_set_always_fatal(G_LOG_LEVEL_CRITICAL); + + g_usleep(150000); + + IndicatorServiceManager * is = indicator_service_manager_new("org.ayatana.test"); + g_signal_connect(G_OBJECT(is), INDICATOR_SERVICE_MANAGER_SIGNAL_CONNECTION_CHANGE, G_CALLBACK(connection), NULL); + + g_timeout_add_seconds(1, timeout, NULL); + + mainloop = g_main_loop_new(NULL, FALSE); + g_main_loop_run(mainloop); + + g_object_unref(is); + + g_debug("Quiting"); + if (passed) { + g_debug("Passed"); + return 0; + } + g_debug("Failed"); + return 1; +} -- cgit v1.2.3