Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Update for review comments | Chris Coulson | 2013-05-28 | 1 | -5/+11 |
| | |||||
* | Set the max ID of menuitems to G_MAXINT rather than 30000, as internally, ↵ | Chris Coulson | 2013-05-17 | 1 | -2/+5 |
| | | | | | | the server side happily creates ID's greater than this which then wraparound on the client side. We keep the minimum unchanged at -1, as some consumers addume that < 0 is an error (rather than -1). To make this a bit less fragile, handle rollover on the server side from G_MAXINT to 1, rather than having a signed integer overflow which will just break things a bit later on | ||||
* | Fix multiple leaks due to improper use of g_variant_parse() | Chris Coulson | 2013-01-24 | 1 | -1/+3 |
| | |||||
* | gtk-doc fix: dbusmenu_menuitem_set_root doesn't have a return value | Charles Kerr | 2012-12-04 | 1 | -2/+0 |
| | |||||
* | when initializing fields inside a struct being declared, replace gccism with ↵ | Charles Kerr | 2012-10-26 | 1 | -2/+2 |
| | | | | c99 syntax | ||||
* | fix grammar: use of its and it's | Charles Kerr | 2012-10-07 | 1 | -3/+3 |
| | |||||
* | constify the dbusmenu_menuitem_get*() functions | Charles Kerr | 2012-04-25 | 1 | -7/+7 |
| | |||||
* | Fixing a trivial annotation bug | Ted Gould | 2012-03-08 | 1 | -2/+2 |
| | |||||
* | Switching out logic, we're using replaced now because it gets set everytime ↵ | Ted Gould | 2012-03-08 | 1 | -2/+1 |
| | | | | that the hashtable is modified, and if we weren't modifying the hash table in some way, we don't want to signal. And, conversely, no one cares if we didn't modify the hash table. | ||||
* | Not sending the update signal if the value is being cleared and it was ↵ | Ted Gould | 2012-03-02 | 1 | -1/+2 |
| | | | | already cleared | ||||
* | Because of the change of inhash above we could have hash_variant be NULL here | Ted Gould | 2012-02-09 | 1 | -1/+1 |
| | |||||
* | Change icon-data to contains raw png bytes, without base64 encoding | Aurélien Gâteau | 2012-01-23 | 1 | -0/+51 |
| | | | | | | | | | Reasons: - base64 encoding is not necessary because dbusmenu properties can use any dbus-supported types. - faster: no need to base64 decode/encode images - more efficient: base64-encoded data is 1/3 bigger than raw data | ||||
* | Ensure the class is correct | Ted Gould | 2011-09-23 | 1 | -1/+1 |
| | |||||
* | Various memory leaks and fixes | Ted Gould | 2011-06-17 | 1 | -11/+6 |
|\ | |||||
| * | Avoid string parsing by using a direct variant new function. | Ted Gould | 2011-06-16 | 1 | -1/+1 |
| | | |||||
| * | Fix for several issues as documented in bug 784890 | Jonathan Landis | 2011-06-16 | 1 | -11/+6 |
| | | |||||
* | | Adding the element type to get_children | Ted Gould | 2011-05-13 | 1 | -1/+1 |
|/ | |||||
* | Make check to send about-to-show look for properties as well. | Ted Gould | 2011-04-05 | 1 | -1/+1 |
| | |||||
* | Using the new defines | Ted Gould | 2011-03-16 | 1 | -1/+1 |
| | |||||
* | Putting in a protection and fixing the truth | Ted Gould | 2011-03-07 | 1 | -2/+6 |
| | |||||
* | Steal earlier instead of later so that signal handlers don't find the value ↵ | Ted Gould | 2011-03-07 | 1 | -1/+3 |
| | | | | in the hashtable | ||||
* | Switching to using the extended lookup and getting the key and value | Ted Gould | 2011-03-07 | 1 | -4/+6 |
| | |||||
* | Delaying the removal from the hashtable. | Ted Gould | 2011-03-01 | 1 | -2/+18 |
| | |||||
* | Putting a protection in for bad key values. | Ted Gould | 2011-03-01 | 1 | -0/+1 |
| | |||||
* | The last commit causes the warning in dbusmenu_menuitem_property_is_default ↵ | Chris Coulson | 2011-03-01 | 1 | -7/+2 |
| | | | | | | | | to be thrown when removing a property that has no default value. This warning seems bogus though, as any property that is not in the menuitems local property list is a default value (as that is what dbusmenu_menuitem_property_get* will return). Simplify this function to work like this and drop the warning | ||||
* | Fix LP: #723873 - when a menuitems property is restored to a default value, ↵ | Chris Coulson | 2011-02-28 | 1 | -17/+16 |
| | | | | | | | | | | | | the new state is not updated correctly on the listening client. Make dbusmenu_menuitem_property_remove call dbusmenu_menuitem_property_set_variant with a NULL value rather than manipulating the properties directly. When removing a property that has a default value now, it will signal PROPERTY_CHANGED with the default value, which means that changing a property from non-default to default over the wire (which really just deletes the property) now works correctly. This is also now more aligned with how dbusmenu_menuitem_property_get* works, which will return the default value for a property after removing the property from the menuitem | ||||
* | Making sure to grab the variant and dispose of it in handle_event. | Ted Gould | 2011-02-24 | 1 | -1/+12 |
| | |||||
* | Marking as having details available in the signal | Ted Gould | 2011-02-24 | 1 | -1/+1 |
| | |||||
* | Fixing signal emition to use the saved value instead of the enum | Ted Gould | 2011-02-24 | 1 | -1/+1 |
| | |||||
* | Track the parent inside the menuitem instead of with a data property externally. | Ted Gould | 2011-02-24 | 1 | -2/+105 |
|\ | |||||
| * | Adding a transfer annotation for the get_parent function | Ted Gould | 2011-02-24 | 1 | -1/+1 |
| | | |||||
| * | Checking to ensure we're the parent before deleting | Ted Gould | 2011-02-24 | 1 | -0/+5 |
| | | |||||
| * | Hold a weak pointer to each DbusmenuMenuitems parent. This avoids | Chris Coulson | 2011-02-24 | 1 | -2/+100 |
| | | | | | | | | | | | | using g_object_{get/set}_data for storing a nodes parent in the parser code, and the associated problems with that (ie, a child out-living its parent, leading to invalid reads | ||||
* | | Adding an 'event' signal for generic event handling | Ted Gould | 2011-02-24 | 1 | -1/+23 |
|\ \ | |/ |/| | |||||
| * | Switch signal handler to return bool so that we can signal if someone has ↵ | Ted Gould | 2011-02-23 | 1 | -6/+7 |
| | | | | | | | | handled it | ||||
| * | Sync to trunk | Ted Gould | 2011-02-22 | 1 | -379/+497 |
| |\ | |||||
| * | | Should return VOID | Ted Gould | 2011-02-22 | 1 | -1/+1 |
| | | | |||||
| * | | Now emit that signal appropriately | Ted Gould | 2011-01-28 | 1 | -0/+3 |
| | | | |||||
| * | | Adding a signal for events | Ted Gould | 2011-01-28 | 1 | -0/+18 |
| | | | |||||
* | | | Only send property updates if the item has been already requested. | Ted Gould | 2011-02-24 | 1 | -0/+14 |
|\ \ \ | |||||
| * | | | Tracking whether we've been exposed | Ted Gould | 2011-02-18 | 1 | -2/+7 |
| | | | | |||||
| * | | | Adding a stub for exposed checking | Ted Gould | 2011-02-18 | 1 | -0/+9 |
| | | | | |||||
* | | | | Allow sending only some properties based on what is requested. | Ted Gould | 2011-02-24 | 1 | -1/+28 |
|\ \ \ \ | |||||
| * | | | | If there's a singular NULL entry we also want the full list | Ted Gould | 2011-02-23 | 1 | -1/+1 |
| | | | | | |||||
| * | | | | Handle a request for selective properties and give less data back | Ted Gould | 2011-02-18 | 1 | -1/+28 |
| |/ / / | |||||
* | | | | Fix up documentation and make it part of make check | Ted Gould | 2011-02-24 | 1 | -1/+1 |
|\ \ \ \ | |||||
| * | | | | Fixing all the menuitem documentation | Ted Gould | 2011-02-21 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Make sure to not recurse if the value says we shouldn't | Ted Gould | 2011-02-24 | 1 | -1/+1 |
|\ \ \ \ \ | |||||
| * | | | | | Redefine so that we don't recurse if we shouldn't | Ted Gould | 2011-02-23 | 1 | -1/+1 |
| | |_|_|/ | |/| | | | |||||
* / | | | | Only look at defaults if we have a value to compare with. | Ted Gould | 2011-02-23 | 1 | -22/+25 |
|/ / / / |