aboutsummaryrefslogtreecommitdiff
path: root/libdbusmenu-gtk
Commit message (Collapse)AuthorAgeFilesLines
...
* | don't use g_intern_static_string() as a drop-in replacement for strcmp()Charles Kerr2012-04-061-51/+107
| |
* | fix prop_value leak in widget_notify_cb() when a widget's label changesCharles Kerr2012-04-061-5/+4
| |
* | remove convoluted & unnecessary branch in update_icon()Charles Kerr2012-04-061-12/+7
| |
* | fix dbusmenu_item_freed(), it called g_object_get_data() on a finalized GObjectCharles Kerr2012-04-061-23/+11
|/
* Merge lp:~allanlesage/dbusmenu/TDD to add gcov targets to autotools build ↵Charles Kerr2012-04-031-1/+9
|\ | | | | | | | | | | | | for code-coverage reporting. For more information, see this blog post: http://qualityhour.wordpress.com/2012/01/29/test-coverage-tutorial-for-cc-autotools-projects/ . To compile with coverage tooling, ./autogen.sh --enable-gcov, then make coverage-html . Note that you'll need lcov to autoconf. Also note that you'll get an error on make if you have no tests, as there are no coverage artifacts to generate the html report. For review, please pay special attention to flags added in the project's makefiles.
| * Added gcov coverage tooling.Allan LeSage2012-03-271-1/+9
| |
* | fold client's two DBUSMENU_MENUITEM_SIGNAL_PROPERTY_CHANGED signal handlers ↵Charles Kerr2012-03-271-12/+2
| | | | | | | | together for clarity
* | Don't listen for "changed" events from the screen's default GtkIconTheme. ↵Charles Kerr2012-03-211-51/+0
| | | | | | | | | | | | | | | | | | Fixes lp bug #953509 The crash in #953509 was being caused by the last two lines of theme_changed_cb() (a) leaving a dangling handler id in priv.theme_changed_sig, and (b) not remembering the handler id of its own signal connection. However after testing I don't see any reason to keep any of the theme handling code at all. "But wait," you say. "How will our menu icons follow the theme changes?" It works in practice anyway because we always listen for property changes to our reference GtkImage, **and** we listen for property changes to its GtkImageMenuItem parent so that if the GtkImageMenuItem changes GtkImages we can stop listening to the old one and start listening to the new one.
* | Fix string leakTed Gould2012-03-201-1/+1
| |
* | Handle the case of the label being NULL which can happen on custom itemsTed Gould2012-03-201-7/+10
| |
* | Removing underscores in the ATK nameTed Gould2012-03-091-7/+15
|\ \
| * | Restructuring slightly to have two cases, allocating memory and not allocatingTed Gould2012-03-091-7/+9
| | |
| * | Remove the underscores used for mnewmonics, as orca speaks them, which is notLuke Yelavich2012-03-091-1/+7
| | | | | | | | | | | | | | | what we want.
* | | Missing a couple of cases of removing the signal handler and clearing the ↵Ted Gould2012-03-091-4/+12
|/ / | | | | | | stored value
* | Making sure the ATK object name always gets set to the label if nothing elseTed Gould2012-03-081-1/+5
|\ \
| * | Set the accessible name from the dbusmenu item label. THis is a work-around ↵Luke Yelavich2012-03-081-0/+8
| | | | | | | | | | | | until GTK follows atk docs.
| * | Merge from trunk.Luke Yelavich2012-03-081-18/+36
| |\ \
| * | | Do not set the accessible name to an empty string if the accessible_descLuke Yelavich2012-02-171-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | property = NULL. Yes this was recently changed so that dbusmenu conformed to Atk documentation, but the GTK menu item accessibility code does not yet conform to sed documentation. As a result, all dbusmenu menu items that do not have the accessible_desc property set end up getting an empty string for their accessible name. In the long term, GTK accessibility needs to be fixed.
* | | | Fixing resetting an icon numerous timesTed Gould2012-03-081-18/+48
|\ \ \ \ | |_|/ / |/| | |
| * | | Don't need to setup this signal twiceTed Gould2012-03-021-3/+0
| | | |
| * | | Moving the adding of signals to the update_icon function so that everyone ↵Ted Gould2012-03-021-12/+32
| | | | | | | | | | | | | | | | gets them
| * | | Changing 'update_icon' to take more variables so we can do more fun stuff ↵Ted Gould2012-03-021-6/+12
| | | | | | | | | | | | | | | | with it soon!
| * | | Track the theme changed signal so we ensure that we can drop it eventuallyTed Gould2012-03-021-1/+8
| | |/ | |/|
* | | Fixing for GTK2Ted Gould2012-03-011-0/+9
| | |
* | | Set the role of the menu item based on how it's being displayedTed Gould2012-03-011-0/+11
| | |
* | | Setting the default role to be a menu itemTed Gould2012-03-011-0/+4
|/ /
* | Do not leak the label textAlberto Mardegan2012-02-221-1/+3
| | | | | | | | | | Also, fix the indentation from the previous commit.
* | Do not read the label text from the label widgetAlberto Mardegan2012-02-221-18/+10
|/ | | | | | | | | The label text stored in the widget might have been modified with markup. Instead of reading it back from the widget, return the text as set by the client, unmodified. Alter the test-gtk-submenu so that the correct behaviour is checked for.
* Use defines instead of stringsTed Gould2012-02-151-1/+1
|\
| * Making sure our strings come from defines to avoid typosTed Gould2012-02-121-1/+1
| |
* | Fix some of the issues with throwing criticalsTed Gould2012-02-152-8/+8
|\ \ | |/ |/|
| * Don't get the string to check if something is being cleared, use whether the ↵Ted Gould2012-02-071-6/+1
| | | | | | | | variant is NULL or not
| * Ensuring that we don't just unparent a menu item, we remove it from the list ↵Ted Gould2012-02-071-2/+7
| | | | | | | | of children that it has
* | Parse and handle a11y descriptionsTed Gould2012-02-102-2/+84
|\ \
| * | Heh, wrote the code but forgot to handle the errorTed Gould2012-02-101-0/+4
| | |
| * | Refactor setting the ATK Object name into a function that can do all the ↵Ted Gould2012-02-101-4/+22
| | | | | | | | | | | | error handling needed.
| * | Don't pass a NULL name to set_nameTed Gould2012-02-101-1/+1
| | |
| * | Use the #define property name instead of a stringTed Gould2012-02-101-3/+3
| | |
| * | Adding a detail hint on the notify signalTed Gould2012-02-101-1/+1
| | |
| * | Fix up monitoring of the atk object, didn't understand that notification was ↵Luke Yelavich2012-02-011-5/+8
| | | | | | | | | | | | the same as the GTK widgets as well.
| * | When parsing an existing GTK menu hierarchy, we should also set theLuke Yelavich2012-01-312-0/+54
| | | | | | | | | | | | | | | | | | DBUSMENU_MENU_ITEM_ACCESSIBLE_DESC property, if the accessible name for the menu differs from the text of the menu item label.
* | | Don't pass NULL to ATKTed Gould2012-02-101-1/+1
|\ \ \
| * | | If the ACCESSIBLE_DESC property is set to NULL, set an empty string as the ↵Luke Yelavich2012-02-011-1/+1
| | |/ | |/| | | | | | | atk object's accessible name, as per atk docs.
* | | Non-srcdir build fixesTed Gould2012-02-101-2/+3
|\ \ \ | |/ / |/| |
| * | Fix non-srcdir build issuesMichal Hruby2012-01-271-2/+3
| |/
* / Only setting the accessible object name if it has been setTed Gould2012-01-261-2/+5
|/
* Merging trunk again, mistakesTed Gould2012-01-261-1/+2
|\
| * Include config.h to get the HAVE_GTK3 defineTed Gould2012-01-261-0/+1
| |
| * Missing commaTed Gould2012-01-261-1/+1
| |
* | Fix function calls hereTed Gould2012-01-261-2/+2
| |