Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | don't use g_intern_static_string() as a drop-in replacement for strcmp() | Charles Kerr | 2012-04-06 | 1 | -51/+107 | |
| | | ||||||
* | | fix prop_value leak in widget_notify_cb() when a widget's label changes | Charles Kerr | 2012-04-06 | 1 | -5/+4 | |
| | | ||||||
* | | remove convoluted & unnecessary branch in update_icon() | Charles Kerr | 2012-04-06 | 1 | -12/+7 | |
| | | ||||||
* | | fix dbusmenu_item_freed(), it called g_object_get_data() on a finalized GObject | Charles Kerr | 2012-04-06 | 1 | -23/+11 | |
|/ | ||||||
* | Merge lp:~allanlesage/dbusmenu/TDD to add gcov targets to autotools build ↵ | Charles Kerr | 2012-04-03 | 1 | -1/+9 | |
|\ | | | | | | | | | | | | | for code-coverage reporting. For more information, see this blog post: http://qualityhour.wordpress.com/2012/01/29/test-coverage-tutorial-for-cc-autotools-projects/ . To compile with coverage tooling, ./autogen.sh --enable-gcov, then make coverage-html . Note that you'll need lcov to autoconf. Also note that you'll get an error on make if you have no tests, as there are no coverage artifacts to generate the html report. For review, please pay special attention to flags added in the project's makefiles. | |||||
| * | Added gcov coverage tooling. | Allan LeSage | 2012-03-27 | 1 | -1/+9 | |
| | | ||||||
* | | fold client's two DBUSMENU_MENUITEM_SIGNAL_PROPERTY_CHANGED signal handlers ↵ | Charles Kerr | 2012-03-27 | 1 | -12/+2 | |
| | | | | | | | | together for clarity | |||||
* | | Don't listen for "changed" events from the screen's default GtkIconTheme. ↵ | Charles Kerr | 2012-03-21 | 1 | -51/+0 | |
| | | | | | | | | | | | | | | | | | | Fixes lp bug #953509 The crash in #953509 was being caused by the last two lines of theme_changed_cb() (a) leaving a dangling handler id in priv.theme_changed_sig, and (b) not remembering the handler id of its own signal connection. However after testing I don't see any reason to keep any of the theme handling code at all. "But wait," you say. "How will our menu icons follow the theme changes?" It works in practice anyway because we always listen for property changes to our reference GtkImage, **and** we listen for property changes to its GtkImageMenuItem parent so that if the GtkImageMenuItem changes GtkImages we can stop listening to the old one and start listening to the new one. | |||||
* | | Fix string leak | Ted Gould | 2012-03-20 | 1 | -1/+1 | |
| | | ||||||
* | | Handle the case of the label being NULL which can happen on custom items | Ted Gould | 2012-03-20 | 1 | -7/+10 | |
| | | ||||||
* | | Removing underscores in the ATK name | Ted Gould | 2012-03-09 | 1 | -7/+15 | |
|\ \ | ||||||
| * | | Restructuring slightly to have two cases, allocating memory and not allocating | Ted Gould | 2012-03-09 | 1 | -7/+9 | |
| | | | ||||||
| * | | Remove the underscores used for mnewmonics, as orca speaks them, which is not | Luke Yelavich | 2012-03-09 | 1 | -1/+7 | |
| | | | | | | | | | | | | | | | what we want. | |||||
* | | | Missing a couple of cases of removing the signal handler and clearing the ↵ | Ted Gould | 2012-03-09 | 1 | -4/+12 | |
|/ / | | | | | | | stored value | |||||
* | | Making sure the ATK object name always gets set to the label if nothing else | Ted Gould | 2012-03-08 | 1 | -1/+5 | |
|\ \ | ||||||
| * | | Set the accessible name from the dbusmenu item label. THis is a work-around ↵ | Luke Yelavich | 2012-03-08 | 1 | -0/+8 | |
| | | | | | | | | | | | | until GTK follows atk docs. | |||||
| * | | Merge from trunk. | Luke Yelavich | 2012-03-08 | 1 | -18/+36 | |
| |\ \ | ||||||
| * | | | Do not set the accessible name to an empty string if the accessible_desc | Luke Yelavich | 2012-02-17 | 1 | -4/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | property = NULL. Yes this was recently changed so that dbusmenu conformed to Atk documentation, but the GTK menu item accessibility code does not yet conform to sed documentation. As a result, all dbusmenu menu items that do not have the accessible_desc property set end up getting an empty string for their accessible name. In the long term, GTK accessibility needs to be fixed. | |||||
* | | | | Fixing resetting an icon numerous times | Ted Gould | 2012-03-08 | 1 | -18/+48 | |
|\ \ \ \ | |_|/ / |/| | | | ||||||
| * | | | Don't need to setup this signal twice | Ted Gould | 2012-03-02 | 1 | -3/+0 | |
| | | | | ||||||
| * | | | Moving the adding of signals to the update_icon function so that everyone ↵ | Ted Gould | 2012-03-02 | 1 | -12/+32 | |
| | | | | | | | | | | | | | | | | gets them | |||||
| * | | | Changing 'update_icon' to take more variables so we can do more fun stuff ↵ | Ted Gould | 2012-03-02 | 1 | -6/+12 | |
| | | | | | | | | | | | | | | | | with it soon! | |||||
| * | | | Track the theme changed signal so we ensure that we can drop it eventually | Ted Gould | 2012-03-02 | 1 | -1/+8 | |
| | |/ | |/| | ||||||
* | | | Fixing for GTK2 | Ted Gould | 2012-03-01 | 1 | -0/+9 | |
| | | | ||||||
* | | | Set the role of the menu item based on how it's being displayed | Ted Gould | 2012-03-01 | 1 | -0/+11 | |
| | | | ||||||
* | | | Setting the default role to be a menu item | Ted Gould | 2012-03-01 | 1 | -0/+4 | |
|/ / | ||||||
* | | Do not leak the label text | Alberto Mardegan | 2012-02-22 | 1 | -1/+3 | |
| | | | | | | | | | | Also, fix the indentation from the previous commit. | |||||
* | | Do not read the label text from the label widget | Alberto Mardegan | 2012-02-22 | 1 | -18/+10 | |
|/ | | | | | | | | | The label text stored in the widget might have been modified with markup. Instead of reading it back from the widget, return the text as set by the client, unmodified. Alter the test-gtk-submenu so that the correct behaviour is checked for. | |||||
* | Use defines instead of strings | Ted Gould | 2012-02-15 | 1 | -1/+1 | |
|\ | ||||||
| * | Making sure our strings come from defines to avoid typos | Ted Gould | 2012-02-12 | 1 | -1/+1 | |
| | | ||||||
* | | Fix some of the issues with throwing criticals | Ted Gould | 2012-02-15 | 2 | -8/+8 | |
|\ \ | |/ |/| | ||||||
| * | Don't get the string to check if something is being cleared, use whether the ↵ | Ted Gould | 2012-02-07 | 1 | -6/+1 | |
| | | | | | | | | variant is NULL or not | |||||
| * | Ensuring that we don't just unparent a menu item, we remove it from the list ↵ | Ted Gould | 2012-02-07 | 1 | -2/+7 | |
| | | | | | | | | of children that it has | |||||
* | | Parse and handle a11y descriptions | Ted Gould | 2012-02-10 | 2 | -2/+84 | |
|\ \ | ||||||
| * | | Heh, wrote the code but forgot to handle the error | Ted Gould | 2012-02-10 | 1 | -0/+4 | |
| | | | ||||||
| * | | Refactor setting the ATK Object name into a function that can do all the ↵ | Ted Gould | 2012-02-10 | 1 | -4/+22 | |
| | | | | | | | | | | | | error handling needed. | |||||
| * | | Don't pass a NULL name to set_name | Ted Gould | 2012-02-10 | 1 | -1/+1 | |
| | | | ||||||
| * | | Use the #define property name instead of a string | Ted Gould | 2012-02-10 | 1 | -3/+3 | |
| | | | ||||||
| * | | Adding a detail hint on the notify signal | Ted Gould | 2012-02-10 | 1 | -1/+1 | |
| | | | ||||||
| * | | Fix up monitoring of the atk object, didn't understand that notification was ↵ | Luke Yelavich | 2012-02-01 | 1 | -5/+8 | |
| | | | | | | | | | | | | the same as the GTK widgets as well. | |||||
| * | | When parsing an existing GTK menu hierarchy, we should also set the | Luke Yelavich | 2012-01-31 | 2 | -0/+54 | |
| | | | | | | | | | | | | | | | | | | DBUSMENU_MENU_ITEM_ACCESSIBLE_DESC property, if the accessible name for the menu differs from the text of the menu item label. | |||||
* | | | Don't pass NULL to ATK | Ted Gould | 2012-02-10 | 1 | -1/+1 | |
|\ \ \ | ||||||
| * | | | If the ACCESSIBLE_DESC property is set to NULL, set an empty string as the ↵ | Luke Yelavich | 2012-02-01 | 1 | -1/+1 | |
| | |/ | |/| | | | | | | | atk object's accessible name, as per atk docs. | |||||
* | | | Non-srcdir build fixes | Ted Gould | 2012-02-10 | 1 | -2/+3 | |
|\ \ \ | |/ / |/| | | ||||||
| * | | Fix non-srcdir build issues | Michal Hruby | 2012-01-27 | 1 | -2/+3 | |
| |/ | ||||||
* / | Only setting the accessible object name if it has been set | Ted Gould | 2012-01-26 | 1 | -2/+5 | |
|/ | ||||||
* | Merging trunk again, mistakes | Ted Gould | 2012-01-26 | 1 | -1/+2 | |
|\ | ||||||
| * | Include config.h to get the HAVE_GTK3 define | Ted Gould | 2012-01-26 | 1 | -0/+1 | |
| | | ||||||
| * | Missing comma | Ted Gould | 2012-01-26 | 1 | -1/+1 | |
| | | ||||||
* | | Fix function calls here | Ted Gould | 2012-01-26 | 1 | -2/+2 | |
| | |