From edb01a80ec933d3dbd8a2588a553d2158b799509 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Fri, 6 Apr 2012 13:25:49 -0500 Subject: fix prop_value leak in widget_notify_cb() when a widget's label changes --- libdbusmenu-gtk/parser.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'libdbusmenu-gtk') diff --git a/libdbusmenu-gtk/parser.c b/libdbusmenu-gtk/parser.c index 4492d01..a396d8f 100644 --- a/libdbusmenu-gtk/parser.c +++ b/libdbusmenu-gtk/parser.c @@ -1100,14 +1100,13 @@ widget_notify_cb (GtkWidget *widget, } else if (pspec->name == g_intern_static_string ("label")) { - if (handle_first_label (child)) + if (!handle_first_label (child)) { - return; + dbusmenu_menuitem_property_set (child, + DBUSMENU_MENUITEM_PROP_LABEL, + g_value_get_string (&prop_value)); } - dbusmenu_menuitem_property_set (child, - DBUSMENU_MENUITEM_PROP_LABEL, - g_value_get_string (&prop_value)); } else if (pspec->name == g_intern_static_string ("visible")) { -- cgit v1.2.3