From 33871cdd77a9a3f4f0146bdd9aa2d05c4618efa6 Mon Sep 17 00:00:00 2001 From: Mike Gabriel Date: Tue, 8 Jun 2021 15:50:50 +0200 Subject: tests/mock_pam.c: Don't leak memory pointed to by 'response'. --- tests/mock_pam.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/mock_pam.c b/tests/mock_pam.c index e1b7324..71e0f71 100644 --- a/tests/mock_pam.c +++ b/tests/mock_pam.c @@ -42,8 +42,10 @@ int fake_conv (int __attribute__((unused)) num_msg, response->resp = strdup ("password"); else if (strcmp((*msg)->msg, PAM_FREERDP2_PROMPT_DOMAIN) == 0) response->resp = strdup ("domain"); - else + else { + free(response); return PAM_SYMBOL_ERR; /* leaks... */ + } *resp = response; @@ -73,8 +75,10 @@ int fake_conv_empty_password (int __attribute__((unused)) num_msg, response->resp = strdup (""); else if (strcmp((*msg)->msg, PAM_FREERDP2_PROMPT_DOMAIN) == 0) response->resp = strdup ("domain"); - else + else { + free(response); return PAM_SYMBOL_ERR; /* leaks... */ + } *resp = response; -- cgit v1.2.3