diff options
| author | Ted Gould <ted@gould.cx> | 2012-09-20 08:09:55 +0000 |
|---|---|---|
| committer | Tarmac <> | 2012-09-20 08:09:55 +0000 |
| commit | 84fb97ec2326559940bafd6f7a7b1370fb679d86 (patch) | |
| tree | 5ae9c9e90d8fda96ceeec4f7792849cf9895e9da | |
| parent | 0be6edb877829f491d491e8b0fb7d06916bef499 (diff) | |
| parent | 7bcc0a5ff26e00089a7821efd55d241de9a3a985 (diff) | |
| download | libpam-x2go-84fb97ec2326559940bafd6f7a7b1370fb679d86.tar.gz libpam-x2go-84fb97ec2326559940bafd6f7a7b1370fb679d86.tar.bz2 libpam-x2go-84fb97ec2326559940bafd6f7a7b1370fb679d86.zip | |
Block usernames with spaces. Approved by Albert Astals Cid, jenkins.
| -rw-r--r-- | src/pam-freerdp.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/src/pam-freerdp.c b/src/pam-freerdp.c index ebc98af..607e215 100644 --- a/src/pam-freerdp.c +++ b/src/pam-freerdp.c @@ -126,6 +126,18 @@ get_item (pam_handle_t * pamh, int type) } } + /* The way that xfreerdp does parsing means that we can't handle + spaces in the username. Let's block them as early as possible. + Though, if the xfreerdp part gets fixed, we want this to disappear + http://launchpad.net/bugs/1053102 + */ + if (type == PAM_RUSER) { + if (strstr(promptval, " ") != NULL) { + free(promptval); + return NULL; + } + } + if (type == PAM_RHOST) { char * subloc = strstr(promptval, "://"); if (subloc != NULL) { |