nx-libs, branch pr/dix-cve-fixes

dix: Allow zero-height PutImage requests (fix for X.Org's CVE-2015-3418).

2015-05-31T02:03:55+00:00

The length checking code validates PutImage height and byte width by making sure that byte-width >= INT32_MAX / height. If height is zero, this generates a divide by zero exception. Allow zero height requests explicitly, bypassing the INT32_MAX check. Fix for regression introduced by fix for CVE-2014-8092. v2: backports to nx-libs 3.6.x (Mike Gabriel) v3: port to NXdispatch.c rather than dispatch.c (Mike DePaulo) Signed-off-by: Keith Packard

dix: integer overflow in ProcPutImage() [CVE-2014-8092 1/4]

2015-05-31T01:59:45+00:00

ProcPutImage() calculates a length field from a width, left pad and depth specified by the client (if the specified format is XYPixmap). The calculations for the total amount of memory the server needs for the pixmap can overflow a 32-bit number, causing out-of-bounds memory writes on 32-bit systems (since the length is stored in a long int variable). v2: backport to nx-libs 3.6.x (Mike DePaulo) v3: port to NXdispatch.c rather than dispatch.c (Mike DePaulo) Reported-by: Ilja Van Sprundel Signed-off-by: Alan Coopersmith Reviewed-by: Peter Hutterer Conflicts: dix/dispatch.c

Avoid use-after-free in dix/dixfonts.c: doImageText() [CVE-2013-4396] from xorg/Xserver http://lists.x.org/archives/xorg-announce/2013-October/002332.html

2015-05-31T01:58:57+00:00

Save a pointer to the passed in closure structure before copying it and overwriting the *c pointer to point to our copy instead of the original. If we hit an error, once we free(c), reset c to point to the original structure before jumping to the cleanup code that references *c. Since one of the errors being checked for is whether the server was able to malloc(c->nChars * itemSize), the client can potentially pass a number of characters chosen to cause the malloc to fail and the error path to be taken, resulting in the read from freed memory. Since the memory is accessed almost immediately afterwards, and the X server is mostly single threaded, the odds of the free memory having invalid contents are low with most malloc implementations when not using memory debugging features, but some allocators will definitely overwrite the memory there, leading to a likely crash. v2: Apply to NXdixfonts.c rather than dixfonts.c (Mike DePaulo)

nxcomp/README.on-retroactive-DXPC-license: Some layout and interpunctuation fixes.

2015-05-29T09:15:19+00:00

nxcomp/Misc.cpp: fix build failure introduced in 1f44331574bdbe4069d13e4c26df18094b49e658.

2015-05-28T20:37:22+00:00

Merge branch 'sunweaver-pr/DXPC-re-license-retroactively' into arctica-3.6.x

2015-05-26T14:51:38+00:00

Attributes GH PR #31: https://github.com/ArcticaProject/nx-libs/pull/31

Merge pull request #36 from ArcticaProject/pr/render-cve-fixes

2015-05-26T08:31:46+00:00

XRender CVE fixes for nxagent (X.Org CVE-2014-8100)

Document retroactive re-licensing of the original DXPC code (closes #30).

2015-05-26T07:15:15+00:00

* Update nxcomp/LICENSE. * Add nxcomp/README.on-retroactive-DXPC-license, giving a short overview of the flow of discussions * Add "modified or unmodified" to the license information printed out to stdout in nxcomp/Misc.cpp * Fix copyright year (2006->2003) for Gian Filippo Pinzari (and move him to the GPL-2 section). * Add the complete .mbox file of Debian bug #748565.

Merge branch 'sunweaver-pr/libxrandr-cleanup' into arctica-3.6.x

2015-05-25T21:23:22+00:00

Attributes GH PR #21: https://github.com/ArcticaProject/nx-libs/pull/21

render: unvalidated lengths in Render extn. swapped procs [CVE-2014-8100 2/2]

2015-05-24T23:03:10+00:00

v2: backport to nx-libs 3.6.x (Mike DePaulo) v3: port to NXrender.c rather than render.c (Mike DePaulo) Signed-off-by: Alan Coopersmith Reviewed-by: Peter Hutterer Conflicts: render/render.c