nx-libs/nx-X11/lib/X11/XKBGeom.c, branch 3.5.99.14

Convert nx-X11/lib/ build flow from imake to autotools.

2017-08-25T08:06:49+00:00

rm redundant null checks

2016-10-19T19:40:29+00:00

remove more redundant NULL checks note that _XkbFree() is really Xfree() Signed-off-by: Harms Reviewed-by: Rémi Cardona Signed-off-by: Peter Hutterer Backported-to-NX-by: Ulrich Sibiller

_XkbReadGeomOverlay: check for NULL first, then use pointer

2016-10-19T19:40:29+00:00

Flagged by cppcheck 1.62: [lib/libX11/nx-X11/lib/X11/XKBGeom.c:479] -> [lib/libX11/nx-X11/lib/X11/XKBGeom.c:480]: (warning) Possible null pointer dereference: row - otherwise it is redundant to check it against null. Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

Rearrange some variable declarations & initializations in XKB

2016-10-19T19:40:28+00:00

Little things noticed during XKB restyling that seemed to make the code easier to read. Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

Reindent XKB code to X.Org standard style

2016-10-19T19:40:28+00:00

Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

XKB: XkbComputeSectionBounds: Check correct bounds in default switch-case

2016-10-19T19:40:25+00:00

XKBGeom.c:191:25: warning: Access to field 'x1' results in a dereference of a null pointer (loaded from variable 'rbounds') _XkbCheckBounds(bounds,rbounds->x1,rbounds->y1); ^~~~~~~ Found-by: clang static analyzer Signed-off-by: Jeremy Huddleston Reviewed-by: Peter Hutterer Backported-to-NX-by: Ulrich Sibiller

Dead code removal

2016-10-19T19:40:25+00:00

XKBGeom.c:118:27: warning: Assigned value is always the same as the existing value for (key=row->keys,pos=k=0;knum_keys;k++,key++) { ~~~^~~~ XKBGeom.c:115:5: warning: Value stored to 'pos' is never read pos= 0; ^ ~ Found-by: clang static analyzer Signed-off-by: Jeremy Huddleston Backported-to-NX-by: Ulrich Sibiller

unvalidated indexes in _XkbReadGetGeometryReply() [CVE-2013-1997 4/15]

2016-10-12T07:34:39+00:00

If the X server returns color indexes outside the range of the number of colors it told us to allocate, out of bounds memory access could occur. Reported-by: Ilja Van Sprundel Signed-off-by: Alan Coopersmith Reviewed-by: Matthieu Herrb Signed-off-by: Julien Cristau Backported-to-NX-by: Ulrich Sibiller

unvalidated indexes in _XkbReadGeomShapes() [CVE-2013-1997 3/15]

2016-10-12T07:34:39+00:00

If the X server returns shape indexes outside the range of the number of shapes it told us to allocate, out of bounds memory access could occur. Reported-by: Ilja Van Sprundel Signed-off-by: Alan Coopersmith Reviewed-by: Matthieu Herrb Signed-off-by: Julien Cristau Backported-to-NX-by: Ulrich Sibiller

Lift XKB*.c to libX11 1.3.4

2016-10-10T20:52:30+00:00