nx-libs/nx-X11/lib/X11/XlibInt.c, branch 3.5.99.14

Convert nx-X11/lib/ build flow from imake to autotools.

2017-08-25T08:06:49+00:00

_XDefaultError: set XlibDisplayIOError flag before calling exit

2017-03-26T14:54:20+00:00

_XReply isn't reentrant, and it can lead to deadlocks when the default error handler is called: _XDefaultError calls exit(1). It is called indirectly by _XReply when a X protocol error comes in that isn't filtered/handled by an extension or the application. This means that if the application (or one of its loaded shared libraries such as the NVIDIA OpenGL driver) has registered any _fini destructor, _fini will get called while still on the call stack of _XReply. If the destructor interacts with the X server and calls _XReply, it will hit a deadlock, looping on the following in _XReply: ConditionWait(dpy, dpy->xcb->reply_notify); It is legal for an application to make Xlib calls during _fini, and that is useful for an OpenGL driver to avoid resource leaks on the X server side, for example in the dlopen/dlclose case. However, the driver can not readily tell whether its _fini is being called because Xlib called exit, or for another reason (dlclose), so it is hard to cleanly work around this issue in the driver. This change makes it so _XReply effectively becomes a no-op when called after _XDefaultError was called, as though an XIOError had happened. The dpy connection isn't broken at that point, but any call to _XReply is going to hang. This is a bit of a kludge, because the more correct solution would be to make _XReply reentrant, maybe by broadcasting the reply_notify condition before calling the default error handler. However, such a change would carry a grater risk of introducing regressions in Xlib. This change will drop some valid requests on the floor, but this should not matter, as it will only do so in the case where the application is dying: X will clean up after it once exit() is done running. There is the case of XSetCloseDownMode(RETAIN_PERMANENT), but an application using that and wishing to clean up resources in _fini would currently be hitting a deadlock, which is hardly a better situation. Signed-off-by: Aaron Plattner Reviewed-by: Jamey Sharp

drop platform support: unifdef QNX.

2017-02-08T21:40:47+00:00

Relates to ArcticaProject/nx-libs#275.

drop platform support: unifdef AIXV3, AIXV4 (and AIXrt, AIX386).

2017-02-08T21:40:46+00:00

Fixes ArcticaProject/nx-libs#274.

drop platform support: unifdef hpux and hppa.

2017-02-08T21:40:46+00:00

Fixes ArcticaProject/nx-libs#273.

drop platform support: unifdef UNIXOS2.

2017-02-08T21:40:46+00:00

Fixes ArcticaProject/nx-libs#271.

Fixes: warning: variable 'req' set but not,used

2016-10-20T08:16:35+00:00

Fixes: warning: variable 'req' set but not used [-Wunused-but-set-variable] by marking req _X_UNUSED Solution was discussed on xorg-devel ML Peter Hutter, Alan Coopersmith Re: [PATCH libX11 3/5] fix: warning: pointer targets in passing argument 2 of '_XSend' differ in signedness [-Wpointer-sign] Signed-off-by: harms wharms@bfs.de

Fix warnings in XlibInt.c

2016-10-20T08:16:35+00:00

XlibInt.c: In function ‘_XIOError’: XlibInt.c:3750:1: warning: ‘noreturn’ function does return [enabled by default] } After fixing the above a new warning came up, which is also fixed now: XlibInt.c: In function ‘_XIOError’: XlibInt.c:3750:1: warning: control reaches end of non-void function [-Wreturn-type] }

Do not return() after exit().

2016-10-19T19:40:29+00:00

Signed-off-by: Thomas Klausner Reviewed-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

Remove redundant null checks before free

2016-10-19T19:40:29+00:00

This patch removes some redundant null checks before free. It should not change the code otherwise. Be aware that this is only the first series. Signed-off-by: Harms Reviewed-by: Alan Coopersmith Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

nx-libs/nx-X11/lib/X11/XlibInt.c, branch 3.5.99.14

Convert nx-X11/lib/ build flow from imake to autotools.

_XDefaultError: set XlibDisplayIOError flag before calling exit

drop platform support: unifdef QNX.

drop platform support: unifdef AIXV3, AIXV4 (and AIXrt, AIX386).

drop platform support: unifdef hpux and __hppa__.

drop platform support: unifdef __UNIXOS2__.

Fixes: warning: variable 'req' set but not,used

Fix warnings in XlibInt.c

Do not return() after exit().

Remove redundant null checks before free

drop platform support: unifdef hpux and hppa.

drop platform support: unifdef UNIXOS2.