nx-libs/nx-X11/lib/X11/Xrm.c, branch 3.5.99.14

Convert nx-X11/lib/ build flow from imake to autotools.

2017-08-25T08:06:49+00:00

drop platform support: unifdef UNIXOS2.

2017-02-08T21:40:46+00:00

Fixes ArcticaProject/nx-libs#271.

Fix typos in Xrm.c comments

2016-10-19T19:40:29+00:00

Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

Remove unnecessary casts of pointers to (char *) in calls to Xfree()

2016-10-19T19:40:28+00:00

Left one cast behind that is necessary to change from const char * to char * in nx-X11/lib/X11/lcCharSet.c. Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

Align files with upstream libX11-1.6.0

2016-10-19T19:40:27+00:00

This commit looks a bit crazy at first glance. It (re-)introduces lots of whitespaces and bad formatting. Explanation: Backporting upstream changes lead to commits being applied out of order. This meant a lot of manual intervention which in turn lead to slight differences between upstream and NX. With this commit these slight differences are minimized which will be of great help when adding further upstream patches.

integer overflow in ReadInFile() in Xrm.c [CVE-2013-1981 7/13]

2016-10-19T19:40:27+00:00

Called from XrmGetFileDatabase() which gets called from InitDefaults() which gets the filename from getenv ("XENVIRONMENT") If file is exactly 0xffffffff bytes long (or longer and truncates to 0xffffffff, on implementations where off_t is larger than an int), then size may be set to a value which overflows causing less memory to be allocated than is written to by the following read() call. size is left limited to an int, because if your Xresources file is larger than 2gb, you're very definitely doing it wrong. Reported-by: Ilja Van Sprundel Signed-off-by: Alan Coopersmith Reviewed-by: Matthieu Herrb Backported-to-NX-by: Ulrich Sibiller

Remove more unnecessary casts from Xmalloc/calloc calls

2016-10-19T19:40:27+00:00

Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

Remove "register" qualifier that annoys Solaris Studio compiler

2016-10-19T19:40:25+00:00

Fixes warning: "Xrm.c", line 1094: warning: storage class after type is obsolescent Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

Replace Xmalloc+bzero pairs with Xcalloc calls

2016-10-19T19:40:25+00:00

Signed-off-by: Alan Coopersmith Reviewed-by: Jeremy Huddleston Backported-to-NX-by: Ulrich Sibiller

Xrm.c: ReadInFile: refactor fstat error handling

2016-10-19T19:40:24+00:00

We can simplify the fstat failure case now that the GetFileSize macro has been expanded inline. Signed-off-by: Alan Coopersmith Reviewed-by: Julien Cristau Backported-to-NX-by: Ulrich Sibiller

nx-libs/nx-X11/lib/X11/Xrm.c, branch 3.5.99.14

Convert nx-X11/lib/ build flow from imake to autotools.

drop platform support: unifdef __UNIXOS2__.

Fix typos in Xrm.c comments

Remove unnecessary casts of pointers to (char *) in calls to Xfree()

Align files with upstream libX11-1.6.0

integer overflow in ReadInFile() in Xrm.c [CVE-2013-1981 7/13]

Remove more unnecessary casts from Xmalloc/calloc calls

Remove "register" qualifier that annoys Solaris Studio compiler

Replace Xmalloc+bzero pairs with Xcalloc calls

Xrm.c: ReadInFile: refactor fstat error handling

drop platform support: unifdef UNIXOS2.