nx-libs/nx-X11/lib, branch 3.5.99.12

lib/X11/Xrm.c: Compiler warning fix: logical-not-parentheses

2017-12-14T09:40:32+00:00

Xrm.c: In function 'PutEntry': Xrm.c:900:15: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] !quarks[2] != table->leaf) ^~

Silence warning: "ar: 'u' modifier ignored since 'D' is the default"

2017-12-11T08:48:14+00:00

Fixes ArcticaProject/nx-libs#530

Xtranssock.c: simplify code in SocketWritev

2017-12-11T08:45:06+00:00

Code was here twice and could be simply merged.

nx-X11/lib/include/xtrans/Xtranssock.c: drop UNIX path overrides as well.

2017-11-22T05:16:04+00:00

Was missed in GH PR #544: https://github.com/ArcticaProject/nx-libs/pull/544 Fixes: ArcticaProject/nx-libs#536

.gitignore: Improve all .gitignore files, adapt to autotools build-flow and its build cruft.

2017-10-09T10:52:01+00:00

Convert nx-X11/lib/ build flow from imake to autotools.

2017-08-25T08:06:49+00:00

nxcomp: Switch to autoreconf.

2017-07-26T08:12:43+00:00

nxcompshad: Switch to autoreconf.

2017-07-13T09:38:42+00:00

remove _X_DEPRECATED for XKeycodeToKeysym

2017-05-04T21:50:17+00:00

We need that function for performance reasons. By removing _X_DEPRECATED we get rid of compiler warnings.

_XDefaultError: set XlibDisplayIOError flag before calling exit

2017-03-26T14:54:20+00:00

_XReply isn't reentrant, and it can lead to deadlocks when the default error handler is called: _XDefaultError calls exit(1). It is called indirectly by _XReply when a X protocol error comes in that isn't filtered/handled by an extension or the application. This means that if the application (or one of its loaded shared libraries such as the NVIDIA OpenGL driver) has registered any _fini destructor, _fini will get called while still on the call stack of _XReply. If the destructor interacts with the X server and calls _XReply, it will hit a deadlock, looping on the following in _XReply: ConditionWait(dpy, dpy->xcb->reply_notify); It is legal for an application to make Xlib calls during _fini, and that is useful for an OpenGL driver to avoid resource leaks on the X server side, for example in the dlopen/dlclose case. However, the driver can not readily tell whether its _fini is being called because Xlib called exit, or for another reason (dlclose), so it is hard to cleanly work around this issue in the driver. This change makes it so _XReply effectively becomes a no-op when called after _XDefaultError was called, as though an XIOError had happened. The dpy connection isn't broken at that point, but any call to _XReply is going to hang. This is a bit of a kludge, because the more correct solution would be to make _XReply reentrant, maybe by broadcasting the reply_notify condition before calling the default error handler. However, such a change would carry a grater risk of introducing regressions in Xlib. This change will drop some valid requests on the floor, but this should not matter, as it will only do so in the case where the application is dying: X will clean up after it once exit() is done running. There is the case of XSetCloseDownMode(RETAIN_PERMANENT), but an application using that and wishing to clean up resources in _fini would currently be hitting a deadlock, which is hardly a better situation. Signed-off-by: Aaron Plattner Reviewed-by: Jamey Sharp