NXv3 (redistributed) https://cgit.arctica-project.org/nx-libs/atom?h=3.5.99.8 2017-05-04T21:50:17+00:00 2017-05-04T21:50:17+00:00 Ulrich Sibiller uli42@gmx.de 2017-05-04T21:35:30+00:00 urn:sha1:c59710e8eb2d641b0f14d99a4ed14399a0cc7ac5 We need that function for performance reasons. By removing _X_DEPRECATED we get rid of compiler warnings. 2017-03-26T14:54:20+00:00 Arthur Huillet ahuillet@nvidia.com 2017-02-01T14:02:41+00:00 urn:sha1:00405b278471b4b5aa65003eb7ae97ac17d56445 _XReply isn't reentrant, and it can lead to deadlocks when the default error handler is called: _XDefaultError calls exit(1). It is called indirectly by _XReply when a X protocol error comes in that isn't filtered/handled by an extension or the application. This means that if the application (or one of its loaded shared libraries such as the NVIDIA OpenGL driver) has registered any _fini destructor, _fini will get called while still on the call stack of _XReply. If the destructor interacts with the X server and calls _XReply, it will hit a deadlock, looping on the following in _XReply: ConditionWait(dpy, dpy->xcb->reply_notify); It is legal for an application to make Xlib calls during _fini, and that is useful for an OpenGL driver to avoid resource leaks on the X server side, for example in the dlopen/dlclose case. However, the driver can not readily tell whether its _fini is being called because Xlib called exit, or for another reason (dlclose), so it is hard to cleanly work around this issue in the driver. This change makes it so _XReply effectively becomes a no-op when called after _XDefaultError was called, as though an XIOError had happened. The dpy connection isn't broken at that point, but any call to _XReply is going to hang. This is a bit of a kludge, because the more correct solution would be to make _XReply reentrant, maybe by broadcasting the reply_notify condition before calling the default error handler. However, such a change would carry a grater risk of introducing regressions in Xlib. This change will drop some valid requests on the floor, but this should not matter, as it will only do so in the case where the application is dying: X will clean up after it once exit() is done running. There is the case of XSetCloseDownMode(RETAIN_PERMANENT), but an application using that and wishing to clean up resources in _fini would currently be hitting a deadlock, which is hardly a better situation. Signed-off-by: Aaron Plattner <aplattner@nvidia.com> Reviewed-by: Jamey Sharp <jamey@minilop.net> 2017-03-26T14:54:20+00:00 Julien Cristau jcristau@debian.org 2017-01-07T15:20:31+00:00 urn:sha1:8ad49a03ebebffbdbf21c4ef9775b7e5847496d9 'ch' gets moved inside the allocated buffer as we're looping through fonts, so keep a reference to the start of the buffer so we can pass that to Xfree in the failure case. Fixes: commit 20a3f99eba5001925b8b313da3accb7900eb1927 "Plug a memory leak" Signed-off-by: Julien Cristau <jcristau@debian.org> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> 2017-03-03T12:45:25+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2017-02-04T10:09:37+00:00 urn:sha1:09cf1bcc0cc5f8b9d33b25e46320a9725742a38e - Support for i18n in libNX_X11 is static only, has ever been. - Thus, the files XlcSL.[co], XlcDL.[co], XDefaultIMIF.[co], XDefaultOMIF.[co] and lcDynamic.[co] become obsolete. 2017-03-03T12:45:25+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2017-02-04T09:55:12+00:00 urn:sha1:ba27cae6369308fd3498c476bbfc3f1c554f8017 2017-03-03T12:45:25+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2017-02-04T09:52:05+00:00 urn:sha1:949f5e04efd80f2892f960f04a7454bc58f1d212 2017-02-08T21:40:47+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2016-11-15T21:03:39+00:00 urn:sha1:2d45d8d805df95f7277d333e026a008dbd07f479 Relates to ArcticaProject/nx-libs#275. 2017-02-08T21:40:47+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2016-11-15T20:51:55+00:00 urn:sha1:c6250a86468b1c2c23d41b27c4d6e438518ec917 Relates to ArcticaProject/nx-libs#275. 2017-02-08T21:40:47+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2016-11-15T20:32:46+00:00 urn:sha1:a9c30796dce587627524ffa886eeef5e73144c46 Fixes ArcticaProject/nx-libs#288. 2017-02-08T21:40:46+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2016-11-15T20:20:22+00:00 urn:sha1:4b178918ba19ebd9daa6f87fa790b6f6767b1f61 Fixes ArcticaProject/nx-libs#274.