nx-libs/nx-X11/programs/Xserver/os, branch 3.5.99.0

VCS info lines: Remove ancient X.org / XFree86 VCS info line from code files.

2016-07-05T23:09:15+00:00

This has already been started while replacing copyright info in file headers and has now been completed with this commit.

Per-file copyright notices: Update copyright information in file headers that NoMachine placed there own copyright statement in.

2016-07-05T23:07:24+00:00

remove unreferenced NEED_EVENTS/NEED_REPLIES

2016-07-05T20:55:07+00:00

Remove defines of NEED_EVENTS and NEED_REPLIES because they are never used anywhere. Basically these three commits, but as they are newer and to not match the code structure the patches have not been applied but replaced by sed + manual intervention: From cb95642dc8edebb2935dd471f8b339cb98aa8481 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Fri, 28 Nov 2008 22:28:32 +1000 Subject: Remove #define NEED_EVENTS and NEED_REPLIES A grep on xorg/* revealed there's no consumer of this define. Quote Alan Coopersmith: "The consumer was in past versions of the headers now located in proto/x11proto - for instance, in X11R6.0's xc/include/Xproto.h, all the event definitions were only available if NEED_EVENTS were defined, and all the reply definitions required NEED_REPLIES. Looks like Xproto.h dropped them by X11R6.3, which didn't have the #ifdef's anymore, so these are truly ancient now." Signed-off-by: Peter Hutterer Signed-off-by: Adam Jackson -- From 6de368c9aa7ccd2fcd62fca5a2b278913db4d03d Mon Sep 17 00:00:00 2001 From: Fernando Carrijo Date: Thu, 1 Jul 2010 06:50:47 -0300 Subject: Purge macros NEED_EVENTS and NEED_REPLIES Signed-off-by: Fernando Carrijo Acked-by: Tiago Vignatti Reviewed-by: Alan Coopersmith -- From 57c03e52e6b4e3ed54df5fdd778865467d08e119 Mon Sep 17 00:00:00 2001 From: Fernando Carrijo Date: Thu, 1 Jul 2010 06:59:48 -0300 Subject: Purge macro NEED_EVENTS Signed-off-by: Fernando Carrijo Acked-by: Tiago Vignatti Reviewed-by: Alan Coopersmith

Remove unneccesary casts from WriteToClient calls

2016-07-05T11:32:05+00:00

Casting return to (void) was used to tell lint that you intended to ignore the return value, so it didn't warn you about it. Casting the third argument to (char *) was used as the most generic pointer type in the days before compilers supported C89 (void *) (except for a couple places it's used for byte-sized pointer math). Signed-off-by: Alan Coopersmith Reviewed-by: Keith Packard Tested-by: Daniel Stone Backport to nx-libs: Mike Gabriel

Make WriteToClient take a const void * like any decent IO write function.

2016-07-05T11:32:04+00:00

Enough with the casting. Doesn't break API or even ABI, but does make a lot of silly casts superfluos.

Make WriteEventsToClient/WriteToClient no-op on fake or dead clients.

2016-07-05T06:38:36+00:00

This matches the test in TryClientEvents, and is a superset of tests done by the callers of these functions. The consequence of forgetting these tests is a server crash, so they're always desirable. In my opinion, it's better to not require the callers to remember to do these checks. For callers that don't do very much work before calling WriteToClient or WriteEventsToClient, I've removed the redundant checks. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=27497 Signed-off-by: Jamey Sharp Cc: Chris Wilson Reviewed-by: Julien Cristau Reviewed-by: Adam Jackson Backport to nx-libs: Mike Gabriel

Xserver/os/xdmauth.c: Avoid compiler warnings due to -Wswitch being enabled. Use if statement rather than switch.

2016-07-05T06:11:42+00:00

Backported from X.org. Found in commit... commit 7deaaa797cf8e7ca71e9b34fa6f413d1ed2b3dab Author: Adam Jackson Date: Tue Mar 28 01:21:00 2006 +0000

Xserver/os/log.c: Make sure strlcpy is defined in log.c. Immitate what is done in X.org.

2016-07-05T06:11:42+00:00

Restore compression of duplicate log file entries.

2016-07-05T06:11:42+00:00

This undoes the workaround for X.org bug #964, which was an Xprintism.

os: Make sure that writing our pid to the lock file actually worked

2016-07-05T06:11:42+00:00

There's no sense verifying that we can create the lock file and then ignoring the return value from write. Signed-off-by: Keith Packard Reviewed-by: Jamey Sharp Backport to nx-libs: Mike Gabriel