NXv3 (redistributed) https://cgit.arctica-project.org/nx-libs/atom?h=pr%2Ffix_xkb_crash 2019-05-17T13:54:26+00:00 2019-05-17T13:54:26+00:00 Ulrich Sibiller uli42@gmx.de 2019-05-15T17:42:29+00:00 urn:sha1:148eda36d486c0af019267a644c08d5e8c2f4f8b Fixes ArcticaProject/nx-libs#808 2019-05-10T17:02:51+00:00 Ulrich Sibiller uli42@gmx.de 2019-04-29T20:02:24+00:00 urn:sha1:ff5740e039c05e04952496fe67385187daa53222 2018-12-17T23:05:50+00:00 Ulrich Sibiller uli42@gmx.de 2018-12-17T23:05:50+00:00 urn:sha1:5b0bf752a0c5a224ddf42cccdcb37534357c08ab Backport of commit dc9ce695a69ca0787f58f8d160212a7a41acb703 Author: Rami Ylimäki <rami.ylimaki@vincit.fi> Date: Wed Mar 9 15:45:40 2011 +0200 xkb: Initialize pad bytes sent in replies of geometry requests. Valgrind complains about uninitialized data being written to clients. Reviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi> Signed-off-by: Rami Ylimäki <rami.ylimaki@vincit.fi> Reviewed-by: Daniel Stone <daniel@fooishbar.org> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> 2018-12-17T22:58:16+00:00 Ulrich Sibiller uli42@gmx.de 2018-12-17T22:58:16+00:00 urn:sha1:a4fad8f58e8c7f601f70801016861f970ab05827 Backport of commit 81b3b0cce088866dc3cda099d7c8d6655849fd43 Author: Tomas Janousek <tomi@nomi.cz> Date: Wed May 20 15:03:01 2009 +0200 Bug #6428, #16458, #21464: Fix crash due to uninitialized VModMap fields. In ProcXkbGetKbdByName, mrep.firstVModMapKey, .nVModMapKeys and .totalVModMapKeys were not initialized, contained random values and caused accesses to unallocated and later modified memory, causing XkbSizeVirtualModMap and XkbWriteVirtualModMap to see different number of nonzero values, resulting in writes past the end of an array in XkbSendMap. This patch initializes those values sensibly and reverts commits 5c0a2088 and 6dd4fc46, which have been plain non-sense. Signed-off-by: Tomas Janousek <tomi@nomi.cz> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> 2018-11-09T14:31:57+00:00 Ulrich Sibiller uli42@gmx.de 2018-10-29T23:00:45+00:00 urn:sha1:b09a72b08c7effeac42652f087f0b8f16bc74763 This commit + some more adaption in ddxLoad.c which where no longer present when Alan did the patch. However, our code still has them: Author: Alan Coopersmith <alan.coopersmith@oracle.com> Date: Sat Nov 27 20:09:04 2010 -0800 Convert existing Xprintf style calls to asprintf style Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com> Reviewed-by: Mikhail Gusarov <dottedmag@dottedmag.net> Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de> 2018-11-09T14:31:57+00:00 Ulrich Sibiller uli42@gmx.de 2018-10-29T22:39:03+00:00 urn:sha1:b01e29efffafe9f426eb88ba400e2fa24de548aa Author: Pauli Nieminen <ext-pauli.nieminen@nokia.com> Date: Thu Jul 22 11:34:54 2010 +0300 xkb: Don't check for NULL before calling free Signed-off-by: Pauli Nieminen <ext-pauli.nieminen@nokia.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de> 2018-11-09T14:31:57+00:00 Ulrich Sibiller uli42@gmx.de 2018-10-29T22:34:10+00:00 urn:sha1:90b83a79e6aed4e54ac29d022adf16be6869f054 Author: Pauli Nieminen <ext-pauli.nieminen@nokia.com> Date: Thu Jul 22 11:33:33 2010 +0300 xkb: Fix memory leak if opening file fails If fopen fails pointer in buf would be overwriten with a new pointer. Signed-off-by: Pauli Nieminen <ext-pauli.nieminen@nokia.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de> 2018-11-09T14:31:57+00:00 Ulrich Sibiller uli42@gmx.de 2018-10-24T22:46:12+00:00 urn:sha1:f23189e7392254c9458bf76504920cb868360e40 2018-11-09T14:31:57+00:00 Ulrich Sibiller uli42@gmx.de 2018-07-25T20:39:17+00:00 urn:sha1:824b629732ed90e6040790eb07fe8271d5fb8fb3 Backported from Xorg: commit f292de2ef13dc994a38029cee9e2642576893332 Author: Daniel Stone <daniel@fooishbar.org> Date: Wed Mar 21 02:04:12 2007 +0200 XKB: Fix size_syms calculation bug Apparently it needed to be nSyms*15/10, not *12/10; make it match the other allocation code. Backported-to-nx-by: Ulrich Sibiller <uli42@gmx.de> 2018-11-09T14:31:57+00:00 Ulrich Sibiller uli42@gmx.de 2018-07-18T21:54:46+00:00 urn:sha1:3c1b1efad2ca42154789f09e2519630c5471ed41 commit 7c4c00649cae855e141ec9a3667bfe399e3156d0 Author: Daniel Stone <daniel@fooishbar.org> Date: Thu Jan 1 05:25:52 2009 +1100 XKB: Remove unused DDX functions They were complete no-ops anyway. Signed-off-by: Daniel Stone <daniel@fooishbar.org> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Backported-to-nx-by: Ulrich Sibiller <uli42@gmx.de>