NXv3 (redistributed) https://cgit.arctica-project.org/nx-libs/atom?h=3713346f 2016-05-31T09:23:40+00:00 2016-05-31T09:23:40+00:00 Nito Martinez Nito@Qindel.ES 2016-05-31T09:23:40+00:00 urn:sha1:035995a8c16e8867f209100330653b33de06f458 2016-04-27T11:59:34+00:00 Salvador Fandino sfandino@yahoo.com 2016-04-20T14:22:56+00:00 urn:sha1:3713346f3959782c5e5d1ddd0252f25fb319d732 2016-04-27T11:56:55+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2016-04-27T11:56:55+00:00 urn:sha1:b326eda7328e95200f7d70efde35ce51a14bab3d 2016-04-27T10:46:00+00:00 Fernando Carvajal fcarvajal@qindel.com 2016-04-25T10:53:00+00:00 urn:sha1:a436cba04834da945d4a2be5335d1d7e95c6bf08 This commit removes several warnings in nxcomp related to unused but set variables. It also replaces tempnam function with the more secure one mkstemp and there has been removed another warning related to setgid and setuid returning values not being checked. So these were the compiler warnings in nxcomp that have been fixed: Loop.cpp: In function ‘int ParseRemoteOptions(char*)’: Loop.cpp:9423:7: warning: variable ‘hasLimit’ set but not used [-Wunused-but-set-variable] int hasLimit = 0; ^ Loop.cpp:9424:7: warning: variable ‘hasRender’ set but not used [-Wunused-but-set-variable] int hasRender = 0; ^ Loop.cpp:9425:7: warning: variable ‘hasTaint’ set but not used [-Wunused-but-set-variable] int hasTaint = 0; ^ Loop.cpp:9427:7: warning: variable ‘hasStrict’ set but not used [-Wunused-but-set-variable] int hasStrict = 0; ^ Loop.cpp:9428:7: warning: variable ‘hasShseg’ set but not used [-Wunused-but-set-variable] int hasShseg = 0; ^ ServerChannel.cpp: In member function ‘virtual int ServerChannel::handleWrite(const unsigned char*, unsigned int)’: ServerChannel.cpp:2132:9: warning: variable ‘hit’ set but not used [-Wunused-but-set-variable] int hit; ^ Proxy.o: In function `Proxy::handleSaveAllStores(char const*) const': Proxy.cpp:(.text+0x2cac): warning: the use of `tempnam' is dangerous, better use `mkstemp' Pipe.cpp: In function ‘FILE* Popen(char* const*, const char*)’: Pipe.cpp:240:23: warning: ignoring return value of ‘int setgid(__gid_t)’, declared with attribute warn_unused_result [-Wunused-result] setgid(getgid()); ^ Pipe.cpp:241:23: warning: ignoring return value of ‘int setuid(__uid_t)’, declared with attribute warn_unused_result [-Wunused-result] setuid(getuid()); ^ There was also a hidden problem in the way Proxy::handleSaveAllStores was checking for an error in the returning value from the call to the virtual method handleSaveAllStores of the specific proxy class really being used (ClientProxy or ServerProxy). Former code was considering the value 0 as the returning value in case of an error whereas both subclasses return the value -1 when there is an error in their handleSaveAllStores method. This bug has been fixed in this commit taking advantage of the modification that was already being made to this method in order to replace tempnam function with the more secure one mkstemp. Fixes: ArcticaProject/nx-libs#103 2016-04-20T14:10:34+00:00 Salvador Fandino sfandino@yahoo.com 2016-04-20T13:46:16+00:00 urn:sha1:7d053959f6ce971d15914dab32de5e145e0f10dc It was GPL3 instead of GPL2! Fixes ArcticaProject/nx-libs#112 2016-04-15T07:49:09+00:00 Fernando Carvajal fcarvajal@qindel.com 2016-04-15T07:49:09+00:00 urn:sha1:5c495241069708e9b1bbf6e57fd49599be540b63 This commit removes TextCompressor class references from ClientCache and ServerCache as it's no longer used after removing old protocol's compatibility code from nxcomp. It also removes the attribute textCache from both classes as it's no longer used either. Finally the header and source files associated with the TextCompressor class are also deleted and removed from the compilation process. Refs: ArcticaProject/nx-libs#108 2016-04-12T14:03:37+00:00 Fernando Carvajal fcarvajal@qindel.com 2016-04-12T14:03:37+00:00 urn:sha1:134648169cd0a9359e1a8a31a5bb55a307b0a801 This commit removes obsolete compatibility files whose components were only used to handle compatibility with old protocol versions that are no longer supported. Refs: ArcticaProject/nx-libs#108 2016-04-12T10:07:53+00:00 Fernando Carvajal fcarvajal@qindel.com 2016-04-12T09:52:22+00:00 urn:sha1:a9be6f59105b7cf29bb799556274dc2c3b3d2af8 As a part of nxcomp's clean-up process, compatibility with old protocol versions has been set now at 3.5.0. This commit removes compatibility code from nxcomp so the minimum supported version changes from 1.5.0 (protocol step 6) to 3.5.0 (protocol step 10). At this moment the removal is not complete and it will be followed by some other commits, in order to get rid of several components and files that are no longer used as they were only needed to work with old protocol versions. Refs: ArcticaProject/nx-libs#108 2016-03-22T19:05:15+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2016-03-22T19:03:42+00:00 urn:sha1:2ffe52c5ecb7cf6af111c685eee7f8fcfd1139a9 Fixes ArcticaProject/nx-libs#104 2016-03-02T08:33:13+00:00 Nito Martinez Nito@Qindel.ES 2016-03-02T08:33:13+00:00 urn:sha1:b8c5f677c7f56024a14db457f99eda12d8e809fb