diff options
| author | Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> | 2011-01-31 14:02:07 +0200 |
|---|---|---|
| committer | Ulrich Sibiller <uli42@gmx.de> | 2016-10-19 21:40:24 +0200 |
| commit | ae4e7538e078aff5db75af7b5fafdbb5658cbbb6 (patch) | |
| tree | 49e9662cd92c9704893ad0aebd9f4a338541820d | |
| parent | 26270ab1cf15520043b1d138916fce394780e279 (diff) | |
| download | nx-libs-ae4e7538e078aff5db75af7b5fafdbb5658cbbb6.tar.gz nx-libs-ae4e7538e078aff5db75af7b5fafdbb5658cbbb6.tar.bz2 nx-libs-ae4e7538e078aff5db75af7b5fafdbb5658cbbb6.zip | |
xcms/LRGB: don't double-free property_return
property_return was free'd before and in the case the conditional is true,
the call to XcmsGetProperty failed which means that property_return wasn't
set so there is no need to free it again.
Double free of pointer "property_return" in call to "free"
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi>
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>
| -rw-r--r-- | nx-X11/lib/X11/LRGB.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/nx-X11/lib/X11/LRGB.c b/nx-X11/lib/X11/LRGB.c index f2027ea3f..08c7105ab 100644 --- a/nx-X11/lib/X11/LRGB.c +++ b/nx-X11/lib/X11/LRGB.c @@ -573,7 +573,6 @@ LINEAR_RGB_InitSCCData( if (CorrectAtom == None || !_XcmsGetProperty (dpy, RootWindow(dpy, screenNumber), CorrectAtom, &format_return, &nitems, &nbytes_return, &property_return)) { - Xfree ((char *)property_return); goto FreeSCCData; } |