aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUlrich Sibiller <uli42@gmx.de>2019-07-22 18:16:20 +0200
committerUlrich Sibiller <uli42@gmx.de>2019-08-06 21:57:32 +0200
commitb8411180ed1f3567ab5ca11d70834907fc54d711 (patch)
tree4643c2c96f71ffafa78370413f8d44505bb1a0ce
parent1330167fa2026e4d2ad1d470ebfde9977d131ab3 (diff)
downloadnx-libs-b8411180ed1f3567ab5ca11d70834907fc54d711.tar.gz
nx-libs-b8411180ed1f3567ab5ca11d70834907fc54d711.tar.bz2
nx-libs-b8411180ed1f3567ab5ca11d70834907fc54d711.zip
Display.c: safe some lines by calling SAFE_XFree and SAFE_free
-rw-r--r--nx-X11/programs/Xserver/hw/nxagent/Display.c65
1 files changed, 16 insertions, 49 deletions
diff --git a/nx-X11/programs/Xserver/hw/nxagent/Display.c b/nx-X11/programs/Xserver/hw/nxagent/Display.c
index 127874962..1c18ad1a3 100644
--- a/nx-X11/programs/Xserver/hw/nxagent/Display.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Display.c
@@ -71,6 +71,7 @@ is" without express or implied warranty.
#include "Init.h"
#include "Args.h"
#include "Image.h"
+#include "Utils.h"
#define Pixmap XlibPixmap
#include "Icons.h"
@@ -1543,7 +1544,7 @@ void nxagentInitVisuals(void)
nxagentNumVisuals * sizeof(XVisualInfo));
}
- XFree(viList);
+ SAFE_XFree(viList);
if (nxagentNumVisuals == 0 || nxagentVisuals == NULL)
{
@@ -1765,20 +1766,11 @@ void nxagentCloseDisplay(void)
* traffic
*/
- free(nxagentDefaultColormaps);
- nxagentDefaultColormaps = NULL;
-
- XFree(nxagentVisuals);
- nxagentVisuals = NULL;
-
- free(nxagentDepths);
- nxagentDepths = NULL;
-
- XFree(nxagentPixmapFormats);
- nxagentPixmapFormats = NULL;
-
- XFree(nxagentRemotePixmapFormats);
- nxagentRemotePixmapFormats = NULL;
+ SAFE_free(nxagentDefaultColormaps);
+ SAFE_free(nxagentDepths);
+ SAFE_XFree(nxagentVisuals);
+ SAFE_XFree(nxagentPixmapFormats);
+ SAFE_XFree(nxagentRemotePixmapFormats);
nxagentFreeFontCache();
/*
@@ -2017,11 +2009,7 @@ void nxagentBackupDisplayInfo(void)
nxagentNumDefaultColormapsRecBackup = nxagentNumDefaultColormaps;
nxagentVisualsRecBackup = nxagentVisuals;
nxagentNumVisualsRecBackup = nxagentNumVisuals;
- if (nxagentVisualHasBeenIgnored)
- {
- free(nxagentVisualHasBeenIgnored);
- nxagentVisualHasBeenIgnored = NULL;
- }
+ SAFE_free(nxagentVisualHasBeenIgnored);
nxagentVisualHasBeenIgnored = malloc(nxagentNumVisuals * sizeof(Bool));
nxagentDefaultDepthRecBackup = DefaultDepth(nxagentDisplay, DefaultScreen(nxagentDisplay));
nxagentDisplayWidthRecBackup = DisplayWidth(nxagentDisplay, DefaultScreen(nxagentDisplay));
@@ -2033,20 +2021,11 @@ void nxagentBackupDisplayInfo(void)
void nxagentCleanupBackupDisplayInfo(void)
{
- free(nxagentDepthsRecBackup);
- nxagentNumDepthsRecBackup = 0;
+ SAFE_free(nxagentDepthsRecBackup);
+ SAFE_free(nxagentVisualsRecBackup);
+ SAFE_free(nxagentVisualHasBeenIgnored);
nxagentNumDefaultColormapsRecBackup = 0;
-
- free(nxagentVisualsRecBackup);
- nxagentNumVisualsRecBackup = 0;
-
- if (nxagentVisualHasBeenIgnored)
- {
- free(nxagentVisualHasBeenIgnored);
- nxagentVisualHasBeenIgnored = NULL;
- }
-
nxagentDefaultDepthRecBackup = 0;
nxagentDisplayWidthRecBackup = 0;
nxagentDisplayHeightRecBackup = 0;
@@ -2054,7 +2033,6 @@ void nxagentCleanupBackupDisplayInfo(void)
if (nxagentDisplayBackup)
{
XCloseDisplay(nxagentDisplayBackup);
-
nxagentDisplayBackup = NULL;
}
@@ -2066,7 +2044,7 @@ void nxagentCleanupBackupDisplayInfo(void)
}
else
{
- free(nxagentBitmapGCBackup);
+ SAFE_free(nxagentBitmapGCBackup);
}
nxagentBitmapGCBackup = NULL;
@@ -2569,7 +2547,7 @@ FIXME: Should the visual be ignored in this case?
}
}
- XFree(viList);
+ SAFE_XFree(viList);
if (compatible)
{
@@ -2585,7 +2563,7 @@ FIXME: Should the visual be ignored in this case?
fprintf(stderr, "nxagentInitAndCheckVisuals: New visuals don't match with old visuals.\n");
#endif
- free(newVisuals);
+ SAFE_free(newVisuals);
}
return compatible;
@@ -2766,19 +2744,8 @@ Bool nxagentReconnectDisplay(void *p0)
* will be reallocated in nxagentInitPixmapFormats().
*/
- if (nxagentPixmapFormats != NULL)
- {
- XFree(nxagentPixmapFormats);
-
- nxagentPixmapFormats = NULL;
- }
-
- if (nxagentRemotePixmapFormats != NULL)
- {
- XFree(nxagentRemotePixmapFormats);
-
- nxagentRemotePixmapFormats = NULL;
- }
+ SAFE_XFree(nxagentPixmapFormats);
+ SAFE_XFree(nxagentRemotePixmapFormats);
/*
* Check if all the required pixmap