diff options
| author | Ulrich Sibiller <uli42@gmx.de> | 2021-03-10 10:06:29 +0100 |
|---|---|---|
| committer | Ulrich Sibiller <uli42@gmx.de> | 2021-06-20 20:12:51 +0200 |
| commit | 0631eece96650afb3715a5c5009005914f90a9b4 (patch) | |
| tree | b96e09de93fb670bb04ad0adcb7c929914fdd362 | |
| parent | ba898dfcde038052c9eb9be043e9d48b18652cca (diff) | |
| download | nx-libs-0631eece96650afb3715a5c5009005914f90a9b4.tar.gz nx-libs-0631eece96650afb3715a5c5009005914f90a9b4.tar.bz2 nx-libs-0631eece96650afb3715a5c5009005914f90a9b4.zip | |
Clipboard.c: add FIXMEs
Also improve code to better match the situation described in the FIXME
| -rw-r--r-- | nx-X11/programs/Xserver/hw/nxagent/Clipboard.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c b/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c index dde5506fa..87473b221 100644 --- a/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c +++ b/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c @@ -1670,11 +1670,16 @@ Bool nxagentCollectPropertyEventFromXServer(int resource) * in the selection." * FIXME: this uses serverTransToAgentProperty which is shared between * all the selections. Could be a problem with simultaneous transfers. + * FIXME: NXGetCollectedProperty can return 0 and True. Some other + * functions in this field return False as well. Clean up that + * mess... */ - if (result != 0 && ulReturnBytesLeft == 0) + if (result == True && ulReturnBytesLeft == 0) { #ifdef DEBUG - fprintf (stderr, "%s: Retrieved property data - deleting it for ICCCM conformity.\n", __func__); + fprintf (stderr, "%s: Retrieved property data - deleting property [%ld][%s] " + "for ICCCM conformity.\n", __func__, serverTransToAgentProperty, + NameForRemAtom(serverTransToAgentProperty)); #endif XDeleteProperty(nxagentDisplay, serverWindow, serverTransToAgentProperty); } |