aboutsummaryrefslogtreecommitdiff
path: root/debian/patches/110_nxagent_createpixmap-bounds-check.patch
diff options
context:
space:
mode:
authorMike Gabriel <mike.gabriel@das-netzwerkteam.de>2011-12-31 03:18:07 +0100
committerMike Gabriel <mike.gabriel@das-netzwerkteam.de>2011-12-31 03:18:07 +0100
commit85e87ab6c7612d014ed90aa91fc0f08fa9e89890 (patch)
tree209593a4ce4ba9da96eb27f9a48e1b20e786055a /debian/patches/110_nxagent_createpixmap-bounds-check.patch
parent24261f05e97f088bdbf8047a822df524ca676c66 (diff)
downloadnx-libs-85e87ab6c7612d014ed90aa91fc0f08fa9e89890.tar.gz
nx-libs-85e87ab6c7612d014ed90aa91fc0f08fa9e89890.tar.bz2
nx-libs-85e87ab6c7612d014ed90aa91fc0f08fa9e89890.zip
Add patch headers to all patch files, report most patches upstream. Waiting for feedback and quotable URLs from NoMachine.
Diffstat (limited to 'debian/patches/110_nxagent_createpixmap-bounds-check.patch')
-rw-r--r--debian/patches/110_nxagent_createpixmap-bounds-check.patch18
1 files changed, 18 insertions, 0 deletions
diff --git a/debian/patches/110_nxagent_createpixmap-bounds-check.patch b/debian/patches/110_nxagent_createpixmap-bounds-check.patch
index a5d4c3afa..d65862bdc 100644
--- a/debian/patches/110_nxagent_createpixmap-bounds-check.patch
+++ b/debian/patches/110_nxagent_createpixmap-bounds-check.patch
@@ -1,3 +1,21 @@
+Description: Avoid large pixmaps
+ It is allowed to try and allocate a pixmap which is larger than
+ 32767 in either dimension. However, all of the framebuffer code
+ is buggy and does not reliably draw to such big pixmaps, basically
+ because the Region data structure operates with signed shorts
+ for the rectangles in it.
+ .
+ Furthermore, several places in the X server computes the
+ size in bytes of the pixmap and tries to store it in an
+ integer. This integer can overflow and cause the allocated size
+ to be much smaller.
+ .
+ So, such big pixmaps are rejected here with a BadAlloc
+ .
+ Originally contributed by FreeNX Team
+Forwarded: pending...
+Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
+Last-Update: 2011-12-31
--- a/nx-X11/programs/Xserver/hw/nxagent/NXdispatch.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/NXdispatch.c
@@ -1973,6 +1973,23 @@