diff options
author | Olivier Fourdan <ofourdan@redhat.com> | 2016-01-21 11:54:19 +0100 |
---|---|---|
committer | Ulrich Sibiller <uli42@gmx.de> | 2016-10-19 21:40:30 +0200 |
commit | a3759f323a476deee8347ac3b88df1b426d7cc1a (patch) | |
tree | c0e372f9f99aef045e2c0e33447e2dcb18dfff58 /nx-X11/lib/X11/GetHints.c | |
parent | 50192b720a1f0ae6c4dd97d44e3c54d43ab7358b (diff) | |
download | nx-libs-a3759f323a476deee8347ac3b88df1b426d7cc1a.tar.gz nx-libs-a3759f323a476deee8347ac3b88df1b426d7cc1a.tar.bz2 nx-libs-a3759f323a476deee8347ac3b88df1b426d7cc1a.zip |
XKB: fix XkbGetKeyboardByName with Xming server
XkbGetKeyboardByName relies on flags to read the data from the server.
If the X server sends us the wrong flags or if a subreply is smaller
than it should be, XkbGetKeyboardByName will not read all the available
data and leave data in the buffer, which will cause the next _XReply()
to fail with:
[xcb] Extra reply data still left in queue
[xcb] This is most likely caused by a broken X extension library
[xcb] Aborting, sorry about that.
xcb_io.c:576: _XReply: Assertion `!xcb_xlib_extra_reply_data_left' failed.
Aborted
Check if there is some extra data left at the end of
XkbGetKeyboardByName() and discard that data if any is found.
Many thanks to Peter Hutterer <peter.hutterer@who-t.net> for finding the
root cause of the issue and Adam Jackson <ajax@redhat.com> for helping
with the analysis!
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>
Diffstat (limited to 'nx-X11/lib/X11/GetHints.c')
0 files changed, 0 insertions, 0 deletions