aboutsummaryrefslogtreecommitdiff
path: root/nx-X11/lib/X11/Withdraw.c
diff options
context:
space:
mode:
authorAlan Coopersmith <alan.coopersmith@oracle.com>2014-07-11 10:34:08 -0700
committerUlrich Sibiller <uli42@gmx.de>2016-10-19 21:40:29 +0200
commit0f1fa85fe03a268c2b3b04978f3a533df1bf3414 (patch)
tree63928b8d2d5fa5d13e3c610d19f394828096e041 /nx-X11/lib/X11/Withdraw.c
parentf20f91ee89607537dfc6bfaec05d18e9830bea13 (diff)
downloadnx-libs-0f1fa85fe03a268c2b3b04978f3a533df1bf3414.tar.gz
nx-libs-0f1fa85fe03a268c2b3b04978f3a533df1bf3414.tar.bz2
nx-libs-0f1fa85fe03a268c2b3b04978f3a533df1bf3414.zip
Use C99 named initializers to fill in events passed to XSendEvent
Forces compiler to zero-fill unset fields in the struct (fixing bug 81236) and allows optimizer to order field initialization to best fit cache layout or other considerations. Before & after output of gcc -S on AMD64 shows insertion of "rep stosq" instructions to rapidly zero-fill structs. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Matthieu Herrb <matthieu@herrb.eu> Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>
Diffstat (limited to 'nx-X11/lib/X11/Withdraw.c')
-rw-r--r--nx-X11/lib/X11/Withdraw.c22
1 files changed, 12 insertions, 10 deletions
diff --git a/nx-X11/lib/X11/Withdraw.c b/nx-X11/lib/X11/Withdraw.c
index bca1f8d9b..9c2280234 100644
--- a/nx-X11/lib/X11/Withdraw.c
+++ b/nx-X11/lib/X11/Withdraw.c
@@ -67,16 +67,18 @@ Status XWithdrawWindow (
Window w,
int screen)
{
- XUnmapEvent ev;
- Window root = RootWindow (dpy, screen);
-
XUnmapWindow (dpy, w);
- ev.type = UnmapNotify;
- ev.event = root;
- ev.window = w;
- ev.from_configure = False;
- return (XSendEvent (dpy, root, False,
- SubstructureRedirectMask|SubstructureNotifyMask,
- (XEvent *)&ev));
+ {
+ Window root = RootWindow (dpy, screen);
+ XUnmapEvent ev = {
+ .type = UnmapNotify,
+ .event = root,
+ .window = w,
+ .from_configure = False
+ };
+ return (XSendEvent (dpy, root, False,
+ SubstructureRedirectMask|SubstructureNotifyMask,
+ (XEvent *)&ev));
+ }
}