aboutsummaryrefslogtreecommitdiff
path: root/nx-X11/programs/Xserver/hw
diff options
context:
space:
mode:
authorUlrich Sibiller <uli42@gmx.de>2020-10-02 22:48:51 +0200
committerUlrich Sibiller <uli42@gmx.de>2021-06-08 21:16:37 +0200
commit972a92cab16a99d86a5b66b03967229799f1216d (patch)
tree1a7e5c14e5c6fa1e25d6ca852531c93792833732 /nx-X11/programs/Xserver/hw
parent59a0620f68e9377001f23f5f491a8b02b520d685 (diff)
downloadnx-libs-972a92cab16a99d86a5b66b03967229799f1216d.tar.gz
nx-libs-972a92cab16a99d86a5b66b03967229799f1216d.tar.bz2
nx-libs-972a92cab16a99d86a5b66b03967229799f1216d.zip
Clipboard.c: add/fix comments
Diffstat (limited to 'nx-X11/programs/Xserver/hw')
-rw-r--r--nx-X11/programs/Xserver/hw/nxagent/Clipboard.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c b/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c
index 22fc96f4f..bb8ca5843 100644
--- a/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c
@@ -827,9 +827,10 @@ void nxagentHandleSelectionRequestFromXServer(XEvent *X)
*
* The list is aligned with the one in nxagentConvertSelection.
*
- * FIXME: the perfect solution should not just answer with
- * XA_STRING but ask the real owner what format it supports. The
- * result should then be sent to the original requestor.
+ * FIXME: the perfect solution should not just answer with a
+ * hardcoded list but ask the real owner what format it
+ * supports. The result should then be sent to the original
+ * requestor.
*/
long targets[] = {XA_STRING, serverUTF8_STRING, serverTEXT, serverCOMPOUND_TEXT, serverTARGETS, serverTIMESTAMP};
@@ -877,6 +878,7 @@ void nxagentHandleSelectionRequestFromXServer(XEvent *X)
*
* FIXME: ensure we are reporting an _external_ timestamp
* FIXME: for a 32 bit property list we need to pass a "long" array, not "char"!
+ * FIXME: selection has already been checked above, so we do not need to check again here
*/
int i = nxagentFindLastSelectionOwnerIndex(X->xselectionrequest.selection);
@@ -1784,6 +1786,7 @@ int nxagentConvertSelection(ClientPtr client, WindowPtr pWin, Atom selection,
__func__, nxagentClientInfoString(client));
#endif
+ /* notify the sender of the new request of failure */
sendSelectionNotifyEventToClient(client, time, requestor, selection, target, None);
return 1;