aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* XKB: Fix garbage initializationUlrich Sibiller2018-11-091-1/+1
| | | | | | | | | | | | | | | | | | commit 8311cd5f89ca6781842bb24671b8122cdf8be148 Author: Jeremy Huddleston <jeremyhu@freedesktop.org> Date: Tue Mar 23 10:37:36 2010 -0700 XKB: Fix garbage initialization XkbEnableDisableControls set extra garbage bits on the xkbControlsNotify changedControls mask because it was uninitialized on the stack. Found by clang Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Backported-to-nx-by: Ulrich Sibiller <uli42@gmx.de>
* ProcXkbGetKbdByName: fix use of uninitialised bytes valgrind error.Ulrich Sibiller2018-11-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have fixed that (independendly) before, but missed one line. Backported-to-nx-by: Ulrich Sibiller <uli42@gmx.de> commit 85f9017393c9bb19553e9afcf554673a44a09993 Author: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Date: Tue Feb 8 11:10:10 2011 +0200 ProcXkbGetXkbByName: fix use of uninitialised bytes valgrind error. ==9999== Syscall param writev(vector[...]) points to uninitialised byte(s) ==9999== at 0x4AB5154: writev (writev.c:51) ==9999== by 0x7C7C3: _XSERVTransWritev (Xtrans.c:912) ==9999== by 0x61C8B: FlushClient (io.c:924) ==9999== by 0x62423: WriteToClient (io.c:846) ==9999== by 0xCE39B: XkbSendMap (xkb.c:1408) ==9999== by 0xD247B: ProcXkbGetKbdByName (xkb.c:5814) ==9999== by 0x4AB53: Dispatch (dispatch.c:432) ==9999== by 0x205BF: main (main.c:291) ==9999== Address 0x557eb68 is 40 bytes inside a block of size 4,096 alloc'd ==9999== at 0x48334A4: calloc (vg_replace_malloc.c:467) ==9999== by 0x62567: WriteToClient (io.c:1065) ==9999== by 0x452EB: ProcEstablishConnection (dispatch.c:3685) ==9999== by 0x4AB53: Dispatch (dispatch.c:432) ==9999== by 0x205BF: main (main.c:291) ==9999== Uninitialised value was created by a stack allocation ==9999== at 0xD1910: ProcXkbGetKbdByName (xkb.c:5559) Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Oliver McFadden <oliver.mcfadden@nokia.com> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
* XkbSendNames: fix use of uninitialised bytes valgrind error.Ulrich Sibiller2018-11-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backported-to-nx-by: Ulrich Sibiller <uli42@gmx.de> commit 8a34d7a8532c7ca013e67307f3baf200167abb92 Author: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Date: Tue Feb 8 11:10:11 2011 +0200 XkbSendNames: fix use of uninitialised bytes valgrind error. ==537== Syscall param writev(vector[...]) points to uninitialised byte(s) ==537== at 0x4AB7154: writev (writev.c:51) ==537== by 0x8935B: _XSERVTransWritev (Xtrans.c:912) ==537== by 0x6C55F: FlushClient (io.c:924) ==537== by 0x6CCF3: WriteToClient (io.c:846) ==537== by 0xD51D3: XkbSendNames (xkb.c:3765) ==537== by 0xD8183: ProcXkbGetKbdByName (xkb.c:5825) ==537== by 0x27B7B: Dispatch (dispatch.c:432) ==537== by 0x205B7: main (main.c:291) ==537== Address 0x55899f2 is 154 bytes inside a block of size 1,896 alloc'd ==537== at 0x4834C48: malloc (vg_replace_malloc.c:236) ==537== by 0xD47AF: XkbSendNames (xkb.c:3642) ==537== by 0xD8183: ProcXkbGetKbdByName (xkb.c:5825) ==537== by 0x27B7B: Dispatch (dispatch.c:432) ==537== by 0x205B7: main (main.c:291) ==537== Uninitialised value was created by a heap allocation ==537== at 0x4834C48: malloc (vg_replace_malloc.c:236) ==537== by 0xD47AF: XkbSendNames (xkb.c:3642) ==537== by 0xD8183: ProcXkbGetKbdByName (xkb.c:5825) ==537== by 0x27B7B: Dispatch (dispatch.c:432) ==537== by 0x205B7: main (main.c:291) Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Oliver McFadden <oliver.mcfadden@nokia.com> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
* Keyboard.c: simplify even more: free stuff at one placeUlrich Sibiller2018-11-091-16/+8
|
* Keyboard.c: fix keyboard=query logicUlrich Sibiller2018-11-091-1/+1
| | | | an empty nxagentKeyboard variable is no reason to fall back to no-XKB mode
* Keyboard.c: greatly simplify the code in nxagentKeyboardProcUlrich Sibiller2018-11-091-31/+13
| | | | most of the code was existing twice
* Keyboard.c: guard XkbFreeKeyboard callsUlrich Sibiller2018-11-091-5/+10
| | | | manpage does not tell us if NULL is valid
* Keyboard.c: simplify over-specific ifUlrich Sibiller2018-11-091-2/+1
|
* Keyboard.c: simplify RLMVO string handlingUlrich Sibiller2018-11-091-37/+9
|
* Keyboard.c: always ask for remote XKBUlrich Sibiller2018-11-091-12/+12
|
* Lift xkb to XORG-1.3.0.0 stateUlrich Sibiller2018-11-092-3/+4
|
* XKB: provide XKB defines via ImakefileUlrich Sibiller2018-11-091-1/+1
|
* Keyboard.c: do not define own RLMVO defaultsUlrich Sibiller2018-11-091-94/+5
| | | | use the ones from xkb
* no more own XkbBaseDirectory handlingUlrich Sibiller2018-11-092-361/+1
| | | | Just use the existing xkb code
* Keyboard.c: remove unused definesUlrich Sibiller2018-11-091-6/+0
| | | | Defines regarding XKB-BASE_DIRECTORY are used only xkb.
* Keyboard.c: remove unnecessary includesUlrich Sibiller2018-11-091-7/+0
|
* Keyboard.c: Remove (now) unused definesUlrich Sibiller2018-11-091-6/+0
|
* Lift xkb to XORG-1.2.0 stateUlrich Sibiller2018-11-0923-377/+2979
|
* Check nxagentXkbInfo.EventBase before useUlrich Sibiller2018-11-091-1/+7
|
* Merge branch 'uli42-pr/Xi-1.2.0' into 3.6.xMike Gabriel2018-11-0138-45/+25
|\ | | | | | | Attributes GH PR #734: https://github.com/ArcticaProject/nx-libs/pull/734
| * Lift Xi to 1.3.0.0 (identical to 1.2.0)Ulrich Sibiller2018-11-0138-45/+25
|/
* Merge branch 'uli42-pr/small_improvements' into 3.6.xMike Gabriel2018-10-271-436/+315
|\ | | | | | | Attributes GH PR #732: https://github.com/ArcticaProject/nx-libs/pull/732
| * Window.c: use C99 designated initializers at some placesUlrich Sibiller2018-10-271-37/+30
| |
| * Window.c: add FIXMEUlrich Sibiller2018-10-271-0/+4
| |
| * Window.c: save some lines by declaring loop variables in the loopUlrich Sibiller2018-10-271-48/+21
| |
| * Window.c: indent ifdefs for better readabilityUlrich Sibiller2018-10-271-46/+43
| |
| * Window.c: silence compiler warningsUlrich Sibiller2018-10-271-2/+8
| |
| * Window.c: some code simplificationsUlrich Sibiller2018-10-271-63/+26
| |
| * Window.c: whitespace cleanupUlrich Sibiller2018-10-271-136/+34
| |
| * Window.c: scope improvementsUlrich Sibiller2018-10-271-40/+27
| |
| * Window.c: reformat/add braces for readabilityUlrich Sibiller2018-10-271-42/+110
| |
| * Window.c: indent FIXMEsUlrich Sibiller2018-10-271-27/+27
| |
| * Window.c: convert old-style function definitions to ANSI C89 styleUlrich Sibiller2018-10-271-16/+6
|/
* Merge branch 'uli42-pr/clipboard_debug' into 3.6.xMike Gabriel2018-10-273-185/+411
|\ | | | | | | Attributes GH PR #731: https://github.com/ArcticaProject/nx-libs/pull/731
| * Clipboard.c: use __func__ everywhereUlrich Sibiller2018-10-271-59/+58
| |
| * Clipboard.c: fix fprintf type warningsUlrich Sibiller2018-10-271-20/+20
| |
| * Clipboard.c: more DEBUG outputUlrich Sibiller2018-10-271-3/+12
| |
| * Clipboard.c: Use constant instead of hardcoded valueUlrich Sibiller2018-10-271-1/+1
| |
| * Clipboard.c: improve nxagentClearSelection() debug codeUlrich Sibiller2018-10-271-5/+1
| |
| * Clipboard.c: new debug function to reduce duplicate codeUlrich Sibiller2018-10-271-13/+53
| |
| * Clipboard.c: more debugging info for nxagentGetClipboardWindow()Ulrich Sibiller2018-10-271-3/+3
| |
| * Clipboard.c: GetWindowProperty() does not return BadMatchUlrich Sibiller2018-10-271-5/+2
| |
| * Clipboard.c: whitespace fixesUlrich Sibiller2018-10-271-3/+0
| |
| * Clipboard.c: add FIXMEUlrich Sibiller2018-10-271-0/+1
| |
| * Clipboard.c: Code optimization (missing else)Ulrich Sibiller2018-10-271-2/+1
| |
| * Clipboard.c: print X errorsUlrich Sibiller2018-10-271-20/+62
| |
| * Clipboard.c: some scope optimizationsUlrich Sibiller2018-10-271-11/+6
| |
| * Clipboard.c: add macro for safe XFree calls with ptr clearanceUlrich Sibiller2018-10-272-37/+18
| |
| * Clipboard.c: introduce helper macros for easier debuggingUlrich Sibiller2018-10-271-48/+59
| |
| * NXproperty.c:add debug outputUlrich Sibiller2018-10-271-1/+24
| |