aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* dix/dispatch.c: fix buggy callback invocationUlrich Sibiller2020-05-071-0/+5
| | | | Looks like a copy'n'paste error.
* Clipboard.c: rename some exported functionsUlrich Sibiller2020-05-073-13/+15
| | | | to make them all fit in the same naming scheme that better describes their purpose.
* Clipboard.c: rename static helpers and macrosUlrich Sibiller2020-05-071-93/+108
| | | | | drop the nxagent prefix to emphasize they are not called from the outside. Also make them static and add prototypes, if missing.
* Clipboard.{c,h}: cleanup prototypesUlrich Sibiller2020-05-075-29/+22
|
* Clipboard.c: deactivate unused codeUlrich Sibiller2020-05-071-0/+5
| | | | | For now deactivate nxagentResetSelectionOwner. Must do some research before removing it completely.
* Clipboard.c: clear windowPtr in ClearSelectionOwnerUlrich Sibiller2020-05-071-4/+1
| | | | | | | | | There were two location where the windowPtr was not cleared after calling ClearSelectionOwner(). One was nxagentInitClipboard where it was set to NULL before and the second one was nxagentClearSelection() where it really should be reset. So we can safely move this to where it really belongs.
* Clipboard.h: reformat commentsUlrich Sibiller2020-05-071-7/+4
|
* Clipboard.h: add missing externsUlrich Sibiller2020-05-071-4/+10
|
* Clipboard.c: print if selection owner is inside nagent in debugging outputUlrich Sibiller2020-05-071-0/+1
|
* Clipboard.c: fix some format specifiersUlrich Sibiller2020-05-071-16/+16
|
* Clipboard.c: fix/improve debugging outputUlrich Sibiller2020-05-071-12/+5
|
* Clipboard.c: rename nxagentLastRequestedSelectionUlrich Sibiller2020-05-071-4/+5
| | | | and correctly print its value in debugging output
* Clipboard.c: fix compilation with DEBUGUlrich Sibiller2020-05-071-0/+2
|
* Clipboard.c: use validateString in debugging outputUlrich Sibiller2020-05-071-8/+8
|
* Clipboard.c: rearrange Atoms in debugging outputUlrich Sibiller2020-05-071-3/+2
| | | | ensure same order for internal and external Atoms
* NX.h: Add missing NX_CHANNEL_SLAVE type to descriptionUlrich Sibiller2020-05-071-0/+3
|
* XlibInt.c: scope improvements/reformatUlrich Sibiller2020-05-071-14/+7
|
* XlibInt.c: simplify NX code insertionUlrich Sibiller2020-05-071-10/+5
|
* XlibInt.c: reformat some commentsUlrich Sibiller2020-05-071-20/+15
|
* XlibInt.c: simplify handling of NX_TRANS_{CHANGE,DEBUG} macrosUlrich Sibiller2020-05-071-37/+48
|
* dixfont.h: add missing externUlrich Sibiller2020-05-071-1/+1
| | | | Fixes ArcticaProject/nx-libs#907 (3/3)
* nxagent: move variable definitions from headers to source filesUlrich Sibiller2020-05-075-5/+7
| | | | Fixes ArcticaProject/nx-libs#907 (2/3)
* nxagent: Fix double variablesUlrich Sibiller2020-05-073-9/+5
| | | | | | nxagentCorrupted* were defined twice! Fixes ArcticaProject/nx-libs#907 (1/3)
* Windows.h, Window.c*: reformat commentsUlrich Sibiller2020-05-072-95/+67
|
* NXproperty.c: fix comment/formattingUlrich Sibiller2020-05-071-2/+1
|
* Window.c: scope improvementsUlrich Sibiller2020-05-071-66/+42
| | | | plus some whitespace improvements
* NXresource.c: scope improvementsUlrich Sibiller2020-05-071-16/+6
|
* NXresource.c: Fix uninitialized variableUlrich Sibiller2020-05-071-1/+1
| | | | | | Static analyzer reported: (error) Uninitialized variable: elements Attributes ArcticaProject/nx-libs#905
* NXresource.c: rework marked nx codeUlrich Sibiller2020-05-071-61/+29
| | | | | Improve visibility by unindenting. Also move the ifdefs _before_ the according comments. Finally merge ifdefs to fewer blocks.
* NXproperty.c: fix implicit declarationUlrich Sibiller2020-05-071-0/+4
| | | | | | | | | | Fix warning with NX_DEBUG_INPUT: NXproperty.c: In function ‘ProcChangeProperty’: NXproperty.c:210:7: warning: implicit declaration of function ‘nxagentGuessDumpInputInfo’; did you mean ‘nxagentGuessClientHint’? [-Wimplicit-function-declaration] nxagentGuessDumpInputInfo(client, stuff->property, (char *) &stuff[1]); ^~~~~~~~~~~~~~~~~~~~~~~~~ nxagentGuessClientHint
* Display.c: fix implicit declarationUlrich Sibiller2020-05-071-0/+1
| | | | | | | | Display.c: In function ‘nxagentResetDisplayHandlers’: Display.c:901:5: warning: implicit declaration of function ‘nxagentReleaseAllSplits’; did you mean ‘nxagentWakeupBySplit’? [-Wimplicit-function-declaration] nxagentReleaseAllSplits(); ^~~~~~~~~~~~~~~~~~~~~~~ nxagentWakeupBySplit
* Display.c: fix common realloc mistakeUlrich Sibiller2020-05-071-2/+7
| | | | | As reported by static analyzer: (error) Common realloc mistake: 'nxagentVisuals' nulled but not freed upon failure
* Rootless.c: fix common realloc mistakeUlrich Sibiller2020-05-071-2/+1
| | | | | | | As reported by static analyzer: (error) Common realloc mistake: 'ptr' nulled but not freed upon failure Attributes ArcticaProject/nx-libs#905
* NXdispatch.c, Reconnect.c: fix format specifiersUlrich Sibiller2020-05-072-3/+3
| | | | | | | | | | | | | | | | | | | | | | Fix these warnings with NX_DEBUG_INPUT enabled: NXdispatch.c: In function ‘Dispatch’: NXdispatch.c:350:74: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=] fprintf(stderr, "Session: Session started at '%s' timestamp [%lu].\n", ~~^ %u GetTimeAsString(), GetTimeInMillis()); Reconnect.c: In function ‘nxagentHandleConnectionStates’: Reconnect.c:303:74: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=] fprintf(stderr, "Session: Session suspended at '%s' timestamp [%lu].\n", GetTimeAsString(), GetTimeInMillis()); ~~^ ~~~~~~~~~~~~~~~~~ %u Reconnect.c: In function ‘nxagentReconnectSession’: Reconnect.c:673:66: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=] fprintf(stderr, "Session: Session resumed at '%s' timestamp [%lu].\n", GetTimeAsString(), GetTimeInMillis()); ~~^ ~~~~~~~~~~~~~~~~~ %u
* NXdispatch.c: fix invalid number of character '('Ulrich Sibiller2020-05-071-1/+1
| | | | | | As reported by static analyzer. Attributes ArcticaProject/nx-libs#905
* NXdispatch.c: some cleanupUlrich Sibiller2020-05-071-25/+23
|
* NXdispatch.c: whitespace fixUlrich Sibiller2020-05-071-1/+1
|
* Screen.h: improve NXAGENT_ARTSD prototype definitionUlrich Sibiller2020-05-072-3/+2
|
* (NX)property.c: harmonize function nameUlrich Sibiller2020-05-072-2/+2
| | | | Use the "xorg_" prefix as everywhere else, not "Xorg_".
* NXdixfonts.c: mark NX changesUlrich Sibiller2020-05-071-52/+107
| | | | | Also add original code to make NX changes obvious. Also change some lines to match original code.
* NXdixfonts.c: drop NXAGENT_DEBUGUlrich Sibiller2020-05-072-36/+35
| | | | | | | and use DEBUG like everywhere else. There were already some TEST lines using this scheme. Also indent DEBUG and TEST lines to make the code more readable
* NXdixfonts.c: call dix version of SetDefaultFontPathUlrich Sibiller2020-05-072-73/+6
|
* Keystroke.c: fix typoUlrich Sibiller2020-05-071-1/+1
| | | | make compilation work with -DNX_DEBUG_INPUT
* WaitFor.c Implement the intended NX_WAKEUP functionalityUlrich Sibiller2020-05-073-12/+14
| | | | NX_WAKEUP had been non-effective and its effect had been tied to NX_TRANS_WAKEUP.
* os/Waitfor.c: simplify macro handlingUlrich Sibiller2020-05-071-59/+56
| | | | | | | | | | 1. indent ifdefs 2. add some logic at start that unset NX_TRANS_WAKEUP and NX_TRANS_DEBUG if NX_TRANS_SOCKET is unset. This way we only have to check for one macro and not all three. 3. remove redundant macro checks 4. decouple debug printfs by always running the original code and adding the identical check in #ifdef NX_TRANS_DEBUG
* hw/nxagent/Imakefile: explain more macrosUlrich Sibiller2020-05-071-10/+14
| | | | and remove obsolete NX_SPLASH
* README.md: remove embarassing planned release dates...Ulrich Sibiller2020-05-071-5/+1
|
* Dialog.c: show configured keystrokes in dialogsUlrich Sibiller2020-05-074-33/+144
| | | | | | | | Instead of hardcoding the keystrokes in Dialog.h determine the currently configured keystrokes for the action and insert them into the dialog strings. Fixes ArcticaProject/nx-libs#438
* nxagent: make all traps BooleansUlrich Sibiller2020-05-0714-102/+100
| | | | and use True/False instead of 1/0
* Literals.h: always include in compilationUlrich Sibiller2020-05-074-7/+2
| | | | | | This change ensures Literals.h is always referenced during compilation, effectively hiding it from "unused file" detection we do occasionally to clean up the source code.