aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* nxagent: fix stack smashingUlrich Sibiller2020-10-174-4/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In compext Atom has the size of XlibAtom. Therefore calling functions of Compext.c requires to use/pass XlibAtom. Same for Window/XlibWindow. ==15438==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fffffffcdc0 at pc 0x5555556a81b5 bp 0x7fffffffcd10 sp 0x7fffffffcd08 WRITE of size 8 at 0x7fffffffcdc0 thread T0 #0 0x5555556a81b4 in NXGetCollectedProperty nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124 #1 0x5555557d0488 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1202 #2 0x555555723340 in nxagentHandleCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3923 #3 0x55555571d4db in nxagentHandleProxyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3007 #4 0x55555571bb92 in nxagentHandleClientMessageEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:2595 #5 0x555555717dfc in nxagentDispatchEvents nx-X11/programs/Xserver/hw/nxagent/Events.c:1827 #6 0x555555750813 in nxagentBlockHandler nx-X11/programs/Xserver/hw/nxagent/Handlers.c:437 #7 0x5555556c1b5d in BlockHandler nx-X11/programs/Xserver/dix/dixutils.c:403 #8 0x5555556d47ff in WaitForSomething nx-X11/programs/Xserver/os/WaitFor.c:232 #9 0x555555665b22 in Dispatch nx-X11/programs/Xserver/hw/nxagent/NXdispatch.c:365 #10 0x5555555ed760 in main nx-X11/programs/Xserver/dix/main.c:350 #11 0x7ffff604909a in __libc_start_main ../csu/libc-start.c:308 #12 0x5555555edc09 in _start (nx-X11/programs/Xserver/nxagent+0x99c09) Address 0x7fffffffcdc0 is located in stack of thread T0 at offset 32 in frame #0 0x5555557d0324 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1190 This frame has 5 object(s): [32, 36) 'atomReturnType' <== Memory access at offset 32 partially overflows this variable [96, 100) 'resultFormat' [160, 168) 'ulReturnItems' [224, 232) 'ulReturnBytesLeft' [288, 296) 'pszReturnData' HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124 in NXGetCollectedProperty ...
* Merge branch 'uli42-pr/fix_caps_handling' into 3.6.xMike Gabriel2020-10-171-2/+44
|\ | | | | | | Attributes GH PR #937: https://github.com/ArcticaProject/nx-libs/pull/937
| * Keyboard.c: improve capslock and numlock handlingUlrich Sibiller2020-10-171-0/+42
| | | | | | | | Fixes ArcticaProject/nx-libs#935
| * Keyboard.c: fix indentation of ifdefUlrich Sibiller2020-10-171-2/+2
|/
* Merge branch 'uli42-pr/libNX_X11_defines' into 3.6.xMike Gabriel2020-10-173-0/+56
|\ | | | | | | Attributes GH PR #787: https://github.com/ArcticaProject/nx-libs/pull/787
| * libNX_X11: set XTRANS_SEND_FDS=0Ulrich Sibiller2020-10-171-1/+4
| | | | | | | | | | | | | | | | | | NX does not support passing around FDs for local connections. This will not cause any change in the resulting code as this variable had been unset by default. Fixes ArcticaProject/nx-libs#784
| * libNX_X11: set FAIL_HARDUlrich Sibiller2020-10-171-0/+13
| | | | | | | | | | | | as it has been in the imake builds Fixes ArcticaProject/nx-libs#783
| * nx-xtrans.m4: reintroduce HAS_STICKY_DIR_BITUlrich Sibiller2020-10-171-0/+11
| | | | | | | | Fixes ArcticaProject/nx-libs#781
| * libNX_X11: reintroduce SECURE_RPCUlrich Sibiller2020-10-171-0/+3
| | | | | | | | Fixes ArcticaProject/nx-libs#780
| * libNX_X11: reintroduce HASXDMAUTHUlrich Sibiller2020-10-172-0/+26
|/ | | | Fixes ArcticaProject/nx-libs#779
* Merge branch 'uli42-pr/nxdialog_rpm' into 3.6.xMike Gabriel2020-10-171-4/+19
|\ | | | | | | Attributes GH PR #939: https://github.com/ArcticaProject/nx-libs/pull/939
| * nx-libs.spec: create nxdialog rpmUlrich Sibiller2020-10-171-4/+19
|/
* Merge branch 'mjtrangoni-fix-pvs-ci' into 3.6.xMike Gabriel2020-10-171-5/+13
|\ | | | | | | Attributes GH PR #938: https://github.com/ArcticaProject/nx-libs/pull/938
| * travisci: Fix PVS jobMario Trangoni2020-10-171-5/+13
|/ | | | Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* Merge branch 'uli42-pr/fix_wrap_macros' into 3.6.xMike Gabriel2020-10-171-3/+3
|\ | | | | | | Attributes GH PR #944: https://github.com/ArcticaProject/nx-libs/pull/944
| * randr: fix broken macros / memory corruptionUlrich Sibiller2020-10-161-3/+3
|/ | | | | | | | | | | | | By casting the rrScrPriv to ScreenPtr we are using the offsets from the Screen structure for referencing data in the rrScrPriv structure causing data corruption. As both macros use the same casting this still works until the location where the data resides is overwritten. For 64bit the location was the "rotations" member in rrScrPriv which was not problematic because it is barely used. But on 32bit it was "numCrtcs" which is heavily used. On unwrap this was 0 and lead to a segfault. Fixes ArcticaProject/nx-libs#943
* Update SECURITY.mdMike Gabriel2020-10-011-1/+1
|
* Update SECURITY.mdMike Gabriel2020-10-011-2/+2
|
* Create SECURITY.mdMike Gabriel2020-10-011-0/+19
|
* Merge branch 'mjtrangoni-add-pvs-studio' into 3.6.xMike Gabriel2020-06-292-3/+72
|\ | | | | | | Attributs GH PR #936: https://github.com/ArcticaProject/nx-libs/pull/936
| * travis-ci: add PVS StudioMario Trangoni2020-06-292-3/+72
|/ | | | Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* Merge branch 'uli42-pr/clarify_sleep' into 3.6.xMike Gabriel2020-06-296-18/+32
|\ | | | | | | Attributs GH PR #930: https://github.com/ArcticaProject/nx-libs/pull/930
| * Extend sleep documentationUlrich Sibiller2020-06-291-3/+5
| | | | | | | | Attributes ArcticaProject/nx-libs#241
| * nxagent: clarify sleep time unitsUlrich Sibiller2020-06-295-15/+27
|/ | | | | | | No functional changes, just clarification/explanation of the existing code. Fixes ArcticaProject/nx-libs#926
* Merge branch 'uli42-pr/extend_manpage' into 3.6.xMike Gabriel2020-06-292-14/+47
|\ | | | | | | Attributes GH PR #931: https://github.com/ArcticaProject/nx-libs/pull/931
| * Args.c: adapt message to use same format as similar messagespr/extend_manpageUlrich Sibiller2020-06-291-1/+1
| |
| * manpage: document copysize parameterUlrich Sibiller2020-06-291-0/+4
| | | | | | | | was previously undocumented.
| * manpage and usage output: add -irlimitUlrich Sibiller2020-06-292-0/+4
| | | | | | | | Fixes ArcticaProject/nx-libs#796
| * Extend some manpage entriesUlrich Sibiller2020-06-292-13/+38
|/ | | | | | | Fixes ArcticaProject/nx-libs#241 Fixes ArcticaProject/nx-libs#495 Fixes ArcticaProject/nx-libs#535 Fixes ArcticaProject/nx-libs#565
* Merge branch 'uli42-pr/hint_on_current_builds' into 3.6.xMike Gabriel2020-06-291-0/+27
|\ | | | | | | Attributes GH PR #934: https://github.com/ArcticaProject/nx-libs/pull/934
| * README.md: Add a "Binary Builds" sectionUlrich Sibiller2020-06-181-0/+27
|/
* release 3.5.99.243.5.99.24Mike Gabriel2020-05-319-10/+672
|
* Merge branch 'uli42-pr/clipboard_dump' into 3.6.xMike Gabriel2020-05-3111-177/+204
|\ | | | | | | Attributes GH PR #918: https://github.com/ArcticaProject/nx-libs/pull/918
| * NXevents.c, NXdispatch.c: add some DEBUG statementsUlrich Sibiller2020-05-312-2/+15
| |
| * Client.h: make macro NULL pointer safeUlrich Sibiller2020-05-311-2/+2
| |
| * Clipboard.c: small code improvementUlrich Sibiller2020-05-311-8/+7
| |
| * Clipboard.c: add description/warning for nxagentClearClipboardUlrich Sibiller2020-05-311-0/+6
| |
| * Clipboard.c: improve some more debugging messagesUlrich Sibiller2020-05-311-19/+20
| |
| * Clipboard.c: use nxagentClientInfoString for debug outputUlrich Sibiller2020-05-311-58/+38
| |
| * Clipboard.c: add elapsed time for lastClient to stats output if availableUlrich Sibiller2020-05-311-2/+8
| |
| * Clipboard.c: call endTransfer()Ulrich Sibiller2020-05-311-4/+1
| | | | | | | | instead of sendSelectionNotifyEventToClient + setClientSelectionStage
| * Clipboard.c: drop notifyConvertFailureUlrich Sibiller2020-05-311-24/+15
| | | | | | | | | | Moving the client check to sendSelectionNotifyEventToClient enables us to drop notifyConvertFailure.
| * Clipboard.c: drop unused return code of sendSelectionNotifyEventToClientUlrich Sibiller2020-05-311-8/+8
| |
| * Clipboard.c: Fix: always reset selectionStage in endTransferUlrich Sibiller2020-05-311-15/+16
| |
| * Clipboard.c: make setClientSelectionStage a functionUlrich Sibiller2020-05-311-26/+42
| | | | | | | | and reset the lastClient variables when stage is set to None.
| * Clipboard.c: improve Clipboard statsUlrich Sibiller2020-05-311-1/+11
| | | | | | | | resolve lastClientClientPtr to process id and process name
| * nxagent: Add keystroke for dumping the current clipboard stateUlrich Sibiller2020-05-318-26/+31
| |
| * nxagent: Free atom map on terminationUlrich Sibiller2020-05-311-0/+2
|/
* Merge branch 'uli42-pr/fix_region_crash' into 3.6.xMike Gabriel2020-05-301-1/+4
|\ | | | | | | Attributes GH PR #927: https://github.com/ArcticaProject/nx-libs/pull/927
| * mi: define NXAGENT_SERVERUlrich Sibiller2020-05-301-1/+4
|/ | | | | | | | | In commit f48e2da3e86b2d7600de3d5d4ef6f81ba2c17bed I marked NX changes by using #ifdef NXAGENT_SERVER. But I had missed that this define was never set in mi. So let's change that now and make it work like before. Fixes ArcticaProject/nx-libs#926
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 09:06:55 +0000