aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Clipboard.c: remove obsolete (disabled) codeUlrich Sibiller2021-06-201-3/+0
| | | | | | | Either replyPendingRequest a few lines before will set this to None or it will already be None. Also drop the wrong comment line...
* Clipboard.c: add missing target cache invalidation to some (currently ↵Ulrich Sibiller2021-06-201-0/+2
| | | | unused) code
* Events.c: fix unused variableUlrich Sibiller2021-06-201-1/+4
|
* Clipboard.c: rename nxagentFindLastSelectionOwnerIndex()Ulrich Sibiller2021-06-201-5/+5
| | | | Did not refer to LastSelectionOwner at all...
* Clipboard.c: rename intermediate variableUlrich Sibiller2021-06-201-7/+7
| | | | | Using a capital letter here better reflects that this is an event from the real X server.
* Clipboard.c: fix format specifierUlrich Sibiller2021-06-201-1/+1
|
* Clipboard.c: fix typos in commentUlrich Sibiller2021-06-201-1/+1
|
* Clipboard.c: Fix: forward the correct type and formatUlrich Sibiller2021-06-201-4/+3
| | | | now stuff like xclip -o -t LENGTH works (if the owner offers that)
* Clipboard.c: improve output for PRINT_CLIPBOARD_CONTENT_ON_DEBUGUlrich Sibiller2021-06-201-10/+19
|
* Clipboard.c: extend commentUlrich Sibiller2021-06-201-1/+4
|
* Clipboard.c: add helper variableUlrich Sibiller2021-06-201-18/+20
|
* Clipboard.c: remove superfluous bracketsUlrich Sibiller2021-06-201-84/+82
|
* Clipboard.c: remove old codeUlrich Sibiller2021-06-201-31/+0
| | | | | | This block has been unused for a long time now. The comment describing how to reach that path does not make sense anymore because primary and clipboard are not sharing variables anymore. So drop it.
* Clipboard.c: harmonize naming regarding internal/localUlrich Sibiller2021-06-202-162/+162
| | | | | | Use "local" everywhere instead of a mixture of "local" and "internal". Also replace abbreviations "rem" and "int" by "remote" and "local" because they are confusing readers.
* Clipboard.c: use NXAGENT_ONSTART macro on one more locationUlrich Sibiller2021-06-201-0/+2
|
* Clipboard.c: improve some comments as requested by reviewerUlrich Sibiller2021-06-201-96/+104
|
* NXEvents.c: improve debuggingUlrich Sibiller2021-06-201-0/+3
|
* Clipboard.c: add FIXMEsUlrich Sibiller2021-06-201-2/+7
| | | | Also improve code to better match the situation described in the FIXME
* Clipboard.c: improve debug output in special caseUlrich Sibiller2021-06-201-1/+4
| | | | | | This avoids an error message in a special case: nxagentRemoteToLocalAtom: WARNING failed to get name from remote atom.
* Clipboard.c: improve commentsUlrich Sibiller2021-06-201-1/+8
|
* Clipboard.c: always flush after XConvertSelection() callUlrich Sibiller2021-06-201-0/+5
| | | | This ensures the convert will be sent out immediately.
* Clipboard.c: sanity check for invalid resourceUlrich Sibiller2021-06-201-0/+8
|
* Clipboard.c: print more debug details for replyUlrich Sibiller2021-06-201-4/+4
|
* Clipboard.c: print clipboard content only on explicit requestUlrich Sibiller2021-06-201-10/+36
| | | | | This helps making people aware that their debug logs might contain sensible information.
* Clipboard.c: fix wrong debug messageUlrich Sibiller2021-06-201-2/+2
| | | | printing the wrong client makes the debug output very confusing ;-)
* Clipboard.c: check target cache for valid targetsUlrich Sibiller2021-06-201-0/+98
| | | | | | | Instead of passing the target to the remote side and then receiving an "invalid target" reply we can do that check directly (if the target cache is filled). This way we can save some more roundtrips due to the target cache.
* Clipboard.c: fix some comments, add FIXMEUlrich Sibiller2021-06-201-1/+11
|
* Clipboard.c: move comment to correct locationUlrich Sibiller2021-06-201-6/+6
|
* Clipboard.c: delete property before/after certain operationsUlrich Sibiller2021-06-201-0/+36
| | | | | | for ICCCM conformity Fixes ArcticaProject/nx-libs#969
* Clipboard.c: improve debugging output once moreUlrich Sibiller2021-06-201-2/+14
|
* Clipboard.c: do not handle unknown selections in Callback handlerUlrich Sibiller2021-06-201-4/+15
|
* Clipboard.c: limit selection nxagentFindCurrentSelectionIndex can returnUlrich Sibiller2021-06-201-1/+15
| | | | | | | | | | | | | | | | | Normally you'd expect the loop going up to NumCurrentSelections. But the dix code will increase that number (but not nxagentMaxSelections) when drag and drop comes into play. In that case this helper will report a match for other selections than the ones the clipboard code knows about. The subsequent code will then use a higher index which will lead to out of range data reads (and writes!). Therefore we take nxagentMaxSelections here. The startup code ensures that both arrays will refer to the same selection for the first nxagentMaxSelections selection atoms. This way the clipboard code will not kick in for drag and drop resources. Fixes ArcticaProject/nx-libs#986
* Clipboard.c: rework nxagentFind*SelectionIndex() helpersUlrich Sibiller2021-06-203-14/+16
| | | | Let them return -1 which makes it easier to check for successful execution.
* Clipboard.c: make index the first argument everywhereUlrich Sibiller2021-06-201-34/+34
|
* Clipboard.c: move property transfer to separate functionUlrich Sibiller2021-06-201-112/+118
|
* Clipboard.c: extend target caching for the other directionUlrich Sibiller2021-06-201-17/+76
| | | | | | | | | | This may seem unneccessary at first sight because we are only talking to our own clients which generally is quick. But if you are using nested nx sessions or clients from remote machines (e.g. via ssh X forwarding) this still can save some lenghty communication. Plus: it helps in debugging because there are fewer messages being sent around.
* Clipboard.c: add another FIXMEUlrich Sibiller2021-06-201-1/+5
|
* Clipboard.c: cancel pending requests in certain situationsUlrich Sibiller2021-06-201-6/+9
|
* Clipboard.c: introduce replyPendingRequestSelectionToXServer helperUlrich Sibiller2021-06-201-31/+39
|
* Clipboard.c: move some (currently commented) code to inner scopeUlrich Sibiller2021-06-201-3/+3
|
* Events.c: use already available variable instead of repeating conversionUlrich Sibiller2021-06-201-1/+1
|
* Clipboard.c: reset lastServer[].requestor on reconnectUlrich Sibiller2021-06-201-4/+10
|
* Clipboard.c: improve some commentsUlrich Sibiller2021-06-201-9/+5
|
* Clipboard.c: implement target cachingUlrich Sibiller2021-06-201-0/+118
| | | | | | | | | | | | | | | | | | | | | | Some applications (e.g. Chrome, Firefox) send multiple TARGETS requests when they want to paste a selection (reason currently unknown). If such an application runs in an NX session and the current clipboard owner is on the real X server this triggers many (superflous) roundtrips. By caching the first answer to those requests and answering subsequent requests from the cache we can eliminate all this communication. The implemention resulted from attempting to fix ArcticaProject/nx-libs/issues/#969 (solution 1a) but it turned out that the speedup this brings does not help in reducing the number of requests by firefox. It must be a bug in the firefox code. Nevertheless I kept the code as it should speed up the whole pasting process considerably while reducing communication over the wire. This also eliminates a memory leak in the target forwarding code which was unnoticed before.
* Clipboard.c: fix indentationUlrich Sibiller2021-06-201-4/+4
|
* Clipboard.c: correctly pass back failure to real X serverUlrich Sibiller2021-06-201-22/+46
|
* Clipboard.c: fix: return after denying requestUlrich Sibiller2021-06-201-0/+1
|
* Clipboard.c: remove obsolete FIXME commentUlrich Sibiller2021-06-201-5/+0
|
* Clipboard.c: once again improved DEBUG outputUlrich Sibiller2021-06-201-13/+34
| | | | | | | | Also reduce number of certain DEBUG lines: These PropertyEvents tend to appear quite often and most of the times they have nothing to do with the clipboard. So instead of printing them everytime we turn that around and print something only if it is a clipboard related event..
* Clipboard.c: fix: remove wrong optimizationUlrich Sibiller2021-06-201-14/+4
| | | | | | | | | | In the "none" case we must ensure the clipboard data is reset. This "optimization" skipped the reset part which made the code think it is waiting for an answer. Which (of course) never arrived. So any further request was rejected... Also reduce debugging output for the "none" case because resetClientSelectionStage will print it anyway.