aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* NXglyph.c: check for malloc errorUlrich Sibiller2021-01-151-0/+7
| | | | | "V575 The potential null pointer is passed into 'memcpy' function. Inspect the first argument."
* Keyboard.c: fix possible NULL pointer dereferenceUlrich Sibiller2021-01-151-0/+5
| | | | | found by PVS Studio: "V522 There might be dereferencing of a potential null pointer 'keymap'."
* Drawable.c: Prevent PVS Studio warningUlrich Sibiller2021-01-151-1/+3
| | | | | "V560 A part of conditional expression is always true: oldStatus == NotSynchronized."
* Display.c: prevent PVS Studio realloc warningUlrich Sibiller2021-01-151-5/+11
| | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'nxagentDefaultColormaps' is lost. Consider assigning realloc() to a temporary pointer."
* Atoms.c: add explanation for PVS Studio warningUlrich Sibiller2021-01-151-0/+3
| | | | | "V575 The potential null pointer is passed into 'strlen' function. Inspect the first argument. Check lines: 420, 403."
* NXpicture.c: remove unneccessary checkUlrich Sibiller2021-01-151-15/+12
| | | | | | | Code can only be reached if pPicture is non-NULL. Besides, pPicture will be accessed later anyway, regardless of this check. Finding of PVS Studio: "V547 Expression 'pPicture != NULL' is always true."
* Keyboard.c: simplify codeUlrich Sibiller2021-01-151-5/+3
| | | | Based on PVS Studio finding: "V547 Expression 'data' is always true."
* Colormap.c: remove unneccessary checkUlrich Sibiller2021-01-151-1/+1
| | | | | | | | success would always be true at the beginning of the loop as it is part of the loop condition. Finding from PVS Studio: "V560 A part of conditional expression is always true: success."
* Colormap.c: fix parenthesesUlrich Sibiller2021-01-151-1/+1
| | | | | | PVS Studio: "V592 The expression was enclosed by parentheses twice: '((* pRed * (limg + 1)))'. One pair of parentheses is unnecessary or misprint is present."
* Atoms.c: silence PVS Studio warningUlrich Sibiller2021-01-151-2/+6
| | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'privAtomMap' is lost. Consider assigning realloc() to a temporary pointer."
* Atoms.c: cosmetics in nxagentWriteAtom()Ulrich Sibiller2021-01-151-1/+2
|
* Atoms.c: fix strlen(NULL)Ulrich Sibiller2021-01-151-1/+1
| | | | | FIX PVS Studio finding "V575 The potential null pointer is passed into 'strlen' function. Inspect the first argument"
* Merge branch 'uli42-pr/fullscreen_select' into 3.6.xMike Gabriel2021-01-154-9/+33
|\ | | | | | | Attributes GH PR #978: https://github.com/ArcticaProject/nx-libs/pull/978
| * nxagent: make full screen mode selectable at startupUlrich Sibiller2021-01-154-9/+33
|/ | | | | | | | fullscreen= now accepts the new value "2" for a fullscreen covering only one screen. -geometry and geometry= now know additional keywords "allscreens" and "onescreen". Fixes ArcticaProject/nx-libs#923
* Revert "CVE-2020-14360: Check SetMap request length carefully."Mike Gabriel2021-01-151-91/+0
| | | | This reverts commit 4eba4f53ad8c62c27c12835e58184d66121ff636.
* Merge branch 'uli42-pr/fix_unusable_mouse_in_fullscreen' into 3.6.xMike Gabriel2021-01-151-1/+8
|\ | | | | | | Attributes GH PR #984: https://github.com/ArcticaProject/nx-libs/pull/984
| * nxagent: nxagent(Default)WindowIsVisible() are BooleansUlrich Sibiller2021-01-154-7/+7
| |
| * Keyboard.c: noXkbExtension is a BooleanUlrich Sibiller2021-01-151-2/+2
| |
| * Font.c: Use Booleans where appropriateUlrich Sibiller2021-01-151-16/+16
| |
| * nxagent: make nxagentXkbState.Initialized a BooleanUlrich Sibiller2021-01-154-7/+6
| |
| * Events.h: fix wrong prototypeUlrich Sibiller2021-01-151-1/+1
| |
| * nxagent: make nxagentXFixesInfo.Initialized a BooleanUlrich Sibiller2021-01-153-4/+4
| |
| * Drawable.c: make doRoundRobin a BooleanUlrich Sibiller2021-01-151-4/+4
| |
| * Handlers.c: make synchronize a Boolean variableUlrich Sibiller2021-01-151-3/+3
| |
| * nxagent: make nxagentSkipImage a BooleanUlrich Sibiller2021-01-152-3/+3
| |
| * nxagent: make nxagentForceSynchronization a BooleanUlrich Sibiller2021-01-155-6/+6
| |
| * Drawable.c: make abort flag a BooleanUlrich Sibiller2021-01-152-17/+17
| |
| * Client.c: cleanup Boolean handling for nxagentNeedWakeup*() macrosUlrich Sibiller2021-01-151-6/+6
| |
| * GC.c: make internal variable and function BooleanUlrich Sibiller2021-01-151-16/+16
| |
| * GCOps.c: make internal variable an function BooleansUlrich Sibiller2021-01-151-14/+14
| |
| * nxagent: make nxagentBlocking an BooleanUlrich Sibiller2021-01-155-13/+13
| |
| * Render.c: improve Boolean handling of nxagentCheckPictureRemoteValueUlrich Sibiller2021-01-151-12/+12
| |
| * nxagent: improve Boolean handling for Reconnect functionsUlrich Sibiller2021-01-152-20/+20
| |
| * nxagent: make XDMCP variables BooleansUlrich Sibiller2021-01-153-10/+10
| |
| * GCOps.c: make internal function BooleanUlrich Sibiller2021-01-151-6/+6
| |
| * GCOps.c: handle some internal variables as BooleansUlrich Sibiller2021-01-151-5/+5
| |
| * Drawable.c: make some variables BooleansUlrich Sibiller2021-01-151-5/+5
| |
| * nxagent: handle RegionNil macro as BooleanUlrich Sibiller2021-01-158-33/+33
| | | | | | | | just as the rest of the Xserver is alsow doing
| * Split.c, Image.c: make some internal variables BooleansUlrich Sibiller2021-01-152-29/+29
| |
| * nxagent: rework some Boolean checksUlrich Sibiller2021-01-157-10/+10
| | | | | | | | | | nxagentWindowTopLevel() and nxagentNeedConnectionChange() return Boolean nxagentPixmapIsVirtual() and nxagentIsShmPixmap(), too.
| * nxagent: make nxagentUserDefinedFontPath a BooleanUlrich Sibiller2021-01-153-4/+4
| |
| * nxagent: make nxagentShadowResize a BooleanUlrich Sibiller2021-01-154-5/+5
| |
| * nxagent: make nxagentDoFullgeneration a BooleanUlrich Sibiller2021-01-153-3/+3
| |
| * nxagent: some more Boolean improvementsUlrich Sibiller2021-01-151-2/+2
| |
| * nxagent: treat nxagentLastWindowDestroyed as BooleanUlrich Sibiller2021-01-152-2/+2
| |
| * nxagent: treat all Traps as Booleans everywhereUlrich Sibiller2021-01-1512-67/+67
| |
| * nxagent: make nxagentVerbose a BooleanUlrich Sibiller2021-01-156-9/+9
| |
| * nxagent: make Desktop, Rootless and Binder options Booleans (again)Ulrich Sibiller2021-01-1511-56/+33
| | | | | | | | | | They have been changed to tri-state variables (1, 0 and UNDEFINED) between nxagent 1.5.0-90 and -93, for no obvious reason.
| * Options.h: mark BooleansUlrich Sibiller2021-01-151-26/+32
| | | | | | | | | | Many variables are used as Booleans. By adding the Bool define to Options.h we can now make that visible.
| * nxagent: make nxagentOption Shadow a BooleanUlrich Sibiller2021-01-159-25/+26
| | | | | | | | and add the missing init code.