aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Clipboard.c: add clientCLIPBOARD variableUlrich Sibiller2020-01-051-3/+7
| | | | | | the MakeAtom call previously used is as good as using a variable but with the variable it is a) easier to read/understand and b) consistent with the other client* variables.
* Clipboard.c: change order of if clause to better match the comment above itUlrich Sibiller2020-01-051-6/+8
|
* Clipboard.c: CLINDEX and GetXErrorString are only used for debuggingUlrich Sibiller2020-01-051-2/+2
|
* Clipboard.c: flush more often to ensure a smooth clipboard experienceUlrich Sibiller2020-01-051-3/+1
|
* Clipboard.c: fix handling of clipboard=none/client/server/both optionUlrich Sibiller2020-01-051-3/+4
|
* Options.h: comment on the four clipboard optionsUlrich Sibiller2020-01-051-0/+18
|
* Clipboard.c: Use Find*Index helpers at more locationsUlrich Sibiller2020-01-051-16/+15
|
* Clipboard.c: cosmetics/typo fix/untabifyUlrich Sibiller2020-01-052-44/+41
|
* Clipboard.c: introduce helper macro IS_INTERNAL_OWNERUlrich Sibiller2020-01-051-9/+11
| | | | Using this macro makes the code more readable
* Clipboard.c: simplify nxagentSetSelectionOwnerUlrich Sibiller2020-01-051-33/+26
| | | | We do not need to loop over all selections. We have a helper for that.
* Clipboard.c: describe nxagentFind*IndexUlrich Sibiller2020-01-051-0/+8
|
* Clipboard.c: reorder nxagentInitClipboardUlrich Sibiller2020-01-051-10/+11
| | | | | It makes sense to measure time and set the initialized flag right at the start.
* Clipboard.c: clear all selections in nxagentInitClipboardUlrich Sibiller2020-01-051-2/+4
| | | | | | The new code effectively does the same the old one did. But if we change the number of selections the new code will still work correctly while the old one would not.
* Clipboard.c: Fix: re-claim selection on reconnectUlrich Sibiller2020-01-051-20/+28
| | | | | | | On reconnect claim the selection ownership if one of nxagent's clients is a selection owner. The code for this was already there but could not work because the lastSelectionOwner array was always dropped at the beginning of nxagentInitClipboard.
* Clipboard.c: reorder atom allocation codeUlrich Sibiller2020-01-051-10/+10
| | | | | Place the allocation directly before the check for success. Use the same order for server and client atoms.
* Clipboard: align reported targetsUlrich Sibiller2020-01-053-13/+26
| | | | | Always report the same list of available targets to internal and external requests.
* Clipboard.c: check pointer before usageUlrich Sibiller2020-01-051-1/+1
| | | | | The code also worked with pWindow being NULL but it did some unnecessary stuff.
* Clipboard.c: drop superflous variableUlrich Sibiller2020-01-051-9/+7
|
* Clipboard.c: split combined checkUlrich Sibiller2020-01-051-16/+34
| | | | | | By splitting it up we can print appropriate debug messages. More important: The code tried to handle the special targets for all other cases where it should only deny the request.
* Clipboard.c: more debugging outputUlrich Sibiller2020-01-051-0/+4
|
* Clipboard.c: add more explaining commentsUlrich Sibiller2020-01-051-7/+24
|
* Clipboard.c: use macros instead of hardcoced values for timeoutsUlrich Sibiller2020-01-051-3/+14
|
* Clipboard.c: fix timeout comparisonUlrich Sibiller2020-01-051-2/+2
| | | | | We had comparisions for >5000 and <5000, but =5000 was not explicitly handled. In that case the code took an unexpected path.
* Clipboard: make nxagentInitClipboard return a BooleanUlrich Sibiller2020-01-053-6/+10
|
* Clipboard.c: avoid nested externUlrich Sibiller2020-01-051-4/+4
|
* Clipboard.c: fix string formatting directivesUlrich Sibiller2020-01-051-2/+2
|
* Clipboard.c: Fix formattingUlrich Sibiller2020-01-051-2/+2
|
* Clipboard.c, NXproperty.c: match prototypesUlrich Sibiller2020-01-052-2/+7
| | | | | | The prototype for nxagentGetClipboardWindow has been changed in 63320437ed4e95246ce62193560098f986ac265c but the changes have not made it into NXproperty.c...
* Clipboard.c: reformat some commentsUlrich Sibiller2020-01-051-5/+3
|
* Clipboard.c: add FIXMEsUlrich Sibiller2020-01-051-0/+3
|
* Clipboard.c: add nxagentMatchSelectionOwner helper functionUlrich Sibiller2020-01-051-2/+7
|
* Clipboard.c: make agentClipboardStatus a BooleanUlrich Sibiller2020-01-051-14/+43
| | | | and add debugging information around its checks.
* Clipboard.c: refactor nxagent*SelectionOwnerUlrich Sibiller2020-01-051-28/+28
| | | | | | | expect an index instead of a pointer All calls referenced lastSelectionOwner so let the function directly use it and only pass the required index.
* Merge branch 'uli42-pr/strings_fixes' into 3.6.xMike Gabriel2020-01-055-125/+97
|\ | | | | | | Attributes GH PR #884: https://github.com/ArcticaProject/nx-libs/pull/884
| * Error.c: simplify some NULL pointer checksUlrich Sibiller2020-01-051-4/+4
| |
| * Error.c: drop now obsolete DEFAULT_STRING_LENGTHUlrich Sibiller2020-01-051-3/+0
| |
| * Error.c: make nxagentRootDir a pointerUlrich Sibiller2020-01-051-37/+22
| | | | | | | | no more hardcoded string length
| * Error.c: make nxagentHomeDir a pointerUlrich Sibiller2020-01-051-26/+17
| | | | | | | | no more hardcoded string length
| * Error.c: make nxagentClientsLogName a pointerUlrich Sibiller2020-01-053-12/+22
| | | | | | | | no more hardcoded string length
| * Error.c: fix format-truncation warningUlrich Sibiller2020-01-052-40/+19
| | | | | | | | | | | | | | | | | | | | Error.c: In function ‘nxagentGetSessionPath’: Error.c:543:62: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 253 [-Wformat-truncation=] snprintf(nxagentSessionDir, DEFAULT_STRING_LENGTH, "%s/C-%s", rootPath, nxagentSessionId); ^~ ~~~~~~~~~~~~~~~~ Error.c:543:5: note: ‘snprintf’ output 4 or more bytes (assuming 259) into a destination of size 256 snprintf(nxagentSessionDir, DEFAULT_STRING_LENGTH, "%s/C-%s", rootPath, nxagentSessionId); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| * Dialog.c: fix format-truncation warningUlrich Sibiller2020-01-051-4/+14
|/ | | | | | | | | | Dialog.c: In function ‘nxagentLaunchDialog’: Dialog.c:320:53: warning: ‘%s’ directive output may be truncated writing up to 1023 bytes into a region of size 256 [-Wformat-truncation=] snprintf(dialogDisplay, sizeof(dialogDisplay), "%s", nxagentDisplayName); ^~ ~~~~~~~~~~~~~~~~~~ Dialog.c:320:5: note: ‘snprintf’ output between 1 and 1024 bytes into a destination of size 256 snprintf(dialogDisplay, sizeof(dialogDisplay), "%s", nxagentDisplayName); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* Merge branch 'uli42-pr/custom_version_string' into 3.6.xMike Gabriel2020-01-056-8/+46
|\ | | | | | | Attributes GH PR #607: https://github.com/ArcticaProject/nx-libs/pull/607
| * Add support for custom version stringUlrich Sibiller2020-01-056-8/+46
|/ | | | | | | | | | | Make nxproxy and nxagent print an arbitrary version number by running make NX_VERSION_CUSTOM="myvers". nxagent and nxproxy will then show this in addition to the original version number: NXPROXY - Version myvers (3.5.99.22) NXAGENT - Version myvers (3.5.99.22) Fixes ArcticaProject/nx-libs#606
* Merge branch 'uli42-pr/xlib_types' into 3.6.xMike Gabriel2020-01-0511-70/+74
|\ | | | | | | Attributes GH PR #883: https://github.com/ArcticaProject/nx-libs/pull/883
| * nxagent: Use XlibAtom data type where appropriateUlrich Sibiller2020-01-0511-70/+74
|/ | | | | | | | XlibAtom should be used wherever remote atoms are handled. This is important as Xlib data types and server data types of the same name do not always have identical sizes. See also https://lists.freedesktop.org/archives/xorg-devel/2015-August/047245.html
* Merge branch 'uli42-pr/code_cleanup' into 3.6.xMike Gabriel2020-01-0527-2882/+1797
|\ | | | | | | Attributes GH PR #869: https://github.com/ArcticaProject/nx-libs/pull/869
| * Pixels.c: reformat commentsUlrich Sibiller2020-01-051-7/+4
| |
| * Pixels.c: scope improvementsUlrich Sibiller2020-01-051-6/+4
| |
| * Options.h: reformatUlrich Sibiller2020-01-051-137/+57
| |
| * Options.c: reformat commentsUlrich Sibiller2020-01-051-12/+9
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 00:32:08 +0000