aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'uli42-pr/fix_fullscreen' into 3.6.xMike Gabriel2021-01-182-7/+1
|\ | | | | | | Attributes GH PR #990: https://github.com/ArcticaProject/nx-libs/pull/990
| * Args.c: improve usage string for -geometryUlrich Sibiller2021-01-161-1/+1
| |
| * Screen.c: remove superflous code that produces a crashUlrich Sibiller2021-01-161-6/+0
|/ | | | Fixes ArcticaProject/nx-libs#987
* Merge branch 'uli42-pr/musl_fixes' into 3.6.xMike Gabriel2021-01-163-0/+14
|\ | | | | | | Attributes GH PR #982: https://github.com/ArcticaProject/nx-libs/pull/982
| * Xext: include limits.hUlrich Sibiller2021-01-161-0/+1
| | | | | | | | | | | | Is required for compilations with musl. See ArcticaProjects/nx-libs#975 and ArcticaProjects/nx-libs#976
| * Mesa: make compilation with work with muslUlrich Sibiller2021-01-162-0/+13
|/ | | | Fixes ArcticaProject/nx-lib#975
* Merge branch 'uli42-pr/pvs_findings' into 3.6.xMike Gabriel2021-01-1613-58/+137
|\ | | | | | | Attributes GH PR #981: https://github.com/ArcticaProject/nx-libs/pull/981
| * Display.c: fix and reformat broken commentUlrich Sibiller2021-01-161-12/+11
| |
| * Window.c: suppress warningUlrich Sibiller2021-01-161-1/+1
| | | | | | | | | | | | | | | | This used to be printed only in TEST mode. Some while ago I had changed that to WARNING (because it is a warning...). However, this happens e.g. when running the xscreensaver vfeedback module and it does not look like it is a problem at all. So let's suppress this warning again and leave it to the TEST mode as it used to be.
| * fix formatting and spelling in various filesUlrich Sibiller2021-01-1612-18/+17
| |
| * nxagent: Drop unused nxagentRootTileWindowUlrich Sibiller2021-01-162-4/+0
| |
| * Handlers.c: add FIXMEUlrich Sibiller2021-01-161-0/+3
| |
| * Screen.c: clarify that characters are comparedUlrich Sibiller2021-01-161-2/+2
| |
| * Client.h: conditionally add unused fieldUlrich Sibiller2021-01-161-2/+5
| |
| * Handlers.c: use the same boolean values as in NXdispatch.cUlrich Sibiller2021-01-161-2/+2
| | | | | | | | although there is no functional difference...
| * manpage: document defaults for options -defer and -tileUlrich Sibiller2021-01-161-1/+11
| |
| * NXDispatch.c: remove double nxagentFreeAtomMap()Ulrich Sibiller2021-01-161-1/+0
| |
| * Window.c: check for malloc failureUlrich Sibiller2021-01-151-13/+22
| | | | | | | | PVS finding: "V522 There might be dereferencing of a potential null pointer 'props'"
| * Window.c: check for malloc failureUlrich Sibiller2021-01-151-0/+8
| | | | | | | | PVS finding: "V522 There might be dereferencing of a potential null pointer 'nxagentConfiguredWindowList'."
| * Screen.c: check for malloc failuresUlrich Sibiller2021-01-151-0/+39
| | | | | | | | PVS finding: "V522 There might be dereferencing of a potential null pointer"
| * Splash.c: remove unneccessary checkUlrich Sibiller2021-01-151-9/+4
| | | | | | | | PVs finding: "V547 Expression '!nxagentWMPassed' is always true."
| * Rootless.c: prevent PVS errorUlrich Sibiller2021-01-151-1/+2
| | | | | | | | "V547 Expression 'wmHints.input == 1' is always true."
| * Render.c: Init BoxRecUlrich Sibiller2021-01-151-1/+1
| | | | | | | | PVS Studio: "V614 Potentially uninitialized variable 'glyphBox.*' used."
| * Reconnect.c: fix possible realloc() memory lossUlrich Sibiller2021-01-151-2/+6
| | | | | | | | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'nxagentReconnectErrorMessage' is lost. Consider assigning realloc() to a temporary pointer."
| * NXglyph.c: check for malloc errorUlrich Sibiller2021-01-151-0/+7
| | | | | | | | | | "V575 The potential null pointer is passed into 'memcpy' function. Inspect the first argument."
| * Keyboard.c: fix possible NULL pointer dereferenceUlrich Sibiller2021-01-151-0/+5
| | | | | | | | | | found by PVS Studio: "V522 There might be dereferencing of a potential null pointer 'keymap'."
| * Drawable.c: Prevent PVS Studio warningUlrich Sibiller2021-01-151-1/+3
| | | | | | | | | | "V560 A part of conditional expression is always true: oldStatus == NotSynchronized."
| * Display.c: prevent PVS Studio realloc warningUlrich Sibiller2021-01-151-5/+11
| | | | | | | | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'nxagentDefaultColormaps' is lost. Consider assigning realloc() to a temporary pointer."
| * Atoms.c: add explanation for PVS Studio warningUlrich Sibiller2021-01-151-0/+3
| | | | | | | | | | "V575 The potential null pointer is passed into 'strlen' function. Inspect the first argument. Check lines: 420, 403."
| * NXpicture.c: remove unneccessary checkUlrich Sibiller2021-01-151-15/+12
| | | | | | | | | | | | | | Code can only be reached if pPicture is non-NULL. Besides, pPicture will be accessed later anyway, regardless of this check. Finding of PVS Studio: "V547 Expression 'pPicture != NULL' is always true."
| * Keyboard.c: simplify codeUlrich Sibiller2021-01-151-5/+3
| | | | | | | | Based on PVS Studio finding: "V547 Expression 'data' is always true."
| * Colormap.c: remove unneccessary checkUlrich Sibiller2021-01-151-1/+1
| | | | | | | | | | | | | | | | success would always be true at the beginning of the loop as it is part of the loop condition. Finding from PVS Studio: "V560 A part of conditional expression is always true: success."
| * Colormap.c: fix parenthesesUlrich Sibiller2021-01-151-1/+1
| | | | | | | | | | | | PVS Studio: "V592 The expression was enclosed by parentheses twice: '((* pRed * (limg + 1)))'. One pair of parentheses is unnecessary or misprint is present."
| * Atoms.c: silence PVS Studio warningUlrich Sibiller2021-01-151-2/+6
| | | | | | | | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'privAtomMap' is lost. Consider assigning realloc() to a temporary pointer."
| * Atoms.c: cosmetics in nxagentWriteAtom()Ulrich Sibiller2021-01-151-1/+2
| |
| * Atoms.c: fix strlen(NULL)Ulrich Sibiller2021-01-151-1/+1
| | | | | | | | | | FIX PVS Studio finding "V575 The potential null pointer is passed into 'strlen' function. Inspect the first argument"
* | Merge branch 'uli42-pr/various6' into 3.6.xMike Gabriel2021-01-1618-42/+51
|\ \ | |/ |/| | | Attributes GH PR #979: https://github.com/ArcticaProject/nx-libs/pull/979
| * Display.c: fix and reformat broken commentUlrich Sibiller2021-01-151-12/+11
| |
| * Window.c: suppress warningUlrich Sibiller2021-01-151-1/+1
| | | | | | | | | | | | | | | | This used to be printed only in TEST mode. Some while ago I had changed that to WARNING (because it is a warning...). However, this happens e.g. when running the xscreensaver vfeedback module and it does not look like it is a problem at all. So let's suppress this warning again and leave it to the TEST mode as it used to be.
| * fix formatting and spelling in various filesUlrich Sibiller2021-01-1512-18/+17
| |
| * nxagent: Drop unused nxagentRootTileWindowUlrich Sibiller2021-01-152-4/+0
| |
| * Handlers.c: add FIXMEUlrich Sibiller2021-01-151-0/+3
| |
| * Screen.c: clarify that characters are comparedUlrich Sibiller2021-01-151-2/+2
| |
| * Client.h: conditionally add unused fieldUlrich Sibiller2021-01-151-2/+5
| |
| * Handlers.c: use the same boolean values as in NXdispatch.cUlrich Sibiller2021-01-151-2/+2
| | | | | | | | although there is no functional difference...
| * manpage: document defaults for options -defer and -tileUlrich Sibiller2021-01-151-1/+11
| |
| * NXDispatch.c: remove double nxagentFreeAtomMap()Ulrich Sibiller2021-01-151-1/+0
|/
* Merge branch 'uli42-pr/fullscreen_select' into 3.6.xMike Gabriel2021-01-154-9/+33
|\ | | | | | | Attributes GH PR #978: https://github.com/ArcticaProject/nx-libs/pull/978
| * nxagent: make full screen mode selectable at startupUlrich Sibiller2021-01-154-9/+33
|/ | | | | | | | fullscreen= now accepts the new value "2" for a fullscreen covering only one screen. -geometry and geometry= now know additional keywords "allscreens" and "onescreen". Fixes ArcticaProject/nx-libs#923
* Revert "CVE-2020-14360: Check SetMap request length carefully."Mike Gabriel2021-01-151-91/+0
| | | | This reverts commit 4eba4f53ad8c62c27c12835e58184d66121ff636.