Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | nxagent: make nxagentBlocking an Boolean | Ulrich Sibiller | 2021-01-15 | 5 | -13/+13 |
| | |||||
* | Render.c: improve Boolean handling of nxagentCheckPictureRemoteValue | Ulrich Sibiller | 2021-01-15 | 1 | -12/+12 |
| | |||||
* | nxagent: improve Boolean handling for Reconnect functions | Ulrich Sibiller | 2021-01-15 | 2 | -20/+20 |
| | |||||
* | nxagent: make XDMCP variables Booleans | Ulrich Sibiller | 2021-01-15 | 3 | -10/+10 |
| | |||||
* | GCOps.c: make internal function Boolean | Ulrich Sibiller | 2021-01-15 | 1 | -6/+6 |
| | |||||
* | GCOps.c: handle some internal variables as Booleans | Ulrich Sibiller | 2021-01-15 | 1 | -5/+5 |
| | |||||
* | Drawable.c: make some variables Booleans | Ulrich Sibiller | 2021-01-15 | 1 | -5/+5 |
| | |||||
* | nxagent: handle RegionNil macro as Boolean | Ulrich Sibiller | 2021-01-15 | 8 | -33/+33 |
| | | | | just as the rest of the Xserver is alsow doing | ||||
* | Split.c, Image.c: make some internal variables Booleans | Ulrich Sibiller | 2021-01-15 | 2 | -29/+29 |
| | |||||
* | nxagent: rework some Boolean checks | Ulrich Sibiller | 2021-01-15 | 7 | -10/+10 |
| | | | | | nxagentWindowTopLevel() and nxagentNeedConnectionChange() return Boolean nxagentPixmapIsVirtual() and nxagentIsShmPixmap(), too. | ||||
* | nxagent: make nxagentUserDefinedFontPath a Boolean | Ulrich Sibiller | 2021-01-15 | 3 | -4/+4 |
| | |||||
* | nxagent: make nxagentShadowResize a Boolean | Ulrich Sibiller | 2021-01-15 | 4 | -5/+5 |
| | |||||
* | nxagent: make nxagentDoFullgeneration a Boolean | Ulrich Sibiller | 2021-01-15 | 3 | -3/+3 |
| | |||||
* | nxagent: some more Boolean improvements | Ulrich Sibiller | 2021-01-15 | 1 | -2/+2 |
| | |||||
* | nxagent: treat nxagentLastWindowDestroyed as Boolean | Ulrich Sibiller | 2021-01-15 | 2 | -2/+2 |
| | |||||
* | nxagent: treat all Traps as Booleans everywhere | Ulrich Sibiller | 2021-01-15 | 12 | -67/+67 |
| | |||||
* | nxagent: make nxagentVerbose a Boolean | Ulrich Sibiller | 2021-01-15 | 6 | -9/+9 |
| | |||||
* | nxagent: make Desktop, Rootless and Binder options Booleans (again) | Ulrich Sibiller | 2021-01-15 | 11 | -56/+33 |
| | | | | | They have been changed to tri-state variables (1, 0 and UNDEFINED) between nxagent 1.5.0-90 and -93, for no obvious reason. | ||||
* | Options.h: mark Booleans | Ulrich Sibiller | 2021-01-15 | 1 | -26/+32 |
| | | | | | Many variables are used as Booleans. By adding the Bool define to Options.h we can now make that visible. | ||||
* | nxagent: make nxagentOption Shadow a Boolean | Ulrich Sibiller | 2021-01-15 | 9 | -25/+26 |
| | | | | and add the missing init code. | ||||
* | nxagent: treat several nxagentOptions as real Booleans | Ulrich Sibiller | 2021-01-15 | 16 | -77/+77 |
| | | | | | | | Adaptive, Composite, DeviceControl, DeviceControlUserDefined, IgnoreVisibility, InhibitXkb, Nested, Menu, MagicPixel, Persistent, Reset, ResetzKeyboardAtResume, SharedMemory, SharedPixmaps, Streaming, UseDamage, ViewOnly, Xdmcp, Xinerama | ||||
* | nxagent: treat DesktopResize and nxagentResizeDesktopAtStartup as Booleans | Ulrich Sibiller | 2021-01-15 | 6 | -19/+19 |
| | | | | The already where Booleans but where not using True/False values everywhere | ||||
* | nxagent: make Fullscreen and AllScreens Booleans | Ulrich Sibiller | 2021-01-15 | 6 | -35/+29 |
| | | | | | There's no need/sense in having a tri-state with the third state being UNDEFINED. | ||||
* | Handlers.c: ensure regular yields if suspended | Ulrich Sibiller | 2021-01-15 | 1 | -1/+22 |
| | | | | Fixes ArcticaProject/nx-libs#903 | ||||
* | CVE-2020-14360: Check SetMap request length carefully. | Mike Gabriel | 2021-01-15 | 1 | -0/+91 |
| | | | | | | | | | | | | | | | | | | Backported from X.org: From 446ff2d3177087b8173fa779fa5b77a2a128988b Mon Sep 17 00:00:00 2001 From: Matthieu Herrb <matthieu@herrb.eu> Date: Thu, 12 Nov 2020 19:15:07 +0100 Subject: [PATCH] Check SetMap request length carefully. Avoid out of bounds memory accesses on too short request. ZDI-CAN 11572 / CVE-2020-14360 This vulnerability was discovered by: Jan-Niklas Sohn working with Trend Micro Zero Day Initiative Fixes ArcticaProject/nx-libs#972. | ||||
* | Init.c: Initialize nxagentGrabServerInfo | Ulrich Sibiller | 2021-01-12 | 1 | -1/+8 |
| | | | | Fixes ArcticaProject/nx-libs#983 | ||||
* | Events.c: fix leftover DEBUG and TEST definitions | Ulrich Sibiller | 2020-12-03 | 1 | -4/+1 |
| | | | | causing DEBUG output in regular builds. | ||||
* | NXdixfonts.c: Regression fix for db45683a. Fix typo in libXfont1 function ↵ | Mike Gabriel | 2020-11-04 | 1 | -1/+1 |
| | | | | call (FreeFontName -> FreeFontNames). Fixes FTBFS on Ubuntu 14.04 and 16.04. | ||||
* | release 3.5.99.253.5.99.25 | Mike Gabriel | 2020-11-04 | 9 | -10/+371 |
| | |||||
* | Merge branch 'uli42-pr/various5' into 3.6.x | Mike Gabriel | 2020-11-04 | 13 | -250/+190 |
|\ | | | | | | | Attributes GH PR #963: https://github.com/ArcticaProject/nx-libs/pull/963 | ||||
| * | NXdixfonts.c: Hard-code the enablement of NXAGENT_DANGEROUS_XFONT_LOOP_EXIT. | Mike Gabriel | 2020-11-04 | 1 | -0/+7 |
| | | |||||
| * | NXdixfonts.c: Rename BREAK_XFONT_LOOP to NXAGENT_DANGEROUS_XFONT_LOOP_EXIT ↵ | Mike Gabriel | 2020-11-04 | 1 | -4/+4 |
| | | | | | | | | (better macro name). | ||||
| * | Clipboard.c: fix bug in special optimization for nested settings | Ulrich Sibiller | 2020-11-04 | 1 | -2/+3 |
| | | | | | | | | Fixes ArcticaProject/nx-libs#941 | ||||
| * | compext/Png.c: fix shadowing | Ulrich Sibiller | 2020-11-03 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Png.c: In function ‘PngWriteData’: Png.c:603:38: warning: declaration of ‘png_ptr’ shadows a global declaration [-Wshadow] 603 | static void PngWriteData(png_structp png_ptr, png_bytep data, png_size_t length) | ~~~~~~~~~~~~^~~~~~~ Png.c:77:13: note: shadowed declaration is here 77 | png_structp png_ptr; | ^~~~~~~ Png.c: In function ‘PngFlushData’: Png.c:610:38: warning: declaration of ‘png_ptr’ shadows a global declaration [-Wshadow] 610 | static void PngFlushData(png_structp png_ptr) | ~~~~~~~~~~~~^~~~~~~ Png.c:77:13: note: shadowed declaration is here 77 | png_structp png_ptr; | ^~~~~~~ | ||||
| * | Screen.c: fix indentation in nxagentMaximizeToFullScreen | Ulrich Sibiller | 2020-11-03 | 1 | -37/+37 |
| | | |||||
| * | Atoms.c: fix FIXME comment | Ulrich Sibiller | 2020-11-03 | 1 | -1/+1 |
| | | |||||
| * | Atoms.c: improve debug output | Ulrich Sibiller | 2020-11-03 | 1 | -1/+1 |
| | | |||||
| * | Events.c: scope improvement | Ulrich Sibiller | 2020-11-03 | 1 | -2/+2 |
| | | |||||
| * | Log.h: fix some shadow warnings | Ulrich Sibiller | 2020-11-03 | 1 | -7/+7 |
| | | | | | | | | | | | | | | | | | | | | | | "warning: declaration of '<something>' shadows a member of 'this' This shows up in gcc 4.8.5 and has been fixed in gcc 5.0, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57709 Change the variable names anyway to be on the safe side. Fixes ArcticaProject/nx-libs#958 | ||||
| * | Channel.h: rename variable to prevent shadowing | Ulrich Sibiller | 2020-11-03 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In file included from Proxy.h:39:0, from ServerProxy.h:32, from ServerProxy.cpp:36: Channel.h: In member function 'int Channel::handleEncodeIdentity(EncodeBuffer&, ChannelCache*, MessageStore*, const unsigned char*, unsigned int, int)': Channel.h:369:3: warning: declaration of 'bigEndian' shadows a member of 'this' [-Wshadow] { ^ Channel.h: In member function 'int Channel::handleDecodeIdentity(DecodeBuffer&, ChannelCache*, MessageStore*, unsigned char*&, unsigned int&, int, WriteBuffer*)': Channel.h:378:3: warning: declaration of 'bigEndian' shadows a member of 'this' [-Wshadow] { ^ RHEL7's g++ 4.8.5 reports this while Debian's g++ 10.2.0-15 does not. This is described in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57709 and fixed in gcc 5.0. Rename the variables anyway to be on the safe side. Fixes ArcticaProject/nx-libs#956 | ||||
| * | nx-libs.spec: Set python shebang to python3 on fedora and rhel8 | Ulrich Sibiller | 2020-11-03 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | | | | | *** ERROR: ambiguous python shebang in /usr/bin/nxdialog: #!/usr/bin/env python. Change it to python3 (or python2) explicitly. Fedora offers a pythfix.py but I could not test with that so I simply used sed... Fixes ArcticaProject/nx-libs#955 | ||||
| * | Xext/panoramiX.c: rename shadowing variables | Ulrich Sibiller | 2020-11-03 | 1 | -7/+7 |
| | | |||||
| * | Clipboard.c: add missing ifdefs | Ulrich Sibiller | 2020-11-03 | 1 | -0/+6 |
| | | |||||
| * | Compext.c: scope improvements | Ulrich Sibiller | 2020-11-03 | 1 | -14/+6 |
| | | |||||
| * | GCs.h: fix typo | Ulrich Sibiller | 2020-11-03 | 1 | -1/+1 |
| | | |||||
| * | Atoms.c: drop double include | Ulrich Sibiller | 2020-11-03 | 1 | -1/+0 |
| | | |||||
| * | Compext.c: use SAFE_free macro | Ulrich Sibiller | 2020-11-03 | 4 | -169/+106 |
| | | |||||
| * | Clipboard.c: fix missing ) | Ulrich Sibiller | 2020-11-03 | 1 | -1/+1 |
| | | |||||
* | | Merge branch 'sunweaver-pr/default-to-NXAGENT_DANGEROUS_XFONT_LOOP_EXIT' ↵ | Mike Gabriel | 2020-11-04 | 1 | -4/+11 |
|\ \ | |/ |/| | | | | | | | | | into 3.6.x Attributes GH PR #961: https://github.com/ArcticaProject/nx-libs/pull/961 Approved by Ulrich Sibiller <uli42@gmx.de>, Tue, 03 Nov 2020 08:14:04 -0800 | ||||
| * | NXdixfonts.c: Hard-code the enablement of NXAGENT_DANGEROUS_XFONT_LOOP_EXIT. | Mike Gabriel | 2020-11-03 | 1 | -0/+7 |
| | |