aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Window.c: add missing comment about nxagentConfiguredWindowListUlrich Sibiller2019-06-191-0/+6
| | | | | was in inital version of 6ce9fb5f2875754f97035d3338b3d0e1d20169ae but got lost during some rebasing/cherry-picking preceeding the pull request.
* dix/window.c: fix compiler warningUlrich Sibiller2019-06-191-10/+8
| | | | | Window.c:3827:46: warning: array subscript 128 is above array bounds of ‘StoringPixmapRec *[128]’ {aka ‘struct <anonymous> *[128]’} [-Warray-bounds] i, (void *) nxagentBSPixmapList[i]);
* NXshm.c: remove left-overs from patchUlrich Sibiller2019-06-121-3/+3
| | | | format was broken, would not compile
* miwindow.c: add hint to Red Hat Bugzilla + fixUlrich Sibiller2019-06-121-0/+1
|
* mi: Hush an almost certainly bogus warningUlrich Sibiller2019-06-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | commit 57e872301f5e836be2efb8f952f9c9711650b447 Author: Adam Jackson <ajax@redhat.com> Date: Thu Apr 5 13:07:09 2018 -0400 mi: Hush an almost certainly bogus warning In file included from ../mi/miexpose.c:83: ../mi/miexpose.c: In function ‘miHandleExposures’: ../include/regionstr.h:174:22: warning: ‘expBox.y2’ may be used uninitialized in this function [-Wmaybe-uninitialized] (_pReg)->extents = *(_pBox); ~~~~~~~~~~~~~~~~~^~~~~~~~~~ ../mi/miexpose.c:139:12: note: ‘expBox.y2’ was declared here BoxRec expBox; ^~~~~~ etc. It's initialized if (extents), and then only read if (extents), but gcc doesn't seem to figure that out. Whatever, bzero it to be explicit. Signed-off-by: Adam Jackson <ajax@redhat.com> Acked-by: Keith Packard <keithp@keithp.com>
* Window.c: Drop defines CWParent and CWStackingOrderUlrich Sibiller2019-06-122-17/+14
| | | | | | They were just aliases to already existing defines and were not used stringently. So we had mix of aliased and non-aliased uses which is confusing when trying to understand the code...
* Window.c: remove leftover (commented) codeUlrich Sibiller2019-06-121-14/+0
| | | | | | | | | | | This was eventually replaced by nxagentAddConfiguredWindow(pWin, CW_Map) some lines below which is just leading to the same code being executed some time later. (nxagentAddConfiguredWindow() will add a window to a list. nxagentFlushConfiguredWindow() is called at certain points to update all windows in that list in one go. "update" here means calling XConfigureWindow() or XMapWindow() on the real display.)
* NXwindow.c: fix compiler warningUlrich Sibiller2019-06-121-1/+1
| | | | | | | | | | | | NXwindow.c:265:27: warning: ‘%d’ directive writing between 1 and 11 bytes into a region of size 10 [-Wformat-overflow=] sprintf(artsd_port,"%d", nPort); ^~ NXwindow.c:265:26: note: directive argument in the range [-2147476648, 2147483647] sprintf(artsd_port,"%d", nPort); ^~~~ NXwindow.c:265:7: note: ‘sprintf’ output between 2 and 12 bytes into a destination of size 10 sprintf(artsd_port,"%d", nPort); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* Remove the Must_have_memory hack.Ulrich Sibiller2019-06-127-37/+15
| | | | | | | | | | | | | We are not using any alloc function that respects that variable, so lets drop it. Backport of this commit: commit 0ce61e21d6d7dcca0090e319bbcdb678570f2c3f Author: Adam Jackson <ajax@redhat.com> Date: Fri Oct 3 16:05:19 2008 -0400 Remove the Must_have_memory hack. Also remove an astonishing amount of misunderstanding of how casts work.
* Merge branch 'uli42-pr/use_selection_callback' into 3.6.xMike Gabriel2019-06-117-108/+106
|\ | | | | | | Attributes GH PR #814: https://github.com/ArcticaProject/nx-libs/pull/814
| * NXdispatch.c: use upstream version of ProcSetSelectionOwnerUlrich Sibiller2019-06-112-99/+0
| |
| * NXdispatch.c: Use Callback instead of a modified functionUlrich Sibiller2019-06-112-9/+9
| |
| * Add nxagentSetSelectionCallbackUlrich Sibiller2019-06-111-0/+69
| |
| * Add nxagentExternalClipboardEventTrapUlrich Sibiller2019-06-113-0/+28
|/
* Merge branch 'uli42-pr/drop_nxmiexpose' into 3.6.xMike Gabriel2019-06-116-790/+4
|\ | | | | | | Attributes GH PR #812: https://github.com/ArcticaProject/nx-libs/pull/812
| * NXmiexpose.c: drop file altogetherUlrich Sibiller2019-06-115-210/+2
| | | | | | | | The only left function is identical to the one in mi/miexpose.c.
| * Window.c/NXmiexpose.c: remove hack for certain WM themeUlrich Sibiller2019-06-112-33/+1
| | | | | | | | | | We do not even know what theme this is and it is probably not relevant nowadays.
| * NXmiexpose.c: mark NX changesUlrich Sibiller2019-06-111-4/+5
| |
| * NXmiexpose.c: use upstream version of miPaintWindows()Ulrich Sibiller2019-06-112-273/+2
| | | | | | | | | | | | | | | | | | miPaintWindow() was identical to the version in miexpose.c except for some unitialized variable fixes. As these also should be in upstream code we add them there (Note: Xorg never fixed this but totally rewrote the miPaintWindow() later on.) This allows us to totally drop our special version of miPaintWindow().
| * NXmiexpose.c: use upstream miHandleExposures()Ulrich Sibiller2019-06-112-276/+0
|/ | | | | It is (functionally) identical to our code, so why have duplicate code?
* Merge branch 'uli42-pr/various_small_things' into 3.6.xMike Gabriel2019-06-114-37/+226
|\ | | | | | | Attributes GH PR #813: https://github.com/ArcticaProject/nx-libs/pull/813
| * Window.c: comment on the purpose of some functionsUlrich Sibiller2019-06-111-8/+166
| |
| * Events.c: add debug outputUlrich Sibiller2019-06-111-0/+7
| |
| * Clipboard.c: more debugging outputUlrich Sibiller2019-06-111-1/+17
| |
| * Clipboard.c: Scope improvementsUlrich Sibiller2019-06-111-5/+2
| |
| * Clipboard.c: fix wrong variable being printedUlrich Sibiller2019-06-111-1/+1
| |
| * Screen.c: more TEST outputUlrich Sibiller2019-06-111-5/+10
| |
| * Screen.c: use consistent spacing on pointer referencesUlrich Sibiller2019-06-111-4/+4
| |
| * Screen.c: whitespace/formatting fixesUlrich Sibiller2019-06-111-21/+22
| |
| * Screen.c: report both created windows (and with the right name)Ulrich Sibiller2019-06-111-4/+9
| |
| * Window.c: fix: report correct window on icon window creationUlrich Sibiller2019-06-111-2/+2
|/
* Merge branch 'uli42-pr/fix_broken_cursor_handling' into 3.6.xMike Gabriel2019-06-114-69/+81
|\ | | | | | | Attributes GH PR #810: https://github.com/ArcticaProject/nx-libs/pull/810
| * os: fix BigReq ignoring when another request is pendingUlrich Sibiller2019-06-111-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Not sure how it came to this situation, but the following commit is partly contained in our version of the code. Some lines had not been removed, tough... commit c80c41767eb101e9dbd8393d8cca7764b4e248a4 Author: Aaron Plattner <aplattner@nvidia.com> Date: Mon Oct 25 22:01:32 2010 -0700 os: Fix BigReq ignoring when another request is pending Commit cf88363db0ebb42df7cc286b85d30d7898aea840 fixed the handling of BigReq requests that are way too large and handles the case where the read() syscall returns a short read. However, it neglected to handle the case where it returns a long read, which happens when the client has another request in the queue after the bogus large one. Handle the long read case by subtracting the smaller of 'needed' and 'gotnow' from oci->ignoreBytes. If needed < gotnow, simply subtract the two, leaving gotnow equal to the number of extra bytes read. Since the code immediately following the (oci->ignoreBytes > 0) block tries to handle the next request, advance oci->bufptr immediately instead of setting oci->lenLastReq and letting the next call to ReadRequestFromClient do it. Fixes the XTS pChangeKeyboardMapping-3 test. CASES TESTS PASS UNSUP UNTST NOTIU WARN FIP FAIL UNRES UNIN ABORT -Xproto 122 389 367 2 19 0 0 0 1 0 0 0 +Xproto 122 389 368 2 19 0 0 0 0 0 0 0 Signed-off-by: Aaron Plattner <aplattner@nvidia.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Signed-off-by: Keith Packard <keithp@keithp.com>
| * render/glyph.c: add missing usage_hintUlrich Sibiller2019-06-111-1/+2
| | | | | | | | was missing in 8b5bb2cdafe5f7bd77826a1fd28f07b7329be899
| * Fix NXevents.c: Reactivate errornously commented functionUlrich Sibiller2019-06-112-66/+79
|/ | | | | | | | | CheckMotion() had been commented in add881931f2e702fb1952f4e1baba04b3dc536ee as it looked identical to the version from dix/events.c except for some commented code. But this based (probably) on a thinko - code that had been disabled by NX became active again this way. Fix this by removing the comments and by adding #ifdef/else to emphasize the difference.
* Merge branch 'uli42-pr/remove_requestlog' into 3.6.xMike Gabriel2019-06-113-23/+0
|\ | | | | | | Attributes GH PR #811: https://github.com/ArcticaProject/nx-libs/pull/811
| * dix: remove unused requestLogIndexUlrich Sibiller2019-05-293-23/+0
|/ | | | | | | | | | | | | | | | | | | | | As done in these commits: commit 6583477035234e23ead2fad9db7a07e5862447a4 Author: Nicolai Hähnle <nhaehnle@gmail.com> Date: Sat May 23 13:35:24 2009 +0200 Remove reference to non-existing requestLog and requestLogIndex These fields were removed in 252ec504817e05b185e4896a2d899e9c00b8aeef. Signed-off-by: Nicolai Haehnle <nhaehnle@gmail.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> commit 252ec504817e05b185e4896a2d899e9c00b8aeef Author: Adam Jackson <ajax@redhat.com> Date: Mon Mar 30 15:18:30 2009 -0400 Document which bits of ClientRec are currently unused
* Merge branch 'uli42-pr/fix_xkb_crash' into 3.6.xMike Gabriel2019-05-212-0/+18
|\ | | | | | | Attributes GH PR #809: https://github.com/ArcticaProject/nx-libs/pull/809
| * libNX_X11: add additional checks for dpy and xkbUlrich Sibiller2019-05-171-0/+14
| | | | | | | | | | | | | | | | | | We have seen crashes during session shutdown/connection problems here. These patches should avoid them. There's no proper way to test them, but they should do no harm.. Fixes ArcticaProject/nx-libs#801 Fixes https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=695
| * xkbUtils.c: Catch division by zeroUlrich Sibiller2019-05-171-0/+4
|/ | | | Fixes ArcticaProject/nx-libs#808
* Merge branch 'andschwa-xtestext1h' into 3.6.xMike Gabriel2019-05-174-40/+0
|\ | | | | | | | | | | Attributes GH PR #806: https://github.com/ArcticaProject/nx-libs/pull/806 Fixes ArcticaProject/nx-libs#807.
| * Remove Debian build references to `xtestext1.h`Andrew Schwartzmeyer2019-05-134-40/+0
|/ | | | | This file has been deleted, but references to it in the build remain, causing `debuild` to fail.
* Merge branch 'uli42-pr/small_fixes' into 3.6.xMike Gabriel2019-05-1128-3209/+120
|\ | | | | | | Attributes GH PR #797: https://github.com/ArcticaProject/nx-libs/pull/797
| * nxagent: make nxagentX2go a BooleanUlrich Sibiller2019-05-102-10/+10
| |
| * README.keystrokes: mention nxdialogUlrich Sibiller2019-05-101-5/+17
| |
| * Remove useless "ignore" keystroke for Ctrl-Alt-BackspaceUlrich Sibiller2019-05-102-3/+0
| | | | | | | | nxagent does not react on that anyway (see xkb/xkbDflts.h)
| * README.keystrokes: refine descriptionUlrich Sibiller2019-05-101-8/+14
| |
| * NXdispatch.c: indent code to match environmentUlrich Sibiller2019-05-101-13/+13
| |
| * NXdispatch.c: add missing fixesUlrich Sibiller2019-05-101-5/+3
| | | | | | | | transfer to derived file was incomplete in 6acbfab33133a92dbd7f128284d26f94bfeb1af2
| * NXdispatch.c: add missing changeUlrich Sibiller2019-05-101-0/+3
| | | | | | | | This change was missing in 239fe3d0802b12ce8947741693244ff8154fa559
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-19 08:13:10 +0000