aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* shellcheck: Fix SC2061 issueMario Trangoni2021-01-311-1/+1
| | | | | | | | | | | | | $ find . -name "*.sh" | xargs shellcheck -i SC2061 In ./roll-tarballs.sh line 159: find nx-X11/extras/Mesa/ -name Makefile.* | while read -r file; do rm "$file"; done ^--------^ SC2061: Quote the parameter to -name so the shell won't interpret it. For more information: https://www.shellcheck.net/wiki/SC2061 -- Quote the parameter to -name so t... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* shellcheck: Fix SC2048 issueMario Trangoni2021-01-311-1/+1
| | | | | | | | | | | | | | | See, $ find . -name "*.sh" | xargs shellcheck -i SC2048 In ./nx-X11/lib/src/util/mkks.sh line 10: }' $* ^-- SC2048: Use "$@" (with quotes) to prevent whitespace problems. For more information: https://www.shellcheck.net/wiki/SC2048 -- Use "$@" (with quotes) to prevent... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* shellcheck: Fix SC2196 issuesMario Trangoni2021-01-311-2/+2
| | | | | | | | | | | | | | | | | | | See, $ find . -name "*.sh" | xargs shellcheck -i SC2196 In ./roll-tarballs.sh line 163: sort "debian/patches/series" | grep -v '^#' | egrep "([0-9]+(_|-).*\.(full|full\+lite)\.patch)" | while read -r file ^---^ SC2196: egrep is non-standard and deprecated. Use grep -E instead. In ./roll-tarballs.sh line 200: sort "debian/patches/series" | grep -v '^#' | egrep "([0-9]+(_|-).*\.full\+lite\.patch)" | while read -r file ^---^ SC2196: egrep is non-standard and deprecated. Use grep -E instead. For more information: https://www.shellcheck.net/wiki/SC2196 -- egrep is non-standard and depreca... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* shellcheck: Fix SC2034 issueMario Trangoni2021-01-311-1/+0
| | | | | | | | | | | | | | | See, $ find . -name "*.sh" | xargs shellcheck -i SC2034 In ./roll-tarballs.sh line 34: NULL="" ^--^ SC2034: NULL appears unused. Verify use (or export if used externally). For more information: https://www.shellcheck.net/wiki/SC2034 -- NULL appears unused. Verify use (... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* shellcheck: Fix SC2002 issueMario Trangoni2021-01-313-9/+9
| | | | | | | | | | | See, $ find . -name "*.sh" | xargs shellcheck -i SC2002 For more information: https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* shellcheck: Fix SC2045 issueMario Trangoni2021-01-311-2/+3
| | | | | | | | | | | | | | | See, $ find . -name "*.sh" | xargs shellcheck -i SC2045 In ./roll-tarballs.sh line 220: for f in $(ls README* 2>/dev/null); do ^-----------------------^ SC2045: Iterating over ls output is fragile. Use globs. For more information: https://www.shellcheck.net/wiki/SC2045 -- Iterating over ls output is fragi... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* shellcheck: Fix some SC2086 issuesMario Trangoni2021-01-311-5/+5
| | | | | | | | | | see, $ find . -name "*.sh" | xargs shellcheck -i SC2086 For more information: https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* shellcheck: Fix SC2059 issueMario Trangoni2021-01-311-1/+1
| | | | | | | | | | | | | | | See, $ find . -name "*.sh" | xargs shellcheck -i SC2059 In ./version.sh line 34: printf "${VER}" ^------^ SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". For more information: https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* shellcheck: Fix SC2148 issuesMario Trangoni2021-01-311-0/+2
| | | | | | | | | | | | | | See, $ find . -name "*.sh" | xargs shellcheck -i SC2148 In ./replace.sh line 1: ^-- SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. For more information: https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* shellcheck: Fix SC2162 issueMario Trangoni2021-01-312-11/+11
| | | | | | | | | | | | | See, find . -name "*.sh" | xargs shellcheck -i SC2162 [...] For more information: https://www.shellcheck.net/wiki/SC2162 -- read without -r will mangle backs... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* shellcheck: Fix SC2006 issueMario Trangoni2021-01-313-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See, $ find . -name "*.sh" | xargs shellcheck -i SC2006 In ./roll-tarballs.sh line 62: echo "HEAD (on branch `git rev-parse --abbrev-ref HEAD`)" ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: echo "HEAD (on branch $(git rev-parse --abbrev-ref HEAD))" In ./nx-X11/x-indent-all.sh line 2: where=`dirname $0` ^----------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: where=$(dirname $0) In ./nx-X11/x-indent.sh line 5: INDENT=`which gnuindent || which gindent || which indent` ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: INDENT=$(which gnuindent || which gindent || which indent) For more information: https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* debian/patches: Drop 2002_xserver-xext_set-securitypolicy-path.debian.patch. ↵Mike Gabriel2021-01-182-20/+0
| | | | | | Not required anymore since 689f811b. Regression fix.
* Merge branch 'uli42-pr/drop_alternative_securitypolicy' into 3.6.xMike Gabriel2021-01-182-205/+2
|\ | | | | | | Attributes GH PR #989: https://github.com/ArcticaProject/nx-libs/pull/989
| * Xext: drop NX_ALTERNATIVEPOLICYFILEUlrich Sibiller2021-01-181-202/+0
| | | | | | | | | | | | We can now also drop all remaining NX specific lines from the security.c see ArcticaProject/nx-libs#988
| * Xext: use $USRDATADIR/SecurityPolicyUlrich Sibiller2021-01-181-3/+2
|/ | | | | | | | This reflects the path where the file is placed after installation. It also obsoletes the NX_ALTERNATIVEPOLICYFILE. Fixes ArcticaProject/nx-libs#988
* Merge branch 'uli42-pr/fix_fullscreen' into 3.6.xMike Gabriel2021-01-182-7/+1
|\ | | | | | | Attributes GH PR #990: https://github.com/ArcticaProject/nx-libs/pull/990
| * Args.c: improve usage string for -geometryUlrich Sibiller2021-01-161-1/+1
| |
| * Screen.c: remove superflous code that produces a crashUlrich Sibiller2021-01-161-6/+0
|/ | | | Fixes ArcticaProject/nx-libs#987
* Merge branch 'uli42-pr/musl_fixes' into 3.6.xMike Gabriel2021-01-163-0/+14
|\ | | | | | | Attributes GH PR #982: https://github.com/ArcticaProject/nx-libs/pull/982
| * Xext: include limits.hUlrich Sibiller2021-01-161-0/+1
| | | | | | | | | | | | Is required for compilations with musl. See ArcticaProjects/nx-libs#975 and ArcticaProjects/nx-libs#976
| * Mesa: make compilation with work with muslUlrich Sibiller2021-01-162-0/+13
|/ | | | Fixes ArcticaProject/nx-lib#975
* Merge branch 'uli42-pr/pvs_findings' into 3.6.xMike Gabriel2021-01-1613-58/+137
|\ | | | | | | Attributes GH PR #981: https://github.com/ArcticaProject/nx-libs/pull/981
| * Display.c: fix and reformat broken commentUlrich Sibiller2021-01-161-12/+11
| |
| * Window.c: suppress warningUlrich Sibiller2021-01-161-1/+1
| | | | | | | | | | | | | | | | This used to be printed only in TEST mode. Some while ago I had changed that to WARNING (because it is a warning...). However, this happens e.g. when running the xscreensaver vfeedback module and it does not look like it is a problem at all. So let's suppress this warning again and leave it to the TEST mode as it used to be.
| * fix formatting and spelling in various filesUlrich Sibiller2021-01-1612-18/+17
| |
| * nxagent: Drop unused nxagentRootTileWindowUlrich Sibiller2021-01-162-4/+0
| |
| * Handlers.c: add FIXMEUlrich Sibiller2021-01-161-0/+3
| |
| * Screen.c: clarify that characters are comparedUlrich Sibiller2021-01-161-2/+2
| |
| * Client.h: conditionally add unused fieldUlrich Sibiller2021-01-161-2/+5
| |
| * Handlers.c: use the same boolean values as in NXdispatch.cUlrich Sibiller2021-01-161-2/+2
| | | | | | | | although there is no functional difference...
| * manpage: document defaults for options -defer and -tileUlrich Sibiller2021-01-161-1/+11
| |
| * NXDispatch.c: remove double nxagentFreeAtomMap()Ulrich Sibiller2021-01-161-1/+0
| |
| * Window.c: check for malloc failureUlrich Sibiller2021-01-151-13/+22
| | | | | | | | PVS finding: "V522 There might be dereferencing of a potential null pointer 'props'"
| * Window.c: check for malloc failureUlrich Sibiller2021-01-151-0/+8
| | | | | | | | PVS finding: "V522 There might be dereferencing of a potential null pointer 'nxagentConfiguredWindowList'."
| * Screen.c: check for malloc failuresUlrich Sibiller2021-01-151-0/+39
| | | | | | | | PVS finding: "V522 There might be dereferencing of a potential null pointer"
| * Splash.c: remove unneccessary checkUlrich Sibiller2021-01-151-9/+4
| | | | | | | | PVs finding: "V547 Expression '!nxagentWMPassed' is always true."
| * Rootless.c: prevent PVS errorUlrich Sibiller2021-01-151-1/+2
| | | | | | | | "V547 Expression 'wmHints.input == 1' is always true."
| * Render.c: Init BoxRecUlrich Sibiller2021-01-151-1/+1
| | | | | | | | PVS Studio: "V614 Potentially uninitialized variable 'glyphBox.*' used."
| * Reconnect.c: fix possible realloc() memory lossUlrich Sibiller2021-01-151-2/+6
| | | | | | | | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'nxagentReconnectErrorMessage' is lost. Consider assigning realloc() to a temporary pointer."
| * NXglyph.c: check for malloc errorUlrich Sibiller2021-01-151-0/+7
| | | | | | | | | | "V575 The potential null pointer is passed into 'memcpy' function. Inspect the first argument."
| * Keyboard.c: fix possible NULL pointer dereferenceUlrich Sibiller2021-01-151-0/+5
| | | | | | | | | | found by PVS Studio: "V522 There might be dereferencing of a potential null pointer 'keymap'."
| * Drawable.c: Prevent PVS Studio warningUlrich Sibiller2021-01-151-1/+3
| | | | | | | | | | "V560 A part of conditional expression is always true: oldStatus == NotSynchronized."
| * Display.c: prevent PVS Studio realloc warningUlrich Sibiller2021-01-151-5/+11
| | | | | | | | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'nxagentDefaultColormaps' is lost. Consider assigning realloc() to a temporary pointer."
| * Atoms.c: add explanation for PVS Studio warningUlrich Sibiller2021-01-151-0/+3
| | | | | | | | | | "V575 The potential null pointer is passed into 'strlen' function. Inspect the first argument. Check lines: 420, 403."
| * NXpicture.c: remove unneccessary checkUlrich Sibiller2021-01-151-15/+12
| | | | | | | | | | | | | | Code can only be reached if pPicture is non-NULL. Besides, pPicture will be accessed later anyway, regardless of this check. Finding of PVS Studio: "V547 Expression 'pPicture != NULL' is always true."
| * Keyboard.c: simplify codeUlrich Sibiller2021-01-151-5/+3
| | | | | | | | Based on PVS Studio finding: "V547 Expression 'data' is always true."
| * Colormap.c: remove unneccessary checkUlrich Sibiller2021-01-151-1/+1
| | | | | | | | | | | | | | | | success would always be true at the beginning of the loop as it is part of the loop condition. Finding from PVS Studio: "V560 A part of conditional expression is always true: success."
| * Colormap.c: fix parenthesesUlrich Sibiller2021-01-151-1/+1
| | | | | | | | | | | | PVS Studio: "V592 The expression was enclosed by parentheses twice: '((* pRed * (limg + 1)))'. One pair of parentheses is unnecessary or misprint is present."
| * Atoms.c: silence PVS Studio warningUlrich Sibiller2021-01-151-2/+6
| | | | | | | | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'privAtomMap' is lost. Consider assigning realloc() to a temporary pointer."
| * Atoms.c: cosmetics in nxagentWriteAtom()Ulrich Sibiller2021-01-151-1/+2
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-29 02:16:00 +0000