| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Xrm.c: In function 'PutEntry':
Xrm.c:900:15: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
!quarks[2] != table->leaf)
^~
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#530
|
|
|
|
| |
Code was here twice and could be simply merged.
|
|
|
|
|
|
|
| |
Was missed in
GH PR #544: https://github.com/ArcticaProject/nx-libs/pull/544
Fixes: ArcticaProject/nx-libs#536
|
|
|
|
| |
its build cruft.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
We need that function for performance reasons. By removing
_X_DEPRECATED we get rid of compiler warnings.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
_XReply isn't reentrant, and it can lead to deadlocks when the default error
handler is called: _XDefaultError calls exit(1). It is called indirectly by
_XReply when a X protocol error comes in that isn't filtered/handled by an
extension or the application. This means that if the application (or one of its
loaded shared libraries such as the NVIDIA OpenGL driver) has registered any
_fini destructor, _fini will get called while still on the call stack of
_XReply. If the destructor interacts with the X server and calls _XReply, it
will hit a deadlock, looping on the following in _XReply:
ConditionWait(dpy, dpy->xcb->reply_notify);
It is legal for an application to make Xlib calls during _fini, and that is
useful for an OpenGL driver to avoid resource leaks on the X server side, for
example in the dlopen/dlclose case. However, the driver can not readily tell
whether its _fini is being called because Xlib called exit, or for another
reason (dlclose), so it is hard to cleanly work around this issue in the driver.
This change makes it so _XReply effectively becomes a no-op when called after
_XDefaultError was called, as though an XIOError had happened. The dpy
connection isn't broken at that point, but any call to _XReply is going to hang.
This is a bit of a kludge, because the more correct solution would be to make
_XReply reentrant, maybe by broadcasting the reply_notify condition before
calling the default error handler. However, such a change would carry a grater
risk of introducing regressions in Xlib.
This change will drop some valid requests on the floor, but this should not
matter, as it will only do so in the case where the application is dying: X will
clean up after it once exit() is done running. There is the case of
XSetCloseDownMode(RETAIN_PERMANENT), but an application using that and wishing
to clean up resources in _fini would currently be hitting a deadlock, which is
hardly a better situation.
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Jamey Sharp <jamey@minilop.net>
|
|
|
|
|
|
|
|
|
|
|
|
| |
'ch' gets moved inside the allocated buffer as we're looping through
fonts, so keep a reference to the start of the buffer so we can pass
that to Xfree in the failure case.
Fixes: commit 20a3f99eba5001925b8b313da3accb7900eb1927 "Plug a memory leak"
Signed-off-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
|
|
|
| |
- Support for i18n in libNX_X11 is static only, has ever been.
- Thus, the files XlcSL.[co], XlcDL.[co], XDefaultIMIF.[co],
XDefaultOMIF.[co] and lcDynamic.[co] become obsolete.
|
| |
|
|
|
|
| |
8bit_tab_to_h.c and cjk_tab_to_h.c to nx-libs's doc/ folder.
|
|
|
|
| |
Relates to ArcticaProject/nx-libs#275.
|
|
|
|
| |
Relates to ArcticaProject/nx-libs#275.
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#288.
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#274.
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#273.
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#272.
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#271.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Creating libX11 symlinks breaks our builds in clean environments. Drop this
feature for now.
It must be rewritten to only create the symlinks after everything has been
built.
|
| |
|
|
|
|
|
|
| |
is_numeric is only needed if X11_t is defined.
Silences "warning: ‘is_numeric’ defined but not used [-Wunused-function]"
|
|
|
|
|
|
| |
warning: "XTRANS_SEND_FDS" is not defined [-Wundef]
This define came in via the recent xtrans update.
|
|
|
|
| |
warning: format ‘%p’ expects argument of type ‘void *’
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This lifts xtrans to the state of this commit:
commit 560d7550e23e9b14056b4a9b2569c2f256015f8a
Author: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
Date: Sat Sep 10 22:09:51 2016 -0700
Update strlcpy macro check to also check HAVE_STRLCPY
xorg-server moved from HAS_STRLCPY to HAVE_STRLCPY in 2011
cf-xserver: d829a7c5cb42c979b58f3547136df5b05d906423
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Remove CLTS code
Never been used, as far as I can tell.
Reviewed-by: Keith Packard <keithp@keithp.com>
Signed-off-by: Adam Jackson <ajax@redhat.com>
Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>
|
| |
|
| |
|
| |
|
|
|
|
| |
this simplyfies updating to Xorg/xtrans upstream
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"""
It's simply obsolete, sloppy, compiler namespace pollution. The
compiler is not allowed to predefine symbols that might conflict with
ordinary identifiers. For backwards compatibility gcc currently
predefines i386 when compiling for x86 32-bit (but not 64-bit), but that
will go away. It is also not defined if you specify -ansi when invoking
the compiler, because then it is seriously standards compliant. Other
compilers shouldn't define it either. Correct code shouldn't rely on it
being defined. However __i386__ is safe and proper.
"""
Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>
|
|
|
|
| |
empty lines and trailing whitespace
|
|
|
|
|
|
| |
If your OS doesn't have sysconf(3), then life is already hard for you.
Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
just as Xorg upstream did
|
|
|
|
| |
although upstream still includes it.
|
| |
|