| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See,
$ find . -name "*.sh" | xargs shellcheck -i SC2048
In ./nx-X11/lib/src/util/mkks.sh line 10:
}' $*
^-- SC2048: Use "$@" (with quotes) to prevent whitespace problems.
For more information:
https://www.shellcheck.net/wiki/SC2048 -- Use "$@" (with quotes) to prevent...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
See,
$ find . -name "*.sh" | xargs shellcheck -i SC2002
For more information:
https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Direct leak of 3 byte(s) in 1 object(s) allocated from:
#0 0xb79e85d4 in __interceptor_malloc (/lib/i386-linux-gnu/libasan.so.5+0xeb5d4)
#1 0xb770b635 in copystring /home/uli/work/nx/nx-libs/nx-X11/lib/src/ConnDis.c:96
#2 0xb770ba56 in _X11TransConnectDisplay /home/uli/work/nx/nx-libs/nx-X11/lib/src/ConnDis.c:229
#3 0xb776b4fd in XOpenDisplay /home/uli/work/nx/nx-libs/nx-X11/lib/src/OpenDis.c:215
#4 0x63e2fd in nxagentInternalOpenDisplay /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Display.c:608
#5 0x63fa03 in nxagentOpenDisplay /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Display.c:1140
#6 0x694b5a in InitOutput /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Init.c:305
#7 0x5f7b11 in main /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/dix/main.c:278
#8 0xb6f04b40 in __libc_start_main ../csu/libc-start.c:308
I have not investigated the exact location where an XFree() was missing but added multiple
Xfree() calls whereever appropriate.
Fixes ArcticaProject/nx-libs#951
|
|
|
|
|
|
|
|
|
| |
NX does not support passing around FDs for local connections.
This will not cause any change in the resulting code as this variable
had been unset by default.
Fixes ArcticaProject/nx-libs#784
|
|
|
|
|
|
| |
as it has been in the imake builds
Fixes ArcticaProject/nx-libs#783
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#780
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#779
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Backport of this commit:
commit 7ba7085b4f01f3cd72008712a5333ea3f0edfd88
Author: walter harms <wharms@bfs.de>
Date: Sat Oct 28 19:14:22 2017 +0200
AuRead.c: remove redundant null check on calling free()
this removes simply unneeded code from XauReadAuth
Signed-off-by: Walter Harms <wharms@bfs.de>
Reviewed-by: Daniel Martin <consume.noise@gmail.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
|
| |
|
|
|
|
|
|
|
|
| |
libXau is integrated into libNX_X11, but the differences to libXau
original code where not explicitly marked. This path adds some ifdefs
and also restores the original code.
Attributes to ArcticaProject/nx-libs#850
|
| |
|
|
|
|
|
|
|
|
|
| |
We have seen crashes during session shutdown/connection problems
here. These patches should avoid them. There's no proper way to test
them, but they should do no harm..
Fixes ArcticaProject/nx-libs#801
Fixes https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=695
|
|
|
|
| |
storage class specifier is deprecated and incompatible with C++17
|
| |
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#399
|
| |
|
|
|
|
| |
reflect the version of libX11 we are basing on
|
|
|
|
|
|
| |
defined at build-time.
Fixes ArcticaProject/nx-libs#768.
|
|
|
|
|
|
| |
This fixes an assertion being triggered on reconnect:
assertion=assertion@entry=0x7f2f0bba6510 "(dpy->flags & XlibDisplayPrivSync) != 0", file=file@entry=0x7f2f0bba62fc "XlibInt.c", line=line@entry=895,
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit is the only change between Xorg's libX11 1.6.6 and 1.6.7
that affects our code. So were are effectively now on par with libX11
1.6.7 (commit f3c978476e0be6813268af494efb7ac507451116)
From: Bhavi Dhingra <b.dhingra@samsung.com>
Date: Mon, 28 Sep 2015 08:33:40 +0000
Subject: [PATCH] XcmsLookupColor: fully initialize XColor structs passed to
_XColor_to_XcmsRGB
Fixes https://gitlab.freedesktop.org/xorg/lib/libx11/issues/44
aka https://bugs.freedesktop.org/show_bug.cgi?id=92154
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
|
|
|
|
| |
We are at X.Org libX11 upstream commit 733f64b
Fixes: ArcticaProject/nx-libs #716, #719 and #720
|
|
|
|
| |
913fcf1a74426725f14380dd5b34286a21c37ab7.
|
|
|
|
|
| |
Remove one over-zealous free() call. Thanks to Ulrich Sibiller for
spotting this.
|
| |
|
|
|
|
| |
other locations.
|
|
|
|
|
|
|
| |
Xrm.c: In function 'PutEntry':
Xrm.c:900:15: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
!quarks[2] != table->leaf)
^~
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#530
|
|
|
|
| |
Code was here twice and could be simply merged.
|
|
|
|
|
|
|
| |
Was missed in
GH PR #544: https://github.com/ArcticaProject/nx-libs/pull/544
Fixes: ArcticaProject/nx-libs#536
|
|
|
|
| |
its build cruft.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
We need that function for performance reasons. By removing
_X_DEPRECATED we get rid of compiler warnings.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
_XReply isn't reentrant, and it can lead to deadlocks when the default error
handler is called: _XDefaultError calls exit(1). It is called indirectly by
_XReply when a X protocol error comes in that isn't filtered/handled by an
extension or the application. This means that if the application (or one of its
loaded shared libraries such as the NVIDIA OpenGL driver) has registered any
_fini destructor, _fini will get called while still on the call stack of
_XReply. If the destructor interacts with the X server and calls _XReply, it
will hit a deadlock, looping on the following in _XReply:
ConditionWait(dpy, dpy->xcb->reply_notify);
It is legal for an application to make Xlib calls during _fini, and that is
useful for an OpenGL driver to avoid resource leaks on the X server side, for
example in the dlopen/dlclose case. However, the driver can not readily tell
whether its _fini is being called because Xlib called exit, or for another
reason (dlclose), so it is hard to cleanly work around this issue in the driver.
This change makes it so _XReply effectively becomes a no-op when called after
_XDefaultError was called, as though an XIOError had happened. The dpy
connection isn't broken at that point, but any call to _XReply is going to hang.
This is a bit of a kludge, because the more correct solution would be to make
_XReply reentrant, maybe by broadcasting the reply_notify condition before
calling the default error handler. However, such a change would carry a grater
risk of introducing regressions in Xlib.
This change will drop some valid requests on the floor, but this should not
matter, as it will only do so in the case where the application is dying: X will
clean up after it once exit() is done running. There is the case of
XSetCloseDownMode(RETAIN_PERMANENT), but an application using that and wishing
to clean up resources in _fini would currently be hitting a deadlock, which is
hardly a better situation.
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Jamey Sharp <jamey@minilop.net>
|
|
|
|
|
|
|
|
|
|
|
|
| |
'ch' gets moved inside the allocated buffer as we're looping through
fonts, so keep a reference to the start of the buffer so we can pass
that to Xfree in the failure case.
Fixes: commit 20a3f99eba5001925b8b313da3accb7900eb1927 "Plug a memory leak"
Signed-off-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
|
|
|
| |
- Support for i18n in libNX_X11 is static only, has ever been.
- Thus, the files XlcSL.[co], XlcDL.[co], XDefaultIMIF.[co],
XDefaultOMIF.[co] and lcDynamic.[co] become obsolete.
|
| |
|
|
|
|
| |
8bit_tab_to_h.c and cjk_tab_to_h.c to nx-libs's doc/ folder.
|
|
|
|
| |
Relates to ArcticaProject/nx-libs#275.
|
|
|
|
| |
Relates to ArcticaProject/nx-libs#275.
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#288.
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#274.
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#273.
|