aboutsummaryrefslogtreecommitdiff
path: root/nx-X11/lib
Commit message (Collapse)AuthorAgeFilesLines
* shellcheck: Fix SC2048 issueMario Trangoni2021-01-311-1/+1
| | | | | | | | | | | | | | | See, $ find . -name "*.sh" | xargs shellcheck -i SC2048 In ./nx-X11/lib/src/util/mkks.sh line 10: }' $* ^-- SC2048: Use "$@" (with quotes) to prevent whitespace problems. For more information: https://www.shellcheck.net/wiki/SC2048 -- Use "$@" (with quotes) to prevent... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* shellcheck: Fix SC2002 issueMario Trangoni2021-01-311-2/+2
| | | | | | | | | | | See, $ find . -name "*.sh" | xargs shellcheck -i SC2002 For more information: https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
* yConnDis.c: fix memory leakUlrich Sibiller2020-11-031-12/+28
| | | | | | | | | | | | | | | | | | Direct leak of 3 byte(s) in 1 object(s) allocated from: #0 0xb79e85d4 in __interceptor_malloc (/lib/i386-linux-gnu/libasan.so.5+0xeb5d4) #1 0xb770b635 in copystring /home/uli/work/nx/nx-libs/nx-X11/lib/src/ConnDis.c:96 #2 0xb770ba56 in _X11TransConnectDisplay /home/uli/work/nx/nx-libs/nx-X11/lib/src/ConnDis.c:229 #3 0xb776b4fd in XOpenDisplay /home/uli/work/nx/nx-libs/nx-X11/lib/src/OpenDis.c:215 #4 0x63e2fd in nxagentInternalOpenDisplay /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Display.c:608 #5 0x63fa03 in nxagentOpenDisplay /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Display.c:1140 #6 0x694b5a in InitOutput /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Init.c:305 #7 0x5f7b11 in main /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/dix/main.c:278 #8 0xb6f04b40 in __libc_start_main ../csu/libc-start.c:308 I have not investigated the exact location where an XFree() was missing but added multiple Xfree() calls whereever appropriate. Fixes ArcticaProject/nx-libs#951
* libNX_X11: set XTRANS_SEND_FDS=0Ulrich Sibiller2020-10-171-1/+4
| | | | | | | | | NX does not support passing around FDs for local connections. This will not cause any change in the resulting code as this variable had been unset by default. Fixes ArcticaProject/nx-libs#784
* libNX_X11: set FAIL_HARDUlrich Sibiller2020-10-171-0/+13
| | | | | | as it has been in the imake builds Fixes ArcticaProject/nx-libs#783
* libNX_X11: reintroduce SECURE_RPCUlrich Sibiller2020-10-171-0/+3
| | | | Fixes ArcticaProject/nx-libs#780
* libNX_X11: reintroduce HASXDMAUTHUlrich Sibiller2020-10-172-0/+26
| | | | Fixes ArcticaProject/nx-libs#779
* XlibInt.c: scope improvements/reformatUlrich Sibiller2020-05-071-14/+7
|
* XlibInt.c: simplify NX code insertionUlrich Sibiller2020-05-071-10/+5
|
* XlibInt.c: reformat some commentsUlrich Sibiller2020-05-071-20/+15
|
* XlibInt.c: simplify handling of NX_TRANS_{CHANGE,DEBUG} macrosUlrich Sibiller2020-05-071-37/+48
|
* Xau files: adapt code to match upstream libXau 1.0.9Ulrich Sibiller2019-11-014-51/+56
|
* AuRead.c: remove redundant null check on calling free()Ulrich Sibiller2019-11-011-9/+9
| | | | | | | | | | | | | | | | Backport of this commit: commit 7ba7085b4f01f3cd72008712a5333ea3f0edfd88 Author: walter harms <wharms@bfs.de> Date: Sat Oct 28 19:14:22 2017 +0200 AuRead.c: remove redundant null check on calling free() this removes simply unneeded code from XauReadAuth Signed-off-by: Walter Harms <wharms@bfs.de> Reviewed-by: Daniel Martin <consume.noise@gmail.com> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
* AuRead.c: whitespace cleanupUlrich Sibiller2019-11-011-30/+30
|
* Xau: mark NX changesUlrich Sibiller2019-11-011-0/+15
| | | | | | | | libXau is integrated into libNX_X11, but the differences to libXau original code where not explicitly marked. This path adds some ifdefs and also restores the original code. Attributes to ArcticaProject/nx-libs#850
* Quarks.c: add missing )Ulrich Sibiller2019-06-221-1/+1
|
* libNX_X11: add additional checks for dpy and xkbUlrich Sibiller2019-05-171-0/+14
| | | | | | | | | We have seen crashes during session shutdown/connection problems here. These patches should avoid them. There's no proper way to test them, but they should do no harm.. Fixes ArcticaProject/nx-libs#801 Fixes https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=695
* Xlib: remove register keywordsUlrich Sibiller2019-03-011-9/+9
| | | | storage class specifier is deprecated and incompatible with C++17
* xlib: remove superflous parensUlrich Sibiller2019-03-011-1/+1
|
* ConnDis.c: remove obsolete MNX_TCPCONNUlrich Sibiller2019-02-281-1/+1
| | | | Fixes ArcticaProject/nx-libs#399
* nx-X11/lib/configure.ac: add forgotten status lineUlrich Sibiller2019-02-201-0/+1
|
* nx-X11/lib/configure.ac: fix version numberUlrich Sibiller2019-02-201-1/+1
| | | | reflect the version of libX11 we are basing on
* nx-X11/lib/configure.ac: Assure that the USE_DYNAMIC_XCURSOR macro is ↵Mike Gabriel2019-02-201-0/+33
| | | | | | defined at build-time. Fixes ArcticaProject/nx-libs#768.
* XlibInt: check for XlibError before accessing other dpy fieldsUlrich Sibiller2018-12-221-0/+10
| | | | | | This fixes an assertion being triggered on reconnect: assertion=assertion@entry=0x7f2f0bba6510 "(dpy->flags & XlibDisplayPrivSync) != 0", file=file@entry=0x7f2f0bba62fc "XlibInt.c", line=line@entry=895,
* XlibInt.c: fix wrong debug messageUlrich Sibiller2018-12-221-1/+1
|
* libNX_X11: upgrade to X.org upstream version 1.6.7Ulrich Sibiller2018-10-221-1/+2
| | | | | | | | | | | | | | | | | This commit is the only change between Xorg's libX11 1.6.6 and 1.6.7 that affects our code. So were are effectively now on par with libX11 1.6.7 (commit f3c978476e0be6813268af494efb7ac507451116) From: Bhavi Dhingra <b.dhingra@samsung.com> Date: Mon, 28 Sep 2015 08:33:40 +0000 Subject: [PATCH] XcmsLookupColor: fully initialize XColor structs passed to _XColor_to_XcmsRGB Fixes https://gitlab.freedesktop.org/xorg/lib/libx11/issues/44 aka https://bugs.freedesktop.org/show_bug.cgi?id=92154 Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* libNX_X11: upgrade to X.org upstream version 1.6.6Ulrich Sibiller2018-10-2227-165/+311
| | | | | | We are at X.Org libX11 upstream commit 733f64b Fixes: ArcticaProject/nx-libs #716, #719 and #720
* misc: fix more regressions and whitespace weirdness introduced in ↵Mihai Moldovan2018-07-072-5/+8
| | | | 913fcf1a74426725f14380dd5b34286a21c37ab7.
* nx-X11/lib/include/xtrans/Xtrans.c: Regression fix for 913fcf1a.Mike Gabriel2018-07-031-1/+0
| | | | | Remove one over-zealous free() call. Thanks to Ulrich Sibiller for spotting this.
* Fix some memory leaks.Mario Trangoni2018-07-032-9/+9
|
* {nx-X11/lib,nxproxy}/Makefile.am: also use correct aclocal flags in the ↵Mihai Moldovan2017-12-151-0/+2
| | | | other locations.
* lib/X11/Xrm.c: Compiler warning fix: logical-not-parenthesesMike Gabriel2017-12-141-1/+1
| | | | | | | Xrm.c: In function 'PutEntry': Xrm.c:900:15: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] !quarks[2] != table->leaf) ^~
* Silence warning: "ar: 'u' modifier ignored since 'D' is the default"Ulrich Sibiller2017-12-111-0/+3
| | | | Fixes ArcticaProject/nx-libs#530
* Xtranssock.c: simplify code in SocketWritevUlrich Sibiller2017-12-111-44/+0
| | | | Code was here twice and could be simply merged.
* nx-X11/lib/include/xtrans/Xtranssock.c: drop UNIX path overrides as well.Mihai Moldovan2017-11-221-168/+0
| | | | | | | Was missed in GH PR #544: https://github.com/ArcticaProject/nx-libs/pull/544 Fixes: ArcticaProject/nx-libs#536
* .gitignore: Improve all .gitignore files, adapt to autotools build-flow and ↵Mike Gabriel2017-10-092-1/+14
| | | | its build cruft.
* Convert nx-X11/lib/ build flow from imake to autotools.Mike Gabriel2017-08-25530-1177/+1285
|
* nxcomp: Switch to autoreconf.Mike Gabriel2017-07-261-3/+3
|
* nxcompshad: Switch to autoreconf.Mike Gabriel2017-07-131-1/+1
|
* remove _X_DEPRECATED for XKeycodeToKeysymUlrich Sibiller2017-05-041-1/+4
| | | | | We need that function for performance reasons. By removing _X_DEPRECATED we get rid of compiler warnings.
* _XDefaultError: set XlibDisplayIOError flag before calling exitArthur Huillet2017-03-261-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | _XReply isn't reentrant, and it can lead to deadlocks when the default error handler is called: _XDefaultError calls exit(1). It is called indirectly by _XReply when a X protocol error comes in that isn't filtered/handled by an extension or the application. This means that if the application (or one of its loaded shared libraries such as the NVIDIA OpenGL driver) has registered any _fini destructor, _fini will get called while still on the call stack of _XReply. If the destructor interacts with the X server and calls _XReply, it will hit a deadlock, looping on the following in _XReply: ConditionWait(dpy, dpy->xcb->reply_notify); It is legal for an application to make Xlib calls during _fini, and that is useful for an OpenGL driver to avoid resource leaks on the X server side, for example in the dlopen/dlclose case. However, the driver can not readily tell whether its _fini is being called because Xlib called exit, or for another reason (dlclose), so it is hard to cleanly work around this issue in the driver. This change makes it so _XReply effectively becomes a no-op when called after _XDefaultError was called, as though an XIOError had happened. The dpy connection isn't broken at that point, but any call to _XReply is going to hang. This is a bit of a kludge, because the more correct solution would be to make _XReply reentrant, maybe by broadcasting the reply_notify condition before calling the default error handler. However, such a change would carry a grater risk of introducing regressions in Xlib. This change will drop some valid requests on the floor, but this should not matter, as it will only do so in the case where the application is dying: X will clean up after it once exit() is done running. There is the case of XSetCloseDownMode(RETAIN_PERMANENT), but an application using that and wishing to clean up resources in _fini would currently be hitting a deadlock, which is hardly a better situation. Signed-off-by: Aaron Plattner <aplattner@nvidia.com> Reviewed-by: Jamey Sharp <jamey@minilop.net>
* Fix wrong Xfree in XListFonts failure pathJulien Cristau2017-03-261-2/+4
| | | | | | | | | | | | 'ch' gets moved inside the allocated buffer as we're looping through fonts, so keep a reference to the start of the buffer so we can pass that to Xfree in the failure case. Fixes: commit 20a3f99eba5001925b8b313da3accb7900eb1927 "Plug a memory leak" Signed-off-by: Julien Cristau <jcristau@debian.org> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* libNX_X11: Fully drop loadable i18n module support in libNX_X11.Mike Gabriel2017-03-036-2340/+3
| | | | | | - Support for i18n in libNX_X11 is static only, has ever been. - Thus, the files XlcSL.[co], XlcDL.[co], XDefaultIMIF.[co], XDefaultOMIF.[co] and lcDynamic.[co] become obsolete.
* libNX_X11/lcUTF8.c: Drop not-used X11/lcUniConv/ascii.h.Mike Gabriel2017-03-032-28/+0
|
* doc/libNX_X11/lcUniConv: Move over the rather-documentary files ↵Mike Gabriel2017-03-032-1606/+0
| | | | 8bit_tab_to_h.c and cjk_tab_to_h.c to nx-libs's doc/ folder.
* drop platform support: unifdef sgi.Mike Gabriel2017-02-085-13/+2
| | | | Relates to ArcticaProject/nx-libs#275.
* drop platform support: unifdef QNX.Mike Gabriel2017-02-082-5/+1
| | | | Relates to ArcticaProject/nx-libs#275.
* drop platform support: unifdef __osf__.Mike Gabriel2017-02-082-7/+2
| | | | Fixes ArcticaProject/nx-libs#288.
* drop platform support: unifdef AIXV3, AIXV4 (and AIXrt, AIX386).Mike Gabriel2017-02-084-57/+4
| | | | Fixes ArcticaProject/nx-libs#274.
* drop platform support: unifdef hpux and __hppa__.Mike Gabriel2017-02-085-131/+6
| | | | Fixes ArcticaProject/nx-libs#273.