| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
|
|
|
|
| |
we currently do not support them but as they require a special
treatment we need to know them and report an error if they appear.
|
|
|
|
|
|
| |
Internal clients asking for the available targets for a selection will
no longer get a predefined list but a the list of targets from the
owning client on the real X server.
|
|
|
|
|
|
| |
Clients on the real X server requesting the available targets for a
selection will no longer get a predefined list but a the list of
targets from the owning internal client.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
... by providing NameFor(Int|Rem)Atom() macros
This way we do not have to validate it at various other places.
|
|
|
|
|
| |
This saves us from having to create intermediate strings and Xfreeing
them again. Which can easily be forgotten, producing memleaks.
|
|
|
|
| |
require less lines
|
| |
|
|
|
|
| |
read the value from the intSelAtoms array instead
|
|
|
|
|
| |
They really only change on startup and reconnect. Also with this change
we now only have internal Atoms in the LastSelectionOwner array.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
this allows better error messages
|
|
|
|
| |
we already have it at that stage
|
| |
|
| |
|
|
|
|
| |
Also improve Debug output.
|
|
|
|
| |
This will help in PRIMARY content appearing in CLIPBOARD and vice versa.
|
|
|
|
|
|
|
| |
- debug output was not printed at the beginning but later and
was therefore missing sometimes
- add comments/FIXMEs
- re-enable failure notification for second call
|
| |
|
|
|
|
|
|
| |
- remove redundant calls to nxagentFindLastSelectionOwnerIndex which reduce
indentation level
- scope improvements
|
| |
|
|
|
|
|
| |
This also unifies target handling to never use TEXT or COMPOUND_TEXT
(despite announcing it)
|
|
|
|
| |
This helps in avoiding storing the wrong value in a field.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
there are no negative times...
|
| |
|
| |
|
|
|
|
|
|
| |
if we get an unexpected property print that as an error. Before we saw
"unexpected stage" in that case which does not really help in
debugging...
|
| |
|
|
|
|
|
| |
marking all the code that is not really required when not using
nomachine's nxclient.
|
| |
|
| |
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#941
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In compext Atom has the size of XlibAtom. Therefore calling functions
of Compext.c requires to use/pass XlibAtom. Same for Window/XlibWindow.
==15438==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fffffffcdc0 at pc 0x5555556a81b5 bp 0x7fffffffcd10 sp 0x7fffffffcd08
WRITE of size 8 at 0x7fffffffcdc0 thread T0
#0 0x5555556a81b4 in NXGetCollectedProperty nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124
#1 0x5555557d0488 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1202
#2 0x555555723340 in nxagentHandleCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3923
#3 0x55555571d4db in nxagentHandleProxyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3007
#4 0x55555571bb92 in nxagentHandleClientMessageEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:2595
#5 0x555555717dfc in nxagentDispatchEvents nx-X11/programs/Xserver/hw/nxagent/Events.c:1827
#6 0x555555750813 in nxagentBlockHandler nx-X11/programs/Xserver/hw/nxagent/Handlers.c:437
#7 0x5555556c1b5d in BlockHandler nx-X11/programs/Xserver/dix/dixutils.c:403
#8 0x5555556d47ff in WaitForSomething nx-X11/programs/Xserver/os/WaitFor.c:232
#9 0x555555665b22 in Dispatch nx-X11/programs/Xserver/hw/nxagent/NXdispatch.c:365
#10 0x5555555ed760 in main nx-X11/programs/Xserver/dix/main.c:350
#11 0x7ffff604909a in __libc_start_main ../csu/libc-start.c:308
#12 0x5555555edc09 in _start (nx-X11/programs/Xserver/nxagent+0x99c09)
Address 0x7fffffffcdc0 is located in stack of thread T0 at offset 32 in frame
#0 0x5555557d0324 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1190
This frame has 5 object(s):
[32, 36) 'atomReturnType' <== Memory access at offset 32 partially overflows this variable
[96, 100) 'resultFormat'
[160, 168) 'ulReturnItems'
[224, 232) 'ulReturnBytesLeft'
[288, 296) 'pszReturnData'
HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
(longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-buffer-overflow nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124 in NXGetCollectedProperty
...
|
| |
|
| |
|
| |
|
| |
|