Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Clipboard.c: check pointer before usage | Ulrich Sibiller | 2020-01-05 | 1 | -1/+1 | |
| | | | | | The code also worked with pWindow being NULL but it did some unnecessary stuff. | |||||
* | Clipboard.c: drop superflous variable | Ulrich Sibiller | 2020-01-05 | 1 | -9/+7 | |
| | ||||||
* | Clipboard.c: split combined check | Ulrich Sibiller | 2020-01-05 | 1 | -16/+34 | |
| | | | | | | By splitting it up we can print appropriate debug messages. More important: The code tried to handle the special targets for all other cases where it should only deny the request. | |||||
* | Clipboard.c: more debugging output | Ulrich Sibiller | 2020-01-05 | 1 | -0/+4 | |
| | ||||||
* | Clipboard.c: add more explaining comments | Ulrich Sibiller | 2020-01-05 | 1 | -7/+24 | |
| | ||||||
* | Clipboard.c: use macros instead of hardcoced values for timeouts | Ulrich Sibiller | 2020-01-05 | 1 | -3/+14 | |
| | ||||||
* | Clipboard.c: fix timeout comparison | Ulrich Sibiller | 2020-01-05 | 1 | -2/+2 | |
| | | | | | We had comparisions for >5000 and <5000, but =5000 was not explicitly handled. In that case the code took an unexpected path. | |||||
* | Clipboard: make nxagentInitClipboard return a Boolean | Ulrich Sibiller | 2020-01-05 | 1 | -4/+8 | |
| | ||||||
* | Clipboard.c: avoid nested extern | Ulrich Sibiller | 2020-01-05 | 1 | -4/+4 | |
| | ||||||
* | Clipboard.c: fix string formatting directives | Ulrich Sibiller | 2020-01-05 | 1 | -2/+2 | |
| | ||||||
* | Clipboard.c: Fix formatting | Ulrich Sibiller | 2020-01-05 | 1 | -2/+2 | |
| | ||||||
* | Clipboard.c, NXproperty.c: match prototypes | Ulrich Sibiller | 2020-01-05 | 1 | -0/+5 | |
| | | | | | | The prototype for nxagentGetClipboardWindow has been changed in 63320437ed4e95246ce62193560098f986ac265c but the changes have not made it into NXproperty.c... | |||||
* | Clipboard.c: reformat some comments | Ulrich Sibiller | 2020-01-05 | 1 | -5/+3 | |
| | ||||||
* | Clipboard.c: add FIXMEs | Ulrich Sibiller | 2020-01-05 | 1 | -0/+3 | |
| | ||||||
* | Clipboard.c: add nxagentMatchSelectionOwner helper function | Ulrich Sibiller | 2020-01-05 | 1 | -2/+7 | |
| | ||||||
* | Clipboard.c: make agentClipboardStatus a Boolean | Ulrich Sibiller | 2020-01-05 | 1 | -14/+43 | |
| | | | | and add debugging information around its checks. | |||||
* | Clipboard.c: refactor nxagent*SelectionOwner | Ulrich Sibiller | 2020-01-05 | 1 | -28/+28 | |
| | | | | | | | expect an index instead of a pointer All calls referenced lastSelectionOwner so let the function directly use it and only pass the required index. | |||||
* | nxagent: Use XlibAtom data type where appropriate | Ulrich Sibiller | 2020-01-05 | 1 | -17/+16 | |
| | | | | | | | | XlibAtom should be used wherever remote atoms are handled. This is important as Xlib data types and server data types of the same name do not always have identical sizes. See also https://lists.freedesktop.org/archives/xorg-devel/2015-August/047245.html | |||||
* | Clipboard.c: report more supported targets | Ulrich Sibiller | 2019-11-15 | 1 | -3/+2 | |
| | | | | | fix one FIXME. This is a rewritten and extended version of a quick patch by Danil Pleshakov and Dimbor. | |||||
* | Clipboard: fix debugging output | Ulrich Sibiller | 2019-11-15 | 1 | -4/+10 | |
| | | | | Correctly determine the Atom names from the real X server. | |||||
* | Clipboard.c: automatically calc the array size | Ulrich Sibiller | 2019-11-15 | 1 | -2/+2 | |
| | ||||||
* | Clipboard.c: improve XChangeProperty code | Ulrich Sibiller | 2019-11-15 | 1 | -2/+2 | |
| | | | | | | | | | | The previously used "Atom" type was confusing. Clarify this by writing the code as requested in the manpage of XChangeProperty: "If the specified format is 8, the property data must be a char array. If the specified format is 16, the property data must be a short array. If the specified format is 32, the property data must be a long array." | |||||
* | Clipboard.c: rename nxagentNotifySelection to ↵ | Ulrich Sibiller | 2019-09-29 | 1 | -4/+5 | |
| | | | | | | nxagentHandleSelectionNotifyFromXServer Use a more descriptive name. | |||||
* | Clipboard.c: fix nested clipboard handling | Ulrich Sibiller | 2019-09-29 | 1 | -1/+8 | |
| | | | | Fixes ArcticaProject/nx-libs#632 | |||||
* | Clipboard.c: add some more FIXMEs | Ulrich Sibiller | 2019-09-29 | 1 | -0/+20 | |
| | ||||||
* | Clipboard.c: drop old commented code | Ulrich Sibiller | 2019-09-29 | 1 | -16/+0 | |
| | ||||||
* | Clipboard.c: fix: translate target on transfer | Ulrich Sibiller | 2019-09-29 | 1 | -0/+23 | |
| | ||||||
* | Clipboard.c: flush the display during transfer phase | Ulrich Sibiller | 2019-09-29 | 1 | -0/+6 | |
| | | | | This avoids delays, timeouts and missing copy/paste actions. | |||||
* | Clipboard.c: remove superflous return | Ulrich Sibiller | 2019-09-29 | 1 | -2/+0 | |
| | ||||||
* | Clipboard.c: drop unneeded return code | Ulrich Sibiller | 2019-09-29 | 1 | -8/+10 | |
| | ||||||
* | Clipboard.c: add loads of comments | Ulrich Sibiller | 2019-09-29 | 1 | -32/+195 | |
| | ||||||
* | Clipboard.c: rework debug prints | Ulrich Sibiller | 2019-09-29 | 1 | -57/+167 | |
| | | | | add new debug output, extend existing, drop meaningless | |||||
* | Clipboard.c: translate internal to external atom | Ulrich Sibiller | 2019-09-29 | 1 | -4/+20 | |
| | | | | | | | | serverClientCutProperty is the external equivalent of the internal clientCutProperty. We need it on the server side, too, because we use the property on the serverWindow on the real X server. We could (mis)use serverCutProperty here but this might introduce race conditions when both sides request selections simultaneously. | |||||
* | Clipboard.c: remove unneccessary return | Ulrich Sibiller | 2019-09-29 | 1 | -2/+0 | |
| | ||||||
* | Clipboard.c: whitespace fixes | Ulrich Sibiller | 2019-09-29 | 1 | -14/+14 | |
| | ||||||
* | Clipboard.c: improve readability by using an if clause | Ulrich Sibiller | 2019-09-29 | 1 | -2/+3 | |
| | ||||||
* | Clipboard.c: introduce nxagentInitSelectionOwner | Ulrich Sibiller | 2019-09-29 | 1 | -11/+11 | |
| | ||||||
* | Clipboard.c: scope improvements | Ulrich Sibiller | 2019-09-29 | 1 | -11/+8 | |
| | ||||||
* | Clipboard.c: Refactor nxagentCollectPropertyEvent | Ulrich Sibiller | 2019-09-29 | 1 | -83/+77 | |
| | ||||||
* | Clipboard.c: cleanup in nxagentRequestSelection | Ulrich Sibiller | 2019-09-29 | 1 | -16/+13 | |
| | ||||||
* | Clipboard.c: use designated initializers where appropriate | Ulrich Sibiller | 2019-09-29 | 1 | -41/+24 | |
| | ||||||
* | Clipboard.c: factor out nxagentReplyRequestSelection | Ulrich Sibiller | 2019-09-29 | 1 | -27/+38 | |
| | ||||||
* | Clipboard.c: TIMESTAMP is a special server target | Ulrich Sibiller | 2019-09-29 | 1 | -0/+7 | |
| | | | | | This is not a functional change, it only helps in clearer debugging output. | |||||
* | Clipboard.c: introduce macros CLINDEX and WINDOWID | Ulrich Sibiller | 2019-09-29 | 1 | -22/+24 | |
| | ||||||
* | Clipboard.c: simplify nxagentGetClipboardWindow | Ulrich Sibiller | 2019-09-29 | 1 | -12/+3 | |
| | | | | | | | The second parameter was always NULL, so remove it. Also remove some debugging output which distracts while debugging as the function is called from ProcChangeProperty for _every_ property, also non-clipboard related ones. | |||||
* | Clipboard.c: drop serverCLIPBOARD | Ulrich Sibiller | 2019-09-29 | 1 | -5/+1 | |
| | | | | we reference lastSelectionOwner[nxagentClipboardSelection].selection everywhere. | |||||
* | Clipboard.c: clientAccum is only used for debugging, add DEBUG ifdefs | Ulrich Sibiller | 2019-09-29 | 1 | -5/+7 | |
| | ||||||
* | Clipboard.c: rename some variables | Ulrich Sibiller | 2019-09-29 | 1 | -10/+10 | |
| | | | | | | | nxagentClipboardAtom -> serverCLIPBOARD nxagentTimestampAtom -> serverTIMESTAMP This is to match the names of the other server atom variables. | |||||
* | Clipboard.c: introduce nxagentFind*Index functions | Ulrich Sibiller | 2019-09-29 | 1 | -39/+30 | |
| | | | | | At some places we were using NumCurrentSelections. We replace that by nxagentMaxSelections because they always have the identical value. | |||||
* | Clipboard.c: introduce nxagent{Clear,Store}SelectionOwner | Ulrich Sibiller | 2019-09-29 | 1 | -13/+22 | |
| |