| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
There's no need/sense in having a tri-state with the third state being
UNDEFINED.
|
|
|
|
| |
causing DEBUG output in regular builds.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
This only happened with certain window managers like mutter.
Fixes ArcticaProject/nx-libs#925
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In compext Atom has the size of XlibAtom. Therefore calling functions
of Compext.c requires to use/pass XlibAtom. Same for Window/XlibWindow.
==15438==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fffffffcdc0 at pc 0x5555556a81b5 bp 0x7fffffffcd10 sp 0x7fffffffcd08
WRITE of size 8 at 0x7fffffffcdc0 thread T0
#0 0x5555556a81b4 in NXGetCollectedProperty nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124
#1 0x5555557d0488 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1202
#2 0x555555723340 in nxagentHandleCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3923
#3 0x55555571d4db in nxagentHandleProxyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3007
#4 0x55555571bb92 in nxagentHandleClientMessageEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:2595
#5 0x555555717dfc in nxagentDispatchEvents nx-X11/programs/Xserver/hw/nxagent/Events.c:1827
#6 0x555555750813 in nxagentBlockHandler nx-X11/programs/Xserver/hw/nxagent/Handlers.c:437
#7 0x5555556c1b5d in BlockHandler nx-X11/programs/Xserver/dix/dixutils.c:403
#8 0x5555556d47ff in WaitForSomething nx-X11/programs/Xserver/os/WaitFor.c:232
#9 0x555555665b22 in Dispatch nx-X11/programs/Xserver/hw/nxagent/NXdispatch.c:365
#10 0x5555555ed760 in main nx-X11/programs/Xserver/dix/main.c:350
#11 0x7ffff604909a in __libc_start_main ../csu/libc-start.c:308
#12 0x5555555edc09 in _start (nx-X11/programs/Xserver/nxagent+0x99c09)
Address 0x7fffffffcdc0 is located in stack of thread T0 at offset 32 in frame
#0 0x5555557d0324 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1190
This frame has 5 object(s):
[32, 36) 'atomReturnType' <== Memory access at offset 32 partially overflows this variable
[96, 100) 'resultFormat'
[160, 168) 'ulReturnItems'
[224, 232) 'ulReturnBytesLeft'
[288, 296) 'pszReturnData'
HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
(longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-buffer-overflow nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124 in NXGetCollectedProperty
...
|
| |
|
| |
|
|
|
|
| |
to make them all fit in the same naming scheme that better describes their purpose.
|
|
|
|
| |
and use True/False instead of 1/0
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
This was removed by mistake in 39866f5c133230e5731156c2356c8571c971534c.
Fixes ArcticaProject/nx-libs#904
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Events.c: In function ‘nxagentDispatchEvents’:
Events.c:1241:21: warning: declaration of ‘pScreen’ shadows a previous local [-Wshadow=compatible-local]
ScreenPtr pScreen = nxagentScreen(X.xbutton.window);
^~~~~~~
Events.c:827:13: note: shadowed declaration is here
ScreenPtr pScreen = NULL;
^~~~~~~
Events.c:1383:19: warning: declaration of ‘pScreen’ shadows a previous local [-Wshadow=compatible-local]
ScreenPtr pScreen = nxagentScreen(X.xmotion.window);
^~~~~~~
Events.c:827:13: note: shadowed declaration is here
ScreenPtr pScreen = NULL;
^~~~~~~
Events.c: In function ‘nxagentDispatchEvents’:
Events.c:1383:19: warning: declaration of ‘pScreen’ shadows a previous local [-Wshadow=compatible-local]
ScreenPtr pScreen = nxagentScreen(X.xmotion.window);
^~~~~~~
Events.c:827:13: note: shadowed declaration is here
ScreenPtr pScreen = NULL;
^~~~~~~
|
| |
|
|
|
|
|
|
|
| |
Extend nxagentHandleClientMessageEvent: better debug messages,
suppress warning "Invalid window in ClientMessage" for legal case.
I came across this while testing some clipboard stuff.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
save some lines
|
|
|
|
| |
save some lines
|
|
|
|
|
|
| |
nxagentHandleSelectionNotifyFromXServer
Use a more descriptive name.
|
|
|
|
|
| |
At some places we were using NumCurrentSelections. We replace that by
nxagentMaxSelections because they always have the identical value.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
XGetWMName returns non-zero on success
The result was that no window names were displayed in DEBUG_TREE remote windows
tree output.
|
|
|
|
| |
scope improvements, use fprintf for indentation instead of loops.
|
| |
|
|
|
|
| |
so hide it behind that define
|
|
|
|
| |
We should do something similar for all subsystems over time...
|
|
|
|
|
| |
Especially switchin to/from fullscreen with active AutoGrab was
problematic. Works much smoother now.
|
| |
|
|
|
|
| |
This also make re-autograbbing after switch back from AllScreens work.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
You can now toggle between autograb mode by pressing CTRL-ALT-G
(default, can be adjusted in keystrokes.cfg).
Fixes ArcticaProject/nx-libs#384.
|
|
|
|
|
|
|
|
| |
We either use a solid black or a white background and no backround
pixmap. So nxagentRootTileWindow is always empty and we can drop all
stuff around it.
remove nxagentSplashCount, too, since it is no longer checked anywhere.
|
|
|
|
|
| |
no more need to pass down a struct, we now only pass the milliseconds
and let the function do the rest.
|