aboutsummaryrefslogtreecommitdiff
path: root/nx-X11/programs/Xserver/hw/nxagent/Events.c
Commit message (Collapse)AuthorAgeFilesLines
* nxagent: handle RegionNil macro as BooleanUlrich Sibiller2021-01-151-1/+1
| | | | just as the rest of the Xserver is alsow doing
* nxagent: rework some Boolean checksUlrich Sibiller2021-01-151-2/+2
| | | | | nxagentWindowTopLevel() and nxagentNeedConnectionChange() return Boolean nxagentPixmapIsVirtual() and nxagentIsShmPixmap(), too.
* nxagent: make nxagentShadowResize a BooleanUlrich Sibiller2021-01-151-1/+1
|
* nxagent: make nxagentVerbose a BooleanUlrich Sibiller2021-01-151-1/+1
|
* nxagent: make Desktop, Rootless and Binder options Booleans (again)Ulrich Sibiller2021-01-151-6/+6
| | | | | They have been changed to tri-state variables (1, 0 and UNDEFINED) between nxagent 1.5.0-90 and -93, for no obvious reason.
* nxagent: make nxagentOption Shadow a BooleanUlrich Sibiller2021-01-151-7/+7
| | | | and add the missing init code.
* nxagent: treat several nxagentOptions as real BooleansUlrich Sibiller2021-01-151-9/+9
| | | | | | | Adaptive, Composite, DeviceControl, DeviceControlUserDefined, IgnoreVisibility, InhibitXkb, Nested, Menu, MagicPixel, Persistent, Reset, ResetzKeyboardAtResume, SharedMemory, SharedPixmaps, Streaming, UseDamage, ViewOnly, Xdmcp, Xinerama
* nxagent: treat DesktopResize and nxagentResizeDesktopAtStartup as BooleansUlrich Sibiller2021-01-151-5/+5
| | | | The already where Booleans but where not using True/False values everywhere
* nxagent: make Fullscreen and AllScreens BooleansUlrich Sibiller2021-01-151-9/+9
| | | | | There's no need/sense in having a tri-state with the third state being UNDEFINED.
* Events.c: fix leftover DEBUG and TEST definitionsUlrich Sibiller2020-12-031-4/+1
| | | | causing DEBUG output in regular builds.
* Events.c: scope improvementUlrich Sibiller2020-11-031-2/+2
|
* Events.c: More cosmeticsUlrich Sibiller2020-10-171-7/+9
|
* Events.c: store parent window from event to meaningful variableUlrich Sibiller2020-10-171-9/+7
|
* Events.c: add some comments/FIXMEsUlrich Sibiller2020-10-171-2/+3
|
* Events.c: add more DEBUG outputUlrich Sibiller2020-10-171-11/+78
|
* nxagent: Prevent resize loopUlrich Sibiller2020-10-171-6/+13
| | | | | | This only happened with certain window managers like mutter. Fixes ArcticaProject/nx-libs#925
* nxagent: fix stack smashingUlrich Sibiller2020-10-171-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In compext Atom has the size of XlibAtom. Therefore calling functions of Compext.c requires to use/pass XlibAtom. Same for Window/XlibWindow. ==15438==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fffffffcdc0 at pc 0x5555556a81b5 bp 0x7fffffffcd10 sp 0x7fffffffcd08 WRITE of size 8 at 0x7fffffffcdc0 thread T0 #0 0x5555556a81b4 in NXGetCollectedProperty nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124 #1 0x5555557d0488 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1202 #2 0x555555723340 in nxagentHandleCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3923 #3 0x55555571d4db in nxagentHandleProxyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3007 #4 0x55555571bb92 in nxagentHandleClientMessageEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:2595 #5 0x555555717dfc in nxagentDispatchEvents nx-X11/programs/Xserver/hw/nxagent/Events.c:1827 #6 0x555555750813 in nxagentBlockHandler nx-X11/programs/Xserver/hw/nxagent/Handlers.c:437 #7 0x5555556c1b5d in BlockHandler nx-X11/programs/Xserver/dix/dixutils.c:403 #8 0x5555556d47ff in WaitForSomething nx-X11/programs/Xserver/os/WaitFor.c:232 #9 0x555555665b22 in Dispatch nx-X11/programs/Xserver/hw/nxagent/NXdispatch.c:365 #10 0x5555555ed760 in main nx-X11/programs/Xserver/dix/main.c:350 #11 0x7ffff604909a in __libc_start_main ../csu/libc-start.c:308 #12 0x5555555edc09 in _start (nx-X11/programs/Xserver/nxagent+0x99c09) Address 0x7fffffffcdc0 is located in stack of thread T0 at offset 32 in frame #0 0x5555557d0324 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1190 This frame has 5 object(s): [32, 36) 'atomReturnType' <== Memory access at offset 32 partially overflows this variable [96, 100) 'resultFormat' [160, 168) 'ulReturnItems' [224, 232) 'ulReturnBytesLeft' [288, 296) 'pszReturnData' HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124 in NXGetCollectedProperty ...
* nxagent: Add keystroke for dumping the current clipboard stateUlrich Sibiller2020-05-311-0/+5
|
* Improve clipboard/xfixes related debug outputUlrich Sibiller2020-05-071-1/+1
|
* Clipboard.c: rename some exported functionsUlrich Sibiller2020-05-071-2/+2
| | | | to make them all fit in the same naming scheme that better describes their purpose.
* nxagent: make all traps BooleansUlrich Sibiller2020-05-071-18/+18
| | | | and use True/False instead of 1/0
* Events.c: simplify nxagentInternalWindowsTreeUlrich Sibiller2020-05-071-6/+2
|
* Events.c: Whitespace fixUlrich Sibiller2020-05-071-1/+1
|
* nxagent: rename variables that shadow globalsUlrich Sibiller2020-01-251-5/+5
|
* Events.c: fix capslock weirdness (re-add lost code)Ulrich Sibiller2020-01-251-0/+1
| | | | | | This was removed by mistake in 39866f5c133230e5731156c2356c8571c971534c. Fixes ArcticaProject/nx-libs#904
* Events.c: fix two shadowed variablesUlrich Sibiller2020-01-091-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Events.c: In function ‘nxagentDispatchEvents’: Events.c:1241:21: warning: declaration of ‘pScreen’ shadows a previous local [-Wshadow=compatible-local] ScreenPtr pScreen = nxagentScreen(X.xbutton.window); ^~~~~~~ Events.c:827:13: note: shadowed declaration is here ScreenPtr pScreen = NULL; ^~~~~~~ Events.c:1383:19: warning: declaration of ‘pScreen’ shadows a previous local [-Wshadow=compatible-local] ScreenPtr pScreen = nxagentScreen(X.xmotion.window); ^~~~~~~ Events.c:827:13: note: shadowed declaration is here ScreenPtr pScreen = NULL; ^~~~~~~ Events.c: In function ‘nxagentDispatchEvents’: Events.c:1383:19: warning: declaration of ‘pScreen’ shadows a previous local [-Wshadow=compatible-local] ScreenPtr pScreen = nxagentScreen(X.xmotion.window); ^~~~~~~ Events.c:827:13: note: shadowed declaration is here ScreenPtr pScreen = NULL; ^~~~~~~
* Events.c: pass a Boolean to nxagentSwitchFullscreenUlrich Sibiller2020-01-061-1/+1
|
* Events.c: improve debugging outputUlrich Sibiller2020-01-061-7/+25
| | | | | | | Extend nxagentHandleClientMessageEvent: better debug messages, suppress warning "Invalid window in ClientMessage" for legal case. I came across this while testing some clipboard stuff.
* Events.c: fix format specifiersUlrich Sibiller2020-01-051-5/+5
|
* Event.c: use __func__ in fprintfUlrich Sibiller2020-01-051-170/+144
|
* Events.c: use designated initializersUlrich Sibiller2020-01-051-22/+15
|
* Events.c: Scope improvements/code simplificationUlrich Sibiller2020-01-051-147/+83
|
* Events.c: reformat switch blocksUlrich Sibiller2020-01-051-64/+17
| | | | save some lines
* Events.c: reformat commentsUlrich Sibiller2020-01-051-148/+109
| | | | save some lines
* Clipboard.c: rename nxagentNotifySelection to ↵Ulrich Sibiller2019-09-291-1/+1
| | | | | | nxagentHandleSelectionNotifyFromXServer Use a more descriptive name.
* Clipboard.c: introduce nxagentFind*Index functionsUlrich Sibiller2019-09-291-6/+1
| | | | | At some places we were using NumCurrentSelections. We replace that by nxagentMaxSelections because they always have the identical value.
* Events.c: drop unused functionUlrich Sibiller2019-09-291-5/+0
|
* Events.c: add nxagentSwitchEventsAllScreens helperUlrich Sibiller2019-09-291-35/+19
|
* Events.c: whitespace fixesUlrich Sibiller2019-09-291-28/+28
|
* Events.c: scope improvementsUlrich Sibiller2019-09-291-11/+5
|
* Events.c: code improvements (mainly scope)Ulrich Sibiller2019-09-291-75/+41
|
* Events.c: fix wrong size in format specificationUlrich Sibiller2019-09-291-1/+1
|
* Events.c: identify internal root window in nxagentInternalWindowInfoUlrich Sibiller2019-09-291-2/+2
|
* Events.c: add FIXMEUlrich Sibiller2019-09-291-0/+13
|
* Events.c: fix wrong returncode interpretationUlrich Sibiller2019-09-291-1/+1
| | | | | | | XGetWMName returns non-zero on success The result was that no window names were displayed in DEBUG_TREE remote windows tree output.
* Events.c: shorten window tree debugging codeUlrich Sibiller2019-09-291-39/+10
| | | | scope improvements, use fprintf for indentation instead of loops.
* Events.c: fix write after buffer endUlrich Sibiller2019-09-291-3/+1
|
* Events.c: nxagentInternalWindowInfo is only called with DEBUG_TREEUlrich Sibiller2019-09-291-2/+0
| | | | so hide it behind that define
* Events.c: introduce separate debug level for autograb debugging onlyUlrich Sibiller2019-08-271-7/+16
| | | | We should do something similar for all subsystems over time...
* Make AutoGrab work in more situationsUlrich Sibiller2019-08-271-1/+1
| | | | | Especially switchin to/from fullscreen with active AutoGrab was problematic. Works much smoother now.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-11 22:41:37 +0000