| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
keyboard config file for nxagent/x2goagent was broken from the moment
it got implemented. nxagentXkbConfigFilePath had never been filled.
|
| |
|
| |
|
|
|
|
| |
just as Xorg upstream did
|
|
|
|
|
|
| |
of X.org and XFree86.
Fixes ArcticaProject/nx-libs#250.
|
|
|
|
|
|
| |
Window.c: In function ‘nxagentFrameBufferPaintWindow’:
Window.c:1968:31: warning: ISO C forbids assignment between function pointer and ‘void *’ [-Wpedantic]
PaintWindowBackgroundBackup = pWin->drawable.pScreen -> PaintWindowBackground;
|
|
|
|
|
|
|
| |
Display.c: In function ‘nxagentCheckForPixmapFormatsCompatibility’:
Display.c:2471:8: warning: variable ‘one_match’ set but not used [-Wunused-but-set-variable]
bool one_match = false;
^
|
|
|
|
|
|
|
| |
Colormap.c: In function ‘nxagentSetInstalledColormapWindows’:
Colormap.c:314:27: warning: format ‘%p’ expects argument of type ‘void *’, but argument 3 has type ‘WindowPtr’ [-Wformat=]
pWin, pWin -> drawable.class);
^
|
|
|
|
| |
warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 5 has type ‘long int’ [-Wformat=]
|
| |
|
|
|
|
|
| |
This basically repeats commit bad67799229b94ea2ba0174319949766ad1c2fc6
after the upgrade to libX11 1.3.4.
|
|
|
|
| |
just as upstream did
|
|
|
|
| |
just like upstream does
|
|
|
|
| |
just like upstream does
|
|
|
|
| |
header file, so that it only contains the XRRScreenChangeNotifyEvent typedef.
|
|
|
|
|
|
|
| |
This fixes ArcticaProject/nx-libs#204.
However, this fix does not address the root of the problem, it simply avoids
it. We could run into it again... See bugreport for an explanation.
|
|
|
|
|
|
|
| |
After commit cbf3ef0f219a7d5c94a7f5d5b46c9a0e26cc6588 this no longer
necessary.
This reverts commit 9a4bb50af54ced8d53112b8fa3b5b9dc3b481224.
|
|
|
|
| |
information as display by nxagent.
|
| |
|
|
|
|
| |
expected selections of values.
|
|
|
|
| |
reconnectchecks parameter value is explained.
|
| |
|
|
|
|
| |
instead of =none.
|
|
|
|
|
|
| |
nxagentCheckForColormapsCompatibility().
Maybe needs special strictness handling as well.
|
|
|
|
|
|
| |
nxagentInitAndCheckVisuals().
Maybe needs special strictness handling as well.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nxagentCheckForPixmapFormatsCompatibility() and nxagentInitPixmapFormats().
Don't implicitly call the checking function in the init function (and throw
away the checking functions result...)
Instead, explicitly use the checking function after the init function in other
parts of the code and throw away the checking functions return value
selectively or actually use it while reconnecting.
This is totally different behavior compared to the original one. Hopefully it
doesn't cause any problems (i.e., hopefully there was no good reason for never
using the checking functions return value, but an oversight.)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nxagentOption value in nxagentCheckForPixmapFormatsCompatibility() and modify behavior based on this value.
Recognized values:
- Strict means that the number of internal and
external pixmap formats must match exactly and
every internal pixmap format must be available
in the external pixmap format array.
- Safe means that the number of pixmap formats might
diverge, but all internal pixmap formats must
also be included in the external pixmap formats
array. This is recommended, because it allows
clients with more pixmap formats to still connect,
but not lose functionality.
- Risky means that the internal pixmap formats array
is allowed to be smaller than the external pixmap
formats array, but at least one pixmap format must
be included in both. This is potentially unsafe.
- Bypass or higher means that all of these checks are
essentially deactivated. This is a very bad idea.
Note that the default ReconnectTolerance value is still Strict.
Also, the return value of this function is currently not used or passed through
to other functions at all. An upcoming commit will change this behavior and
actually enable the checks.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nxagentOption value in nxagentCheckForDepthsCompatibility() and modify behavior based on this value.
Recognized values:
- Strict means that the number of old and new depths must
match exactly and every old depth value must be
available in the new depth array.
- Safe means that the number of depths might diverge,
but all former depth must also be included in the
new depth array. This is recommended, because
it allows clients with more depths to still
connect, but not lose functionality.
- Risky means that the new depths array is allowed to be
smaller than the old depths array, but at least
one depth value must be included in both.
This is potentially unsafe.
- Bypass or higher means that all of these checks are
essentially deactivated. This is a very bad idea.
Note that the default ReconnectTolerance value is still Strict.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nxagentOption in nxagentCheckForDefaultDepthCompatibility() and modify behavior based on this value.
Recognized values:
- Strict means that the old and new default depth values
must match exactly.
- Safe or Risky means that the default depth values
might differ, but the new default depth value must be at
least as high as the former default depth value. This is
recommended, because it allows clients with a
higher default depth value to still connect, but
not lose functionality.
- Bypass or higher means that all of these checks are
essentially deactivated. This is probably a very
bad idea.
Note that the default ReconnectTolerance value is still Strict.
|
|
|
|
| |
}.cpp}: add tolerancechecks parameter as an nx/nx option and ReconnectTolerance as an nxagentOption.
|
| |
|
|
|
|
|
| |
This has already been started while replacing copyright info in file
headers and has now been completed with this commit.
|
|
|
|
| |
that NoMachine placed there own copyright statement in.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove defines of NEED_EVENTS and NEED_REPLIES because they are never
used anywhere.
Basically these three commits, but as they are newer and to not match
the code structure the patches have not been applied but replaced by
sed + manual intervention:
From cb95642dc8edebb2935dd471f8b339cb98aa8481 Mon Sep 17 00:00:00 2001
From: Peter Hutterer <peter.hutterer@redhat.com>
Date: Fri, 28 Nov 2008 22:28:32 +1000
Subject: Remove #define NEED_EVENTS and NEED_REPLIES
A grep on xorg/* revealed there's no consumer of this define.
Quote Alan Coopersmith:
"The consumer was in past versions of the headers now located
in proto/x11proto - for instance, in X11R6.0's xc/include/Xproto.h,
all the event definitions were only available if NEED_EVENTS were
defined, and all the reply definitions required NEED_REPLIES.
Looks like Xproto.h dropped them by X11R6.3, which didn't have
the #ifdef's anymore, so these are truly ancient now."
Signed-off-by: Peter Hutterer <peter.hutterer@redhat.com>
Signed-off-by: Adam Jackson <ajax@redhat.com>
--
From 6de368c9aa7ccd2fcd62fca5a2b278913db4d03d Mon Sep 17 00:00:00 2001
From: Fernando Carrijo <fcarrijo@yahoo.com.br>
Date: Thu, 1 Jul 2010 06:50:47 -0300
Subject: Purge macros NEED_EVENTS and NEED_REPLIES
Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br>
Acked-by: Tiago Vignatti <tiago.vignatti@nokia.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
--
From 57c03e52e6b4e3ed54df5fdd778865467d08e119 Mon Sep 17 00:00:00 2001
From: Fernando Carrijo <fcarrijo@yahoo.com.br>
Date: Thu, 1 Jul 2010 06:59:48 -0300
Subject: Purge macro NEED_EVENTS
Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br>
Acked-by: Tiago Vignatti <tiago.vignatti@nokia.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Casting return to (void) was used to tell lint that you intended
to ignore the return value, so it didn't warn you about it.
Casting the third argument to (char *) was used as the most generic
pointer type in the days before compilers supported C89 (void *)
(except for a couple places it's used for byte-sized pointer math).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
Tested-by: Daniel Stone <daniel@fooishbar.org>
Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
|
| |
|
|
|
|
| |
nowadays.
|
| |
|
|
|
|
|
|
| |
base folder.
Drop other LICENSE files added by NoMachine scattered all over the code tree.
|
|
|
|
| |
One COPYING file in the project's base folder is sufficient.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
INITARGS was a hardcoded define to void. Since knowing the function
signature for your extensions is kinda useful, just replace it with a
hardcoded void, but leave the define there for API compatibility.
Signed-off-by: Tomas Carnecky <tom@dbservice.com>
Reviewed-by: Daniel Stone <daniel@fooishbar.org>
Reviewed-by: Cyril Brulebois <kibi@debian.org>
Reviewed-by: Jamey Sharp <jamey@minilop.net>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Keith Packard <keithp@keithp.com>
Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
|
|
|
|
| |
hook functions to NULL.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(introducing wrong_size check at build time).
While working on this changeset, various spots got discovered where
swapl or swaps was used on a wrong type, where byte swapping calls had
been forgotten or done on the wrong variable.
This backport at least includes changes from the following X.org
commits, listed in non-chronological order:
commit 2c7c520cfe0df30f4bc3adba59d9c62582823bf8
Author: Matt Turner <mattst88@gmail.com>
Date: Thu Aug 4 15:35:41 2011 -0400
Use internal temp variable for swap macros
Also, fix whitespace, mainly around
swaps(&rep.sequenceNumber)
Reviewed-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
commit 9edcae78c46286baff42e74bfe26f6ae4d00fe01
Author: Matt Turner <mattst88@gmail.com>
Date: Wed Sep 21 17:14:16 2011 -0400
Use correct swap{l,s} (or none at all for CARD8)
Swapping the wrong size was never caught because swap{l,s} are macros.
It's clear in the case of Xext/xres.c, that the author believed
client_major/minor to be CARD16 from looking at the code in the first
hunk.
v2: dmx.c fixes from Keith.
Reviewed-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
commit dab064fa5e0b1f5c67222562ad5367005832cba1
Author: Andrea Canciani <ranma42@gmail.com>
Date: Tue Nov 2 20:10:32 2010 +0100
render: Fix byteswapping of gradient stops
The function swapStops repeatedly swaps the color components as
CARD16, but incorrectly steps over them as if they were CARD32.
This causes half of the stops not to be swapped at all and some
unrelated data be swapped instead.
Signed-off-by: Andrea Canciani <ranma42@gmail.com>
Reviewed-by: Soren Sandmann <sandmann@daimi.au.dk>
Reviewed-by: Julien Cristau <jcristau@debian.org>
Signed-off-by: Keith Packard <keithp@keithp.com>
commit 54770c980cd2b91a8377f975a58ed69def5cfa42
Author: Matt Turner <mattst88@gmail.com>
Date: Tue Aug 16 16:59:07 2011 -0400
Cast char* buffers to swap functions
Reviewed-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
commit 6844bd2e63490870bab3c469eec6030354ef2865
Author: Alan Coopersmith <alan.coopersmith@sun.com>
Date: Wed Jan 9 19:52:00 2008 -0800
More Xv extension byte swapping fixes
commit e46f6ddeccd082b2d507a1e8b57ea30e6b0a2c83
Author: Michel Dänzer <michel@tungstengraphics.com>
Date: Wed Jan 16 14:24:22 2008 +0100
Yet another Xv extension byte swapping fix.
|
| |
|
| |
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#105
|
|
|
|
| |
header file containing all use protocol versions.
|
| |
|