Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Clipboard.c: Fix: re-claim selection on reconnect | Ulrich Sibiller | 2020-01-05 | 1 | -20/+28 | |
| | | | | | | | On reconnect claim the selection ownership if one of nxagent's clients is a selection owner. The code for this was already there but could not work because the lastSelectionOwner array was always dropped at the beginning of nxagentInitClipboard. | |||||
* | Clipboard.c: reorder atom allocation code | Ulrich Sibiller | 2020-01-05 | 1 | -10/+10 | |
| | | | | | Place the allocation directly before the check for success. Use the same order for server and client atoms. | |||||
* | Clipboard: align reported targets | Ulrich Sibiller | 2020-01-05 | 3 | -13/+26 | |
| | | | | | Always report the same list of available targets to internal and external requests. | |||||
* | Clipboard.c: check pointer before usage | Ulrich Sibiller | 2020-01-05 | 1 | -1/+1 | |
| | | | | | The code also worked with pWindow being NULL but it did some unnecessary stuff. | |||||
* | Clipboard.c: drop superflous variable | Ulrich Sibiller | 2020-01-05 | 1 | -9/+7 | |
| | ||||||
* | Clipboard.c: split combined check | Ulrich Sibiller | 2020-01-05 | 1 | -16/+34 | |
| | | | | | | By splitting it up we can print appropriate debug messages. More important: The code tried to handle the special targets for all other cases where it should only deny the request. | |||||
* | Clipboard.c: more debugging output | Ulrich Sibiller | 2020-01-05 | 1 | -0/+4 | |
| | ||||||
* | Clipboard.c: add more explaining comments | Ulrich Sibiller | 2020-01-05 | 1 | -7/+24 | |
| | ||||||
* | Clipboard.c: use macros instead of hardcoced values for timeouts | Ulrich Sibiller | 2020-01-05 | 1 | -3/+14 | |
| | ||||||
* | Clipboard.c: fix timeout comparison | Ulrich Sibiller | 2020-01-05 | 1 | -2/+2 | |
| | | | | | We had comparisions for >5000 and <5000, but =5000 was not explicitly handled. In that case the code took an unexpected path. | |||||
* | Clipboard: make nxagentInitClipboard return a Boolean | Ulrich Sibiller | 2020-01-05 | 3 | -6/+10 | |
| | ||||||
* | Clipboard.c: avoid nested extern | Ulrich Sibiller | 2020-01-05 | 1 | -4/+4 | |
| | ||||||
* | Clipboard.c: fix string formatting directives | Ulrich Sibiller | 2020-01-05 | 1 | -2/+2 | |
| | ||||||
* | Clipboard.c: Fix formatting | Ulrich Sibiller | 2020-01-05 | 1 | -2/+2 | |
| | ||||||
* | Clipboard.c, NXproperty.c: match prototypes | Ulrich Sibiller | 2020-01-05 | 2 | -2/+7 | |
| | | | | | | The prototype for nxagentGetClipboardWindow has been changed in 63320437ed4e95246ce62193560098f986ac265c but the changes have not made it into NXproperty.c... | |||||
* | Clipboard.c: reformat some comments | Ulrich Sibiller | 2020-01-05 | 1 | -5/+3 | |
| | ||||||
* | Clipboard.c: add FIXMEs | Ulrich Sibiller | 2020-01-05 | 1 | -0/+3 | |
| | ||||||
* | Clipboard.c: add nxagentMatchSelectionOwner helper function | Ulrich Sibiller | 2020-01-05 | 1 | -2/+7 | |
| | ||||||
* | Clipboard.c: make agentClipboardStatus a Boolean | Ulrich Sibiller | 2020-01-05 | 1 | -14/+43 | |
| | | | | and add debugging information around its checks. | |||||
* | Clipboard.c: refactor nxagent*SelectionOwner | Ulrich Sibiller | 2020-01-05 | 1 | -28/+28 | |
| | | | | | | | expect an index instead of a pointer All calls referenced lastSelectionOwner so let the function directly use it and only pass the required index. | |||||
* | Error.c: simplify some NULL pointer checks | Ulrich Sibiller | 2020-01-05 | 1 | -4/+4 | |
| | ||||||
* | Error.c: drop now obsolete DEFAULT_STRING_LENGTH | Ulrich Sibiller | 2020-01-05 | 1 | -3/+0 | |
| | ||||||
* | Error.c: make nxagentRootDir a pointer | Ulrich Sibiller | 2020-01-05 | 1 | -37/+22 | |
| | | | | no more hardcoded string length | |||||
* | Error.c: make nxagentHomeDir a pointer | Ulrich Sibiller | 2020-01-05 | 1 | -26/+17 | |
| | | | | no more hardcoded string length | |||||
* | Error.c: make nxagentClientsLogName a pointer | Ulrich Sibiller | 2020-01-05 | 3 | -12/+22 | |
| | | | | no more hardcoded string length | |||||
* | Error.c: fix format-truncation warning | Ulrich Sibiller | 2020-01-05 | 2 | -40/+19 | |
| | | | | | | | | | | Error.c: In function ‘nxagentGetSessionPath’: Error.c:543:62: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 253 [-Wformat-truncation=] snprintf(nxagentSessionDir, DEFAULT_STRING_LENGTH, "%s/C-%s", rootPath, nxagentSessionId); ^~ ~~~~~~~~~~~~~~~~ Error.c:543:5: note: ‘snprintf’ output 4 or more bytes (assuming 259) into a destination of size 256 snprintf(nxagentSessionDir, DEFAULT_STRING_LENGTH, "%s/C-%s", rootPath, nxagentSessionId); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||||
* | Dialog.c: fix format-truncation warning | Ulrich Sibiller | 2020-01-05 | 1 | -4/+14 | |
| | | | | | | | | | | Dialog.c: In function ‘nxagentLaunchDialog’: Dialog.c:320:53: warning: ‘%s’ directive output may be truncated writing up to 1023 bytes into a region of size 256 [-Wformat-truncation=] snprintf(dialogDisplay, sizeof(dialogDisplay), "%s", nxagentDisplayName); ^~ ~~~~~~~~~~~~~~~~~~ Dialog.c:320:5: note: ‘snprintf’ output between 1 and 1024 bytes into a destination of size 256 snprintf(dialogDisplay, sizeof(dialogDisplay), "%s", nxagentDisplayName); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||||
* | nxagent: Use XlibAtom data type where appropriate | Ulrich Sibiller | 2020-01-05 | 11 | -70/+74 | |
| | | | | | | | | XlibAtom should be used wherever remote atoms are handled. This is important as Xlib data types and server data types of the same name do not always have identical sizes. See also https://lists.freedesktop.org/archives/xorg-devel/2015-August/047245.html | |||||
* | Pixels.c: reformat comments | Ulrich Sibiller | 2020-01-05 | 1 | -7/+4 | |
| | ||||||
* | Pixels.c: scope improvements | Ulrich Sibiller | 2020-01-05 | 1 | -6/+4 | |
| | ||||||
* | Options.h: reformat | Ulrich Sibiller | 2020-01-05 | 1 | -137/+57 | |
| | ||||||
* | Options.c: reformat comments | Ulrich Sibiller | 2020-01-05 | 1 | -12/+9 | |
| | ||||||
* | Pointer.c: scope improvements | Ulrich Sibiller | 2020-01-05 | 1 | -12/+6 | |
| | ||||||
* | Pointer.c: reformat comments | Ulrich Sibiller | 2020-01-05 | 1 | -9/+8 | |
| | ||||||
* | Visual.{ch}: disable unused code | Ulrich Sibiller | 2020-01-05 | 2 | -0/+5 | |
| | ||||||
* | Visual.c: reformat comments | Ulrich Sibiller | 2020-01-05 | 2 | -18/+12 | |
| | ||||||
* | Visual.c: code improvements/desginated initializers | Ulrich Sibiller | 2020-01-05 | 1 | -22/+14 | |
| | ||||||
* | Split.c: scope improvements/code simplification | Ulrich Sibiller | 2020-01-05 | 1 | -21/+7 | |
| | ||||||
* | Split.c: reformat comments | Ulrich Sibiller | 2020-01-05 | 1 | -60/+41 | |
| | ||||||
* | Keyboard.c: code simplification / scope improvements | Ulrich Sibiller | 2020-01-05 | 1 | -35/+29 | |
| | ||||||
* | Keyboard.c: reformat comments | Ulrich Sibiller | 2020-01-05 | 1 | -23/+20 | |
| | ||||||
* | Init.c: rewrite two function prototypes | Ulrich Sibiller | 2020-01-05 | 1 | -5/+2 | |
| | ||||||
* | Init.c: reformat comments | Ulrich Sibiller | 2020-01-05 | 1 | -63/+31 | |
| | ||||||
* | Handlers.c: reformat comments | Ulrich Sibiller | 2020-01-05 | 1 | -12/+9 | |
| | ||||||
* | GCOps.c: code simplification / scope improvements | Ulrich Sibiller | 2020-01-05 | 1 | -14/+5 | |
| | ||||||
* | GCOps.c: reformat comments | Ulrich Sibiller | 2020-01-05 | 1 | -6/+4 | |
| | ||||||
* | GC.c: blank line cleanup | Ulrich Sibiller | 2020-01-05 | 1 | -0/+1 | |
| | ||||||
* | GC.c: code simplifications / scope improvements | Ulrich Sibiller | 2020-01-05 | 1 | -5/+4 | |
| | ||||||
* | GC.c: reformat comments | Ulrich Sibiller | 2020-01-05 | 1 | -5/+5 | |
| | ||||||
* | Font.c: scope improvements | Ulrich Sibiller | 2020-01-05 | 1 | -30/+15 | |
| |