| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
| |
was offset to the right and downwards before
Fixes ArcticaProject/nx-libs#892
|
| |
|
|
|
|
| |
(from nxagent changelog)
|
| |
|
|
|
|
| |
It is better to create the values array once and not on every iteration..
|
|
|
|
|
|
| |
Does not require two parameters. It could be replaced by
RegionDestroy() entirely but we leave it to have a match to
nxagentCreateRegion().
|
|
|
|
|
| |
Now all cleanup code at the end of the function is gone so there's no
need for the gotos anymore. Just return directly.
|
|
|
|
|
| |
move common code into helper function that also takes care of the ugly
alloc/free stuff.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Otherwise we will never be able to free the list because we do not know
if free() is allowed or not.
|
|
|
|
| |
add else clauses, improve debugging, add comments
|
|
|
|
| |
not a real memleak since it is followed by a FatalError...
|
|
|
|
| |
The FIXME just described what the following function actually implements...
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
We have no hardware that could blank the screen for us. So let
nxagentSaveScreen return False in some situations to let dix do the
default action.
|
| |
|
|
|
|
|
| |
we moved the auto-disconnect feature to an own timer so there's no
need for a special treatment in screen saver stuff anymore.
|
|
|
|
|
|
| |
Option -timeout used the screensaver facility. This patch changes that
to an own timer that is independent. This effectly means we can drop
most of the derived screensaving stuff in a follow-up commit.
|
| |
|
| |
|
|
|
|
|
|
| |
This was removed by mistake in 39866f5c133230e5731156c2356c8571c971534c.
Fixes ArcticaProject/nx-libs#904
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean.c: In function ‘CleanZImage’:
Clean.c:141:23: warning: declaration of ‘j’ shadows a previous local [-Wshadow=local]
register int i, j;
^
Clean.c:88:16: note: shadowed declaration is here
unsigned int j;
^
Clean.c: In function ‘CopyAndCleanImage’:
Clean.c:239:22: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local]
register int i;
^
Clean.c:192:16: note: shadowed declaration is here
register int i;
^
Clean.c:324:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local]
int i;
^
Clean.c:192:16: note: shadowed declaration is here
register int i;
^
|
|
|
|
|
|
|
|
|
|
|
|
| |
xp must be declared outside the while loop!
xp was reset in each interation despite being increased at the
iteration's end!
To protect against this happening again replace the while loop by a
for loop that references xp.
Bug introduced by d94f472744355c71987d145727aecace1e8455b6
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pixmap.c: In function ‘nxagentDisconnectAllPixmaps’:
Pixmap.c:677:19: warning: declaration of ‘r’ shadows a previous local [-Wshadow=compatible-local]
for (int i = 0, r = 1; i < MAXCLIENTS; r = 1, i++)
^
Pixmap.c:652:7: note: shadowed declaration is here
int r = 1;
^
Pixmap.c: In function ‘nxagentReconnectAllPixmaps’:
Pixmap.c:840:19: warning: declaration of ‘result’ shadows a previous local [-Wshadow=compatible-local]
for (int i = 0, result = 1; i < MAXCLIENTS; result = 1, i++)
^~~~~~
Pixmap.c:807:8: note: shadowed declaration is here
Bool result = 1;
^~~~~~
|
|
|
|
|
|
|
|
|
|
|
| |
Display.c: In function ‘nxagentInitAndCheckVisuals’:
Display.c:2273:10: warning: declaration of ‘matched’ shadows a previous local [-Wshadow=compatible-local]
bool matched = false;
^~~~~~~
Display.c:2258:8: note: shadowed declaration is here
bool matched;
^~~~~~~
Display.c:2258:8: warning: unused variable ‘matched’ [-Wunused-variable]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Events.c: In function ‘nxagentDispatchEvents’:
Events.c:1241:21: warning: declaration of ‘pScreen’ shadows a previous local [-Wshadow=compatible-local]
ScreenPtr pScreen = nxagentScreen(X.xbutton.window);
^~~~~~~
Events.c:827:13: note: shadowed declaration is here
ScreenPtr pScreen = NULL;
^~~~~~~
Events.c:1383:19: warning: declaration of ‘pScreen’ shadows a previous local [-Wshadow=compatible-local]
ScreenPtr pScreen = nxagentScreen(X.xmotion.window);
^~~~~~~
Events.c:827:13: note: shadowed declaration is here
ScreenPtr pScreen = NULL;
^~~~~~~
Events.c: In function ‘nxagentDispatchEvents’:
Events.c:1383:19: warning: declaration of ‘pScreen’ shadows a previous local [-Wshadow=compatible-local]
ScreenPtr pScreen = nxagentScreen(X.xmotion.window);
^~~~~~~
Events.c:827:13: note: shadowed declaration is here
ScreenPtr pScreen = NULL;
^~~~~~~
|
|
|
|
|
|
|
|
|
|
|
|
| |
this was harmless but not nice nevertheless.
Clipboard.c: In function ‘nxagentConvertSelection’:
Clipboard.c:1850:9: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local]
int i = nxagentFindCurrentSelectionIndex(selection);
^
Clipboard.c:1736:7: note: shadowed declaration is here
int i = nxagentFindCurrentSelectionIndex(selection);
^
|
|
|
|
|
|
|
| |
Revert a wrong change that misteriously slipped in via the comment
reformatting commit 0133d4619.
Fixes ArcticaProject/nx-libs#893
|
|
|
|
|
|
|
|
|
| |
Using XlibAtom here is wrong. On a 64bit system the size of this type
is 8 bytes (64bit). At this stage we do not read Xlib datatypes but
wire datatypes. Over the wire an Atom is always 32bit, so we need to
use CARD32 here.
Fixes ArcticaProject/nx-libs#894
|
|
|
|
|
|
|
| |
Regression fix for 427b7b9777727df4115e3e9e6e63d5176fb0b495. As suggested
by Ulrich Sibiller.
Fixes ArcticaProject/nx-libs#891.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
nxagentBitmapBitOrder never existed and should really be
BitmapBitOrder. It was accidently replaced in
523009b96bd2e479c9823267bc060f8e5b0516e8
|
| |
|
| |
|
| |
|
|
|
|
| |
used the wrong macro for length determination
|
| |
|