Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Handlers.c: make synchronize a Boolean variable | Ulrich Sibiller | 2021-01-15 | 1 | -3/+3 |
| | |||||
* | nxagent: make nxagentSkipImage a Boolean | Ulrich Sibiller | 2021-01-15 | 2 | -3/+3 |
| | |||||
* | nxagent: make nxagentForceSynchronization a Boolean | Ulrich Sibiller | 2021-01-15 | 5 | -6/+6 |
| | |||||
* | Drawable.c: make abort flag a Boolean | Ulrich Sibiller | 2021-01-15 | 2 | -17/+17 |
| | |||||
* | Client.c: cleanup Boolean handling for nxagentNeedWakeup*() macros | Ulrich Sibiller | 2021-01-15 | 1 | -6/+6 |
| | |||||
* | GC.c: make internal variable and function Boolean | Ulrich Sibiller | 2021-01-15 | 1 | -16/+16 |
| | |||||
* | GCOps.c: make internal variable an function Booleans | Ulrich Sibiller | 2021-01-15 | 1 | -14/+14 |
| | |||||
* | nxagent: make nxagentBlocking an Boolean | Ulrich Sibiller | 2021-01-15 | 5 | -13/+13 |
| | |||||
* | Render.c: improve Boolean handling of nxagentCheckPictureRemoteValue | Ulrich Sibiller | 2021-01-15 | 1 | -12/+12 |
| | |||||
* | nxagent: improve Boolean handling for Reconnect functions | Ulrich Sibiller | 2021-01-15 | 2 | -20/+20 |
| | |||||
* | nxagent: make XDMCP variables Booleans | Ulrich Sibiller | 2021-01-15 | 3 | -10/+10 |
| | |||||
* | GCOps.c: make internal function Boolean | Ulrich Sibiller | 2021-01-15 | 1 | -6/+6 |
| | |||||
* | GCOps.c: handle some internal variables as Booleans | Ulrich Sibiller | 2021-01-15 | 1 | -5/+5 |
| | |||||
* | Drawable.c: make some variables Booleans | Ulrich Sibiller | 2021-01-15 | 1 | -5/+5 |
| | |||||
* | nxagent: handle RegionNil macro as Boolean | Ulrich Sibiller | 2021-01-15 | 8 | -33/+33 |
| | | | | just as the rest of the Xserver is alsow doing | ||||
* | Split.c, Image.c: make some internal variables Booleans | Ulrich Sibiller | 2021-01-15 | 2 | -29/+29 |
| | |||||
* | nxagent: rework some Boolean checks | Ulrich Sibiller | 2021-01-15 | 7 | -10/+10 |
| | | | | | nxagentWindowTopLevel() and nxagentNeedConnectionChange() return Boolean nxagentPixmapIsVirtual() and nxagentIsShmPixmap(), too. | ||||
* | nxagent: make nxagentUserDefinedFontPath a Boolean | Ulrich Sibiller | 2021-01-15 | 3 | -4/+4 |
| | |||||
* | nxagent: make nxagentShadowResize a Boolean | Ulrich Sibiller | 2021-01-15 | 4 | -5/+5 |
| | |||||
* | nxagent: make nxagentDoFullgeneration a Boolean | Ulrich Sibiller | 2021-01-15 | 3 | -3/+3 |
| | |||||
* | nxagent: some more Boolean improvements | Ulrich Sibiller | 2021-01-15 | 1 | -2/+2 |
| | |||||
* | nxagent: treat nxagentLastWindowDestroyed as Boolean | Ulrich Sibiller | 2021-01-15 | 2 | -2/+2 |
| | |||||
* | nxagent: treat all Traps as Booleans everywhere | Ulrich Sibiller | 2021-01-15 | 12 | -67/+67 |
| | |||||
* | nxagent: make nxagentVerbose a Boolean | Ulrich Sibiller | 2021-01-15 | 6 | -9/+9 |
| | |||||
* | nxagent: make Desktop, Rootless and Binder options Booleans (again) | Ulrich Sibiller | 2021-01-15 | 11 | -56/+33 |
| | | | | | They have been changed to tri-state variables (1, 0 and UNDEFINED) between nxagent 1.5.0-90 and -93, for no obvious reason. | ||||
* | Options.h: mark Booleans | Ulrich Sibiller | 2021-01-15 | 1 | -26/+32 |
| | | | | | Many variables are used as Booleans. By adding the Bool define to Options.h we can now make that visible. | ||||
* | nxagent: make nxagentOption Shadow a Boolean | Ulrich Sibiller | 2021-01-15 | 9 | -25/+26 |
| | | | | and add the missing init code. | ||||
* | nxagent: treat several nxagentOptions as real Booleans | Ulrich Sibiller | 2021-01-15 | 16 | -77/+77 |
| | | | | | | | Adaptive, Composite, DeviceControl, DeviceControlUserDefined, IgnoreVisibility, InhibitXkb, Nested, Menu, MagicPixel, Persistent, Reset, ResetzKeyboardAtResume, SharedMemory, SharedPixmaps, Streaming, UseDamage, ViewOnly, Xdmcp, Xinerama | ||||
* | nxagent: treat DesktopResize and nxagentResizeDesktopAtStartup as Booleans | Ulrich Sibiller | 2021-01-15 | 6 | -19/+19 |
| | | | | The already where Booleans but where not using True/False values everywhere | ||||
* | nxagent: make Fullscreen and AllScreens Booleans | Ulrich Sibiller | 2021-01-15 | 6 | -35/+29 |
| | | | | | There's no need/sense in having a tri-state with the third state being UNDEFINED. | ||||
* | Handlers.c: ensure regular yields if suspended | Ulrich Sibiller | 2021-01-15 | 1 | -1/+22 |
| | | | | Fixes ArcticaProject/nx-libs#903 | ||||
* | Init.c: Initialize nxagentGrabServerInfo | Ulrich Sibiller | 2021-01-12 | 1 | -1/+8 |
| | | | | Fixes ArcticaProject/nx-libs#983 | ||||
* | Events.c: fix leftover DEBUG and TEST definitions | Ulrich Sibiller | 2020-12-03 | 1 | -4/+1 |
| | | | | causing DEBUG output in regular builds. | ||||
* | NXdixfonts.c: Regression fix for db45683a. Fix typo in libXfont1 function ↵ | Mike Gabriel | 2020-11-04 | 1 | -1/+1 |
| | | | | call (FreeFontName -> FreeFontNames). Fixes FTBFS on Ubuntu 14.04 and 16.04. | ||||
* | release 3.5.99.253.5.99.25 | Mike Gabriel | 2020-11-04 | 1 | -1/+1 |
| | |||||
* | NXdixfonts.c: Hard-code the enablement of NXAGENT_DANGEROUS_XFONT_LOOP_EXIT. | Mike Gabriel | 2020-11-04 | 1 | -0/+7 |
| | |||||
* | NXdixfonts.c: Rename BREAK_XFONT_LOOP to NXAGENT_DANGEROUS_XFONT_LOOP_EXIT ↵ | Mike Gabriel | 2020-11-04 | 1 | -4/+4 |
| | | | | (better macro name). | ||||
* | Clipboard.c: fix bug in special optimization for nested settings | Ulrich Sibiller | 2020-11-04 | 1 | -2/+3 |
| | | | | Fixes ArcticaProject/nx-libs#941 | ||||
* | compext/Png.c: fix shadowing | Ulrich Sibiller | 2020-11-03 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | Png.c: In function ‘PngWriteData’: Png.c:603:38: warning: declaration of ‘png_ptr’ shadows a global declaration [-Wshadow] 603 | static void PngWriteData(png_structp png_ptr, png_bytep data, png_size_t length) | ~~~~~~~~~~~~^~~~~~~ Png.c:77:13: note: shadowed declaration is here 77 | png_structp png_ptr; | ^~~~~~~ Png.c: In function ‘PngFlushData’: Png.c:610:38: warning: declaration of ‘png_ptr’ shadows a global declaration [-Wshadow] 610 | static void PngFlushData(png_structp png_ptr) | ~~~~~~~~~~~~^~~~~~~ Png.c:77:13: note: shadowed declaration is here 77 | png_structp png_ptr; | ^~~~~~~ | ||||
* | Screen.c: fix indentation in nxagentMaximizeToFullScreen | Ulrich Sibiller | 2020-11-03 | 1 | -37/+37 |
| | |||||
* | Atoms.c: fix FIXME comment | Ulrich Sibiller | 2020-11-03 | 1 | -1/+1 |
| | |||||
* | Atoms.c: improve debug output | Ulrich Sibiller | 2020-11-03 | 1 | -1/+1 |
| | |||||
* | Events.c: scope improvement | Ulrich Sibiller | 2020-11-03 | 1 | -2/+2 |
| | |||||
* | Clipboard.c: add missing ifdefs | Ulrich Sibiller | 2020-11-03 | 1 | -0/+6 |
| | |||||
* | Compext.c: scope improvements | Ulrich Sibiller | 2020-11-03 | 1 | -14/+6 |
| | |||||
* | GCs.h: fix typo | Ulrich Sibiller | 2020-11-03 | 1 | -1/+1 |
| | |||||
* | Atoms.c: drop double include | Ulrich Sibiller | 2020-11-03 | 1 | -1/+0 |
| | |||||
* | Compext.c: use SAFE_free macro | Ulrich Sibiller | 2020-11-03 | 4 | -169/+106 |
| | |||||
* | Clipboard.c: fix missing ) | Ulrich Sibiller | 2020-11-03 | 1 | -1/+1 |
| | |||||
* | NXdixfonts.c: fix memory leak | Ulrich Sibiller | 2020-11-03 | 1 | -6/+56 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ==15332== 2,500 (96 direct, 2,404 indirect) bytes in 6 blocks are definitely lost in loss record 324 of 342 ==15332== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==15332== by 0x5748B9E: FontFileStartListFonts (in /usr/lib/x86_64-linux-gnu/libXfont.so.1.4.1) ==15332== by 0x5748C4A: FontFileStartListFontsAndAliases (in /usr/lib/x86_64-linux-gnu/libXfont.so.1.4.1) ==15332== by 0x42859A: nxdoListFontsAndAliases (NXdixfonts.c:1163) ==15332== by 0x42C0E0: nxOpenFont (NXdixfonts.c:1541) ==15332== by 0x43392E: ProcOpenFont (NXdispatch.c:902) ==15332== by 0x434585: Dispatch (NXdispatch.c:482) ==15332== by 0x40EF77: main (main.c:355) FontFileStartListFonts[AndAliases]() allocates some private data. This data is used by subsequent calls of FontFileListNextFontOrAlias() in a loop. (Only) the last call to that function will free() the private data and return with BadFontName. FontFileListNextFontOrAlias() is the only libXfont function that free()s the private data. In nxagent the loop is exited as soon as a font exists both locally and remote. Therefore the private data would never be free()d. Solution: do not break the loop but store the first matching result and let the loop run to the end, ignoring all following results. Disadvantage: this can mean hundreds of extra iterations for nothing. I have done no investigation of the time penalty this might cause. Unfortunately this is the only clean way I have found so far. An unclean solution has also been implemented. It can be activated by defining BREAK_XFONT_LOOP. In that case the private data is handled in nxagent by taking assumptions about its structure (taken from the libXfont source). That will break if libXfont changes its internal handling of the private. Therefore it is discouraged. An third alternative would be to drop using libXfont from the system. Instead fork libXfont to the nx-libs tree, add some patches link to that library statically. Fixes ArcticaProject/nx-libs#586 |