Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Screen.c: fix resizing bug with mutter window manager | Ulrich Sibiller | 2020-10-17 | 1 | -1/+1 |
| | | | | | | | Not really sure why I introduced the client check years ago. Grabbed is grabbed, so I don't see a reason implementing it this way. Fixes ArcticaProject/nx-libs#925. | ||||
* | nxagent: fix stack smashing | Ulrich Sibiller | 2020-10-17 | 4 | -4/+22 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In compext Atom has the size of XlibAtom. Therefore calling functions of Compext.c requires to use/pass XlibAtom. Same for Window/XlibWindow. ==15438==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fffffffcdc0 at pc 0x5555556a81b5 bp 0x7fffffffcd10 sp 0x7fffffffcd08 WRITE of size 8 at 0x7fffffffcdc0 thread T0 #0 0x5555556a81b4 in NXGetCollectedProperty nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124 #1 0x5555557d0488 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1202 #2 0x555555723340 in nxagentHandleCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3923 #3 0x55555571d4db in nxagentHandleProxyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3007 #4 0x55555571bb92 in nxagentHandleClientMessageEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:2595 #5 0x555555717dfc in nxagentDispatchEvents nx-X11/programs/Xserver/hw/nxagent/Events.c:1827 #6 0x555555750813 in nxagentBlockHandler nx-X11/programs/Xserver/hw/nxagent/Handlers.c:437 #7 0x5555556c1b5d in BlockHandler nx-X11/programs/Xserver/dix/dixutils.c:403 #8 0x5555556d47ff in WaitForSomething nx-X11/programs/Xserver/os/WaitFor.c:232 #9 0x555555665b22 in Dispatch nx-X11/programs/Xserver/hw/nxagent/NXdispatch.c:365 #10 0x5555555ed760 in main nx-X11/programs/Xserver/dix/main.c:350 #11 0x7ffff604909a in __libc_start_main ../csu/libc-start.c:308 #12 0x5555555edc09 in _start (nx-X11/programs/Xserver/nxagent+0x99c09) Address 0x7fffffffcdc0 is located in stack of thread T0 at offset 32 in frame #0 0x5555557d0324 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1190 This frame has 5 object(s): [32, 36) 'atomReturnType' <== Memory access at offset 32 partially overflows this variable [96, 100) 'resultFormat' [160, 168) 'ulReturnItems' [224, 232) 'ulReturnBytesLeft' [288, 296) 'pszReturnData' HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124 in NXGetCollectedProperty ... | ||||
* | Keyboard.c: improve capslock and numlock handling | Ulrich Sibiller | 2020-10-17 | 1 | -0/+42 |
| | | | | Fixes ArcticaProject/nx-libs#935 | ||||
* | Keyboard.c: fix indentation of ifdef | Ulrich Sibiller | 2020-10-17 | 1 | -2/+2 |
| | |||||
* | Extend sleep documentation | Ulrich Sibiller | 2020-06-29 | 1 | -3/+5 |
| | | | | Attributes ArcticaProject/nx-libs#241 | ||||
* | nxagent: clarify sleep time units | Ulrich Sibiller | 2020-06-29 | 5 | -15/+27 |
| | | | | | | | No functional changes, just clarification/explanation of the existing code. Fixes ArcticaProject/nx-libs#926 | ||||
* | Args.c: adapt message to use same format as similar messagespr/extend_manpage | Ulrich Sibiller | 2020-06-29 | 1 | -1/+1 |
| | |||||
* | manpage: document copysize parameter | Ulrich Sibiller | 2020-06-29 | 1 | -0/+4 |
| | | | | was previously undocumented. | ||||
* | manpage and usage output: add -irlimit | Ulrich Sibiller | 2020-06-29 | 2 | -0/+4 |
| | | | | Fixes ArcticaProject/nx-libs#796 | ||||
* | Extend some manpage entries | Ulrich Sibiller | 2020-06-29 | 2 | -13/+38 |
| | | | | | | | Fixes ArcticaProject/nx-libs#241 Fixes ArcticaProject/nx-libs#495 Fixes ArcticaProject/nx-libs#535 Fixes ArcticaProject/nx-libs#565 | ||||
* | release 3.5.99.243.5.99.24 | Mike Gabriel | 2020-05-31 | 1 | -1/+1 |
| | |||||
* | NXevents.c, NXdispatch.c: add some DEBUG statements | Ulrich Sibiller | 2020-05-31 | 2 | -2/+15 |
| | |||||
* | Client.h: make macro NULL pointer safe | Ulrich Sibiller | 2020-05-31 | 1 | -2/+2 |
| | |||||
* | Clipboard.c: small code improvement | Ulrich Sibiller | 2020-05-31 | 1 | -8/+7 |
| | |||||
* | Clipboard.c: add description/warning for nxagentClearClipboard | Ulrich Sibiller | 2020-05-31 | 1 | -0/+6 |
| | |||||
* | Clipboard.c: improve some more debugging messages | Ulrich Sibiller | 2020-05-31 | 1 | -19/+20 |
| | |||||
* | Clipboard.c: use nxagentClientInfoString for debug output | Ulrich Sibiller | 2020-05-31 | 1 | -58/+38 |
| | |||||
* | Clipboard.c: add elapsed time for lastClient to stats output if available | Ulrich Sibiller | 2020-05-31 | 1 | -2/+8 |
| | |||||
* | Clipboard.c: call endTransfer() | Ulrich Sibiller | 2020-05-31 | 1 | -4/+1 |
| | | | | instead of sendSelectionNotifyEventToClient + setClientSelectionStage | ||||
* | Clipboard.c: drop notifyConvertFailure | Ulrich Sibiller | 2020-05-31 | 1 | -24/+15 |
| | | | | | Moving the client check to sendSelectionNotifyEventToClient enables us to drop notifyConvertFailure. | ||||
* | Clipboard.c: drop unused return code of sendSelectionNotifyEventToClient | Ulrich Sibiller | 2020-05-31 | 1 | -8/+8 |
| | |||||
* | Clipboard.c: Fix: always reset selectionStage in endTransfer | Ulrich Sibiller | 2020-05-31 | 1 | -15/+16 |
| | |||||
* | Clipboard.c: make setClientSelectionStage a function | Ulrich Sibiller | 2020-05-31 | 1 | -26/+42 |
| | | | | and reset the lastClient variables when stage is set to None. | ||||
* | Clipboard.c: improve Clipboard stats | Ulrich Sibiller | 2020-05-31 | 1 | -1/+11 |
| | | | | resolve lastClientClientPtr to process id and process name | ||||
* | nxagent: Add keystroke for dumping the current clipboard state | Ulrich Sibiller | 2020-05-31 | 6 | -26/+26 |
| | |||||
* | nxagent: Free atom map on termination | Ulrich Sibiller | 2020-05-31 | 1 | -0/+2 |
| | |||||
* | Events.h: reformat comments | Ulrich Sibiller | 2020-05-07 | 1 | -22/+15 |
| | |||||
* | Reconnect.c: save some lines | Ulrich Sibiller | 2020-05-07 | 1 | -14/+1 |
| | |||||
* | Reconnect.c: reformat comments | Ulrich Sibiller | 2020-05-07 | 1 | -20/+14 |
| | |||||
* | Screen.c: fix missing type in DEBUG mode | Ulrich Sibiller | 2020-05-07 | 1 | -2/+2 |
| | |||||
* | Reconnect.c: reformat saveAgentState() | Ulrich Sibiller | 2020-05-07 | 1 | -5/+4 |
| | |||||
* | Rootless.c: do not import private properties | Ulrich Sibiller | 2020-05-07 | 2 | -0/+40 |
| | | | | | | | | | | In rootless mode some properties are private (or internal or adminitrative). They are only required for the windows on the real X server side that represent nxagent's windows. Those properties should never be cloned from there to the the nxagent windows so we filter them. Fixes ArcticaProject/nx-libs#920 | ||||
* | Rootless.c: improve TEST output | Ulrich Sibiller | 2020-05-07 | 1 | -12/+16 |
| | | | | more output, correct format specifiers | ||||
* | Rootless.c: add some comments | Ulrich Sibiller | 2020-05-07 | 1 | -0/+11 |
| | |||||
* | Clipboard.c: fix typo | Ulrich Sibiller | 2020-05-07 | 1 | -1/+1 |
| | |||||
* | Keystroke.c: whitespace fixes | Ulrich Sibiller | 2020-05-07 | 1 | -6/+6 |
| | |||||
* | NXdixfonts.c: some code cleanups | Ulrich Sibiller | 2020-05-07 | 1 | -18/+16 |
| | | | | reformat, extend comments, simplify ifdef | ||||
* | NXdixfonts.c: fix debugging output | Ulrich Sibiller | 2020-05-07 | 1 | -1/+5 |
| | |||||
* | Keyboard.c: free remote keybord names once no longer needed | Ulrich Sibiller | 2020-05-07 | 1 | -5/+9 |
| | |||||
* | NXdispatch.c: free font data on exit | Ulrich Sibiller | 2020-05-07 | 3 | -1/+10 |
| | | | | helps to avoid valgrind warnings | ||||
* | Font.c: add hint of deliberate pointer misuse | Ulrich Sibiller | 2020-05-07 | 2 | -3/+8 |
| | |||||
* | Font.c: fix realloc bugs | Ulrich Sibiller | 2020-05-07 | 1 | -20/+23 |
| | |||||
* | Font.c: cleanup | Ulrich Sibiller | 2020-05-07 | 1 | -1076/+1071 |
| | | | | reformat, whitespace, code simplification, FIXMEs | ||||
* | NXshm.c: cleanup nxagent_fbShmCreatePixmap | Ulrich Sibiller | 2020-05-07 | 1 | -17/+20 |
| | | | | ... to match it as closely as possible to the upstream version. | ||||
* | Dialog.h: reformat comment | Ulrich Sibiller | 2020-05-07 | 1 | -4/+3 |
| | |||||
* | Dialog.h: Fix incomplete macro nxagentNoDialogIsRunning | Ulrich Sibiller | 2020-05-07 | 1 | -1/+3 |
| | | | | The autograb stuff had been forgotten. | ||||
* | Screen.c: fix wrong debug statement | Ulrich Sibiller | 2020-05-07 | 1 | -1/+1 |
| | |||||
* | NXshm.c: slight simplification | Ulrich Sibiller | 2020-05-07 | 1 | -5/+2 |
| | |||||
* | NXshm.c: simplify Dispatch functions | Ulrich Sibiller | 2020-05-07 | 1 | -11/+4 |
| | |||||
* | Improve clipboard/xfixes related debug output | Ulrich Sibiller | 2020-05-07 | 2 | -2/+2 |
| |