| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Amends the following compiler warnings:
```
NXmiexpose.c:904:18: warning: ‘newValues[2].ptr’ may be used uninitialized in this function [-Wmaybe-uninitialized]
gcval[i++].ptr = newValues[TILE].ptr;
^
NXmiexpose.c:914:24: warning: ‘newValues[1].val’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if ( pGC->fgPixel != newValues[FOREGROUND].val) {
^
```
|
|
|
|
| |
expression.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NoEventMask.
Amends the following compiler warning:
```
Window.c: In function ‘nxagentSetTopLevelEventMask’:
Window.c:3392:31: warning: ‘attributes.event_mask’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Mask tmp_mask = attributes.event_mask;
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used later on.
Amends the following compiler warning:
```
Colormap.c: In function ‘nxagentReconnectAllColormap’:
Colormap.c:575:7: warning: variable ‘flexibility’ set but not used [-Wunused-but-set-variable]
int flexibility;
^
```
|
|
|
|
|
|
|
|
|
|
|
| |
Amends the following compiler warning:
```
GCOps.c: In function ‘nxagentCopyArea’:
GCOps.c:597:7: warning: variable ‘oldDstxyValue’ set but not used [-Wunused-but-set-variable]
int oldDstxyValue;
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
later on.
Amends the following compiler warning:
```
GC.c: In function ‘nxagentReconnectAllGCs’:
GC.c:1154:7: warning: variable ‘flexibility’ set but not used [-Wunused-but-set-variable]
int flexibility;
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if compiled with -DTEST / -DDEBUG (plus drop commented out code).
Amends the following compiler warnings:
```
Events.c: In function ‘nxagentHandleClientMessageEvent’:
Events.c:2694:13: warning: variable ‘message_data’ set but not used [-Wunused-but-set-variable]
char *message_data;
^
Events.c: In function ‘nxagentClipAndSendExpose’:
Events.c:4313:10: warning: variable ‘box’ set but not used [-Wunused-but-set-variable]
BoxRec box;
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not used later on.
Amends the following compiler warnings:
```
Display.c: In function ‘nxagentReconnectDisplay’:
Display.c:2449:19: warning: variable ‘packQuality’ set but not used [-Wunused-but-set-variable]
int packMethod, packQuality;
^
Display.c:2449:7: warning: variable ‘packMethod’ set but not used [-Wunused-but-set-variable]
int packMethod, packQuality;
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used later on.
Amends the following compiler warning:
```
NXrender.c: In function ‘swapStops’:
NXrender.c:3036:13: warning: variable ‘colors’ set but not used [-Wunused-but-set-variable]
CARD16 *colors;
^
```
|
|
|
|
|
| |
We don't define HAVE_STDINT_H anywhere and it should be more safe using
the system's definition of UINT32_MAX.
|
| |
|
|
|
|
| |
needed from that header file.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nxagentReconnectPictFormat.
Amends the following compiler warnings:
```
NXpicture.c: In function ‘nxagentReconnectPictFormat’:
NXpicture.c:2148:9: warning: variable ‘pBool’ set but not used [-Wunused-but-set-variable]
Bool *pBool;
^
NXpicture.c:2147:17: warning: variable ‘pFormat’ set but not used [-Wunused-but-set-variable]
PictFormatPtr pFormat;
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
later on.
Amends the following compiler warning:
```
NXglyphcurs.c: In function ‘ServerBitsFromGlyph’:
NXglyphcurs.c:109:17: warning: variable ‘gcval’ set but not used [-Wunused-but-set-variable]
ChangeGCVal gcval[3];
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with -DTEST.
Amends the following compiler warning:
```
Keyboard.c: In function ‘nxagentKeyboardProc’:
Keyboard.c:688:7: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
int ret;
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
later on.
Amends the following compiler warning:
```
Handlers.c: In function ‘nxagentShadowBlockHandler’:
Handlers.c:732:7: warning: variable ‘result’ set but not used [-Wunused-but-set-variable]
int result;
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
later on.
Amends the following compiler warning:
```
Keyboard.c: In function ‘nxagentNotifyKeyboardChanges’:
Keyboard.c:1211:16: warning: variable ‘xkb’ set but not used [-Wunused-but-set-variable]
XkbDescPtr xkb;
^
```
|
|
|
|
|
| |
These can be dropped after we have turned REGION_* macros into
static inline function calls in some of the previous commits.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Amends the following compiler warnings:
```
Screen.c: In function ‘nxagentCreateIconWindow’:
Screen.c:394:15: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Window’ [-Wformat=]
nxagentIconWindow);
^
Screen.c: In function ‘nxagentSetScreenSaverTime’:
Screen.c:456:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘CARD32’ [-Wformat=]
ScreenSaverTime, ScreenSaverInterval);
^
Screen.c:456:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ [-Wformat=]
Screen.c:476:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘CARD32’ [-Wformat=]
ScreenSaverTime, ScreenSaverInterval);
^
Screen.c:476:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ [-Wformat=]
Screen.c: In function ‘nxagentOpenScreen’:
Screen.c:1234:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘VisualID’ [-Wformat=]
visuals[numVisuals].vid);
^
Screen.c:1274:23: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘VisualID’ [-Wformat=]
depths[depthIndex].depth);
^
Screen.c:1282:17: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘VisualID’ [-Wformat=]
defaultVisualIndex, visuals[defaultVisualIndex].vid);
^
Screen.c:1319:19: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘VisualID’ [-Wformat=]
rootDepth, defaultVisual);
^
Screen.c:1336:19: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘VisualID’ [-Wformat=]
rootDepth, defaultVisual);
^
Screen.c:1348:19: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘VisualID’ [-Wformat=]
rootDepth, defaultVisual);
^
Screen.c:1357:19: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘VisualID’ [-Wformat=]
rootDepth, defaultVisual);
^
Screen.c:1723:21: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Window’ [-Wformat=]
nxagentDefaultWindows[pScreen->myNum]);
^
Screen.c:1763:19: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Window’ [-Wformat=]
nxagentDefaultWindows[pScreen->myNum]);
^
Screen.c:1775:17: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Window’ [-Wformat=]
nxagentDefaultWindows[pScreen->myNum]);
^
Screen.c:1790:17: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Window’ [-Wformat=]
nxagentDefaultWindows[pScreen->myNum]);
^
Screen.c: In function ‘nxagentShadowAdaptDepth’:
Screen.c:3189:14: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
pVisual -> red_mask, pVisual -> green_mask, pVisual -> blue_mask);
^
Screen.c:3189:14: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
Screen.c:3189:14: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘long unsigned int’ [-Wformat=]
Screen.c:3198:15: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
redMask, greenMask, blueMask);
^
Screen.c:3198:15: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
Screen.c:3198:15: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘long unsigned int’ [-Wformat=]
```
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Amends the following compiler warnings:
```
Screen.c: In function ‘nxagentReconnectScreen’:
Screen.c:3547:7: warning: variable ‘flexibility’ set but not used [-Wunused-but-set-variable]
int flexibility;
^
Screen.c: In function ‘nxagentAdjustRandRXinerama’:
Screen.c:3746:12: warning: unused variable ‘j’ [-Wunused-variable]
int i, j;
^
Screen.c: In function ‘nxagentSaveAreas’:
Screen.c:4116:15: warning: variable ‘pDrawable’ set but not used [-Wunused-but-set-variable]
DrawablePtr pDrawable;
^
Screen.c: In function ‘nxagentRestoreAreas’:
Screen.c:4236:15: warning: variable ‘pDrawable’ set but not used [-Wunused-but-set-variable]
DrawablePtr pDrawable;
^
```
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid implicit-declaration compiler warning.
Amends the following compiler warning:
```
Screen.c:3716:5: warning: implicit declaration of function ‘nxagentAdjustRandRXinerama’ [-Wimplicit-function-declaration]
nxagentAdjustRandRXinerama(pScreen);
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use MIN(A,B) macro as defined in Utils.h. Add MAX(A,B) macro in Utils.h,
as well. Don't have another set of MIN/MAX macro definitions in
Screen.c.
Amends the following compiler warnings:
```
Screen.c:3600:0: warning: "MIN" redefined
#define MIN(a,b) ((a) < (b)) ? (a) : (b);
^
In file included from Screen.c:78:0:
Utils.h:36:0: note: this is the location of the previous definition
#define MIN(A, B) ( (A) < (B) ? (A) : (B) )
^
```
|
|
|
|
|
|
|
|
|
|
|
|
| |
use it.
Amends the following compiler warning:
```
Window.c:2179:24: warning: variable ‘changes’ set but not used [-Wunused-but-set-variable]
XWindowChanges changes;
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mode.
Amends the following compiler warning:
```
Pixmap.c: In function ‘nxagentDisconnectPixmap’:
Pixmap.c:755:9: warning: variable ‘pBool’ set but not used [-Wunused-but-set-variable]
Bool *pBool;
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Amends the following the compiler warnings:
```
Extensions.c: In function ‘nxagentRandRInitSizes’:
Extensions.c:159:16: warning: unused variable ‘pRandRScrPriv’ [-Wunused-variable]
rrScrPrivPtr pRandRScrPriv = rrGetScrPriv(pScreen);
^
Extensions.c: In function ‘nxagentRandRSetConfig’:
Extensions.c:263:16: warning: unused variable ‘pRandRScrPriv’ [-Wunused-variable]
rrScrPrivPtr pRandRScrPriv;
^
Extensions.c: In function ‘nxagentRandRScreenSetSize’:
Extensions.c:322:16: warning: unused variable ‘pRandRScrPriv’ [-Wunused-variable]
rrScrPrivPtr pRandRScrPriv;
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handing it over to %lu in fprintf().
Amends the following compiler warnings:
```
Rootless.c: In function ‘nxagentExportProperty’:
Rootless.c:775:21: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘Atom’ [-Wformat=]
"Property [%lu] too long.\n", propertyX);
^
```
|
|
|
|
|
|
|
|
|
|
|
| |
Amends the following compiler warning:
```
Splash.c: In function ‘nxagentPaintLogo’:
Splash.c:168:13: warning: unused variable ‘m’ [-Wunused-variable]
XPoint m[12];
^
```
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with -DDEBUG.
Amends the following compiler warning:
```
Clipboard.c: In function ‘nxagentRequestSelection’:
Clipboard.c:272:7: warning: variable ‘result’ set but not used [-Wunused-but-set-variable]
int result;
^
```
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This prepares the file to be moved from mi to dix. This patch
was done mechanically with the included scripts 'fix-miregion' run over
the entire X server and 'fix-miregion-private' run over
include/regionstr.h and mi/miregion.c.
v1: Keith Packard <keithp@keithp.com>
v2: Mike Gabriel <mike.gabriel@das-netzwerkteam.de> (backported to nx-libs)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a huge mechanical patch and a few small fixups required to finish
the job. They were reviewed separately, but because the server does not
build without both pieces, I've merged them together at this time.
The mechanical changes were performed by running the included
'fix-region' script over the whole nx-X11/programs/Xserver tree:
$ cd nx-X11/programs/Xserver && ( git ls-files | grep -v '^fix-' | xargs ./fix-region; )
And then, the white space errors in the resulting patch were fixed
using the provided fix-patch-whitespace script.
$ sh ./fix-patch-whitespace
Thanks to Jamey Sharp for the mighty fine sed-generating sed script.
v1: Keith Packard <keithp@keithp.com> (X.Org xserver commit: 2dc138922b7588515d5f2447e4b9dcdc0bef15e0)
v2: Mike Gabriel <mike.gabriel@das-netzwerkteam.de> (apply fix-region script to nx-libs)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Amends the following compiler warnings:
```
NXwindow.c: In function ‘nxagentClearSplash’:
NXwindow.c:342:12: warning: variable ‘h’ set but not used [-Wunused-but-set-variable]
int w, h;
^
NXwindow.c:342:9: warning: variable ‘w’ set but not used [-Wunused-but-set-variable]
int w, h;
^
```
|
|
|
|
| |
shared library.
|
| |
|
|
|
|
|
|
|
| |
comment). (Fixes ArcticaProject/nx-libs#38).
commit 0d56c45 was:
nx-X11: handle source pictures (those without a Drawable surface) gracefully.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the problem Mike Gabriel describes like this:
- Launch a session on a system with a single monitor. Enable Xinerama
for this session.
- Open a desktop session in that session window (e.g. MATE or XFCE).
- Move the NX/MATE-or-XFCE session window around on that one
monitor. Bump at the borders, so that the session window moves into
the invisible parts around your monitor.
What you see is that the MATE-or-XFCE window manager will become
really busy with resizing the windows and panels in the NX session,
because moving the window over the physical borders of the display
will trigger resize events.
This is non-intuitive, I think.
Same with multi-monitors on the outside edges of the physical Xorg
RandR setup.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By design, when resuming a session, Xinerama can only be re-enabled
by NX option parsing.
Thus, this change introduces a "xinerama" NX option that can
be loaded via an options file into NX agent when resuming
a session. The new xinerame NX session option also allows
switching on Xinerama at session startup via an option file.
When implementing the new NX Xinerama support into clients (like
TheQVD, X2Go Client, etc., this new xinerama NX option should be
used for activating Xinerama in the NX / QVD / X2Go session.
|
|
|
|
| |
with "-geometry fullscreen".
|
| |
|
|
|
|
| |
unclosed comment.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
ArcticaProject/nx-libs#23).
No more xinerama faking, just use existing xrandr extension and initalize
it properly. Xinerama then works automatically.
Fixes ArcticaProject/nx-libs#23
|
|
|
|
|
|
|
|
|
|
| |
libXinerama shared library. (Fixes ArcticaProject/nx-libs#49).
This commit goes along with a patch from Ulrich Sibiller who managed to
move the Xinerama awareness for NX sessions into the Xserver code. This
makes Xinerama support for NX in libNX_Xinerama.so obsolete.
Fixes ArcticaProject/nx-libs#49
|
|
|
|
| |
between X11 and nx-X11 namespace regarding header include paths.
|
|
|
|
| |
that includes headers from our Xlib version. This avoids FTBFS caused by type redefinitions and should really be a temporary measure.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the process of building nxagent against more and more system-wide installed
X.org libraries, we come to the limit of including structs from this (bundled
nx-X11) and that (system-wide X.Org) library.
This commit introduces a clear namespace separation of headers provided by
nx-X11 and headers provided by X.Org. This approach is only temporary as we
want to drop all nx-X11 bundled libraries from nx-libs.
However, for a while we need to make this separation clear and also ship
some reduced fake X.Org headers that avoid pulling in libX* and libNX_X*
symbols at the same time.
This patch has been tested on Debian jessie and unstable and requires no
overall testing on various distros and distro versions, as we finally will
drop all libNX_X* libraries and build against X.org's client libs.
For now, this hack eases our development / cleanup process.
|