| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Drop the font path defines and build the path strings at runtime instead.
|
|
|
|
| |
Has been obsoleted in 2005, see https://en.wikipedia.org/wiki/Bitstream_Speedo_Fonts
|
| |
|
|
|
|
|
|
|
| |
also add TEST prints, init nxagentProgName with NULL and add const
where it was missing.
Fixes ArcticaProject/nx-libs#803
|
| |
|
| |
|
|
|
|
| |
Attributes ArcticaProject/nx-libs#382
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit cc5f09c86f7bea23b7546c3491b2c52ce8100a71
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon Jul 9 19:12:43 2012 -0700
Use C99 designated initializers in various extension Replies
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
Tested-by: Daniel Stone <daniel@fooishbar.org>
Attributes ArcticaProject/nx-libs#382
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit cdf5bcd420e5bcf4a4a24a275d3133a4e16ce41e
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon Jul 9 19:12:42 2012 -0700
Use calloc to zero fill buffers being allocated for replies & events
Ensures padding bytes are zero-filled
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
Tested-by: Daniel Stone <daniel@fooishbar.org>
Attributes ArcticaProject/nx-libs#382
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 16cd2bbe1c4425e3fa557f9ca0723aa94a50b071.
It turned out that I had missed some of the Booleans being actually
tristate variables. I think I can fix this (they do not need to be
tristate) but I revert this for now to get back to a working state
(there are reports about non-working fullscreen mode and reconnect
problems).
Refers to ArcticaProject/nx-libs#772
|
|
|
|
| |
drop "== False", "== 0", "== True" and "== 0" for nxagentOptions and Traps
|
|
|
|
|
| |
In rootless mode skip processing user geometry stuff since the values will we
overwritten later anyway.
|
|
|
|
| |
Fixes: ArcticaProject/nx-libs#765
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
If nxagent is started in fullscreen mode take care the saved size
(that is applied on exit of the fullscreen mode) will be configured
correctly. Also respect a user provided -geometry option (had been
ignored here previously).
Fixes ArcticaProject/nx-libs#449
|
|
|
|
|
|
|
| |
There's no need to reduce the size to 75% in rootless mode. We always
want to have the full size then.
Fixes ArcticaProject/nx-libs#757 (Part 2/2)
|
|
|
|
|
|
| |
... by using some short named variables and the min() macro.
No change in behaviour.
|
| |
|
| |
|
|
|
|
|
|
| |
Minor fix: The loop always started at index 3, comparing against the
value at index 2. So the resolution at index 1 (320x240) was never
taken into account for anything.
|
|
|
|
|
|
|
| |
This solves weird window (menu) placement and drawing behaviour on right/lowest
25% of the screen.
Fixes ArcticaProject/nx-libs#757 (Part 1/2)
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
If X2go runs in auto keyboard mode it will pass keyboard=null/null to
the agent and set the keyboard afterwards with setxkbmap. This patch
lets nxagent handle that situation internally (null/null will be
interpreted as clone) and disables X2go's mechanism (by creating a dir
that effectively blocks it; see x2gosetkeyboard)
This is only activated if the agent is run as "x2goagent".
Fixes ArcticaProject/nx-libs#368
|
| |
|
| |
|
|
|
|
| |
This avoids some roundtrips.
|
|
|
|
| |
Add possibility to pass more than model and layout via the keyboard parameter.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifying -keyboard clone (or keyboard=clone in options) will clone
XKB keyboard from the remote x server. This way many keyboard problems
will hopefully never return...
Should be the default but is not (yet) for compatibility reasons.
Fixes ArcticaProject/nx-libs#373
(except the "do autoconf if no keyboard is provided" feature.)
References:
ArcticaProject/nx-libs#240
ArcticaProject/nx-libs#368
|
|
|
|
|
|
|
| |
It may not fully fix the issue mentioned below but it does for the
-keyboard commandline option at least.
Fixes ArcticaProject/nx-libs#741
|
|
|
|
| |
Describes a check we are not doing here anymore...
|
|
|
|
| |
we have changed that to base some time ago.
|
|
|
|
|
|
|
|
| |
It will now create better working config files.
References:
ArcticaProject/nx-libs#239
ArcticaProject/nx-libs#368
|
| |
|
|
|
|
| |
avoid mix of 'variant' and 'variants'
|
| |
|
|
|
|
| |
we'll need the remote xkb in KeyboardProc in future so let's move it up.
|
| |
|
| |
|
|
|
|
| |
(partially) fixes ArcticaProject/nx-libs#666
|
|
|
|
| |
(partially) fixes ArcticaProject/nx-libs#666
|
|
|
|
| |
(partially) fixes ArcticaProject/nx-libs#666
|
|
|
|
| |
(partially) fixes ArcticaProject/nx-libs#666
|
|
|
|
| |
(partially) fixes ArcticaProject/nx-libs#666
|
|
|
|
| |
(partially) fixes ArcticaProject/nx-libs#666
|
|
|
|
| |
(partially) fixes ArcticaProject/nx-libs#666
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Backport of this commit:
commit a2880699e8f1f576e1a48ebf25e8982463323f84
Author: Keith Packard <keithp@keithp.com>
Date: Tue Mar 25 08:21:16 2014 -0700
fb: fix fast-path blt detection
The width parameter is used to disable the blit fast-path (memcpy) when
source and destination rows overlap in memory. This check was added in [0].
Unfortunately, the calculation to determine if source and destination
lines overlapped was incorrect:
(1) it converts width from pixels to bytes, but width is actually in
bits, not pixels.
(2) it adds this byte offset to dst/srcLine, which implicitly converts
the offset from bytes to sizeof(FbBits).
Fix both of these by converting addresses to byte pointers and width
to bytes and doing comparisons on the resulting byte address.
For example:
A 32-bpp 1366 pixel-wide row will have
width = 1366 * 32 = 43712 bits
bpp = 32
(bpp >> 3) = 4
width * (bpp >> 3) = 174848 FbBits
(FbBits *)width => 699392 bytes
So, "careful" was true if the destination line was within 699392 bytes,
instead of just within its 1366 * 4 = 5464 byte row.
This bug causes us to take the slow path for large non-overlapping rows
that are "close" in memory. As a data point, XGetImage(1366x768) on my
ARM chromebook was taking ~140 ms, but with this fixed, it now takes
about 60 ms.
XGetImage() -> exaGetImage() -> fbGetImage -> fbBlt()
[0] commit e32cc0b4c85c78cd8743a6e1680dcc79054b57ce
Author: Adam Jackson <ajax@redhat.com>
Date: Thu Apr 21 16:37:11 2011 -0400
fb: Fix memcpy abuse
The memcpy fast path implicitly assumes that the copy walks
left-to-right. That's not something memcpy guarantees, and newer glibc
on some processors will indeed break that assumption. Since we walk a
line at a time, check the source and destination against the width of
the blit to determine whether we can be sloppy enough to allow memcpy.
(Having done this, we can remove the check for !reverse as well.)
v3: Convert to byte units
This first checks to make sure the blt is byte aligned, converts all
of the data to byte units and then compares for byte address range
overlap between source and dest.
Signed-off-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#750
Backport of this commit:
commit e32cc0b4c85c78cd8743a6e1680dcc79054b57ce
Author: Adam Jackson <ajax@redhat.com>
Date: Thu Apr 21 16:37:11 2011 -0400
fb: Fix memcpy abuse
The memcpy fast path implicitly assumes that the copy walks
left-to-right. That's not something memcpy guarantees, and newer glibc
on some processors will indeed break that assumption. Since we walk a
line at a time, check the source and destination against the width of
the blit to determine whether we can be sloppy enough to allow memcpy.
(Having done this, we can remove the check for !reverse as well.)
On an Intel Core i7-2630QM with an NVIDIA GeForce GTX 460M running in
NoAccel, the broken code and various fixes for -copywinwin{10,100,500}
gives (edited to fit in 80 columns):
1: Disable the fastpath entirely
2: Replace memcpy with memmove
3: This fix
4: The code before this fix
1 2 3 4 Operation
------ --------------- --------------- --------------- ------------
258000 269000 ( 1.04) 544000 ( 2.11) 552000 ( 2.14) Copy 10x10
21300 23000 ( 1.08) 43700 ( 2.05) 47100 ( 2.21) Copy 100x100
960 962 ( 1.00) 1990 ( 2.09) 1990 ( 2.07) Copy 500x500
So it's a modest performance hit, but correctness demands it, and it's
probably worth keeping the 2x speedup from having the fast path in the
first place.
Signed-off-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Keith Packard <keithp@keithp.com>
|