| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
| |
Also comment the code and convert error messages to warnings.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Fix write past the end of singlePath if PATH contains dirs longer than PATH_MAX.
|
| |
|
|
|
|
| |
lengths
|
|
|
|
|
| |
We need this to be able to execute the resulting nxagent binary from
within the build directory.
|
|
|
|
|
|
|
|
|
| |
version with the system location.
While the install target explicitly installs the relinked
system-location version of a program, we do not actually use this.
Currently, we copy nxagent directly out of the build root.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As discussed in ArcticaProject/nx-libs#610, we need a way to load
libNX_X11 as a fake version of libX11 into nxagent's address space.
For doing so, we have to link against libX11 at build-time and specify
a(n) RPATH/RUNPATH to our libX11 -> libNX_X11 compat symlinks.
This commit is essentially doing a cross between options 3 and 4
discussed in the provided GH issue.
We link libX11 early (before specifying -Lcompat_symlinks_dir), so that
the linker finds the "real" libX11 version with the libX11 SONAME. This
leads to our binary depending upon both libX11 and libNX_X11 SONAMEs. We
already always added RPATH/RUNPATH, but these values are not passed down
to dependent libraries.
What happens at run-time is that the loader searches for a libX11
SONAME, takes RPATH/RUNPATH into account and loads our libNX_X11 library
instead via the compat symlinks. This satisfies the libX11 SONAME and
dependent libraries will *not* load the system libX11 version again.
Debian's dpkg-shlibdeps isn't quite happy about this mismatching SONAME
situation, so instruct to look the other way while we're minding our
business.
Fixes: ArcticaProject/nx-libs#610
|
|
|
|
| |
as reported by valgrind
|
|
|
|
|
|
| |
output.
Was dropped erroneously in cec31e2f06b29b332ee78cfefeefa7bfa136be75.
|
|
|
|
|
|
|
| |
modifying CRTC modes.
This should get rid of the infamous "800x600 screen size" issue
reproduced in X2Go whole display setups.
|
|
|
|
| |
actually header I was searching for.
|
|
|
|
| |
via the _SHAPE_SERVER_ macro.
|
|
|
|
| |
proto versions, since shape.h would pull in Xlib.
|
| |
|
|
|
|
|
|
| |
are directly available.
Especially don't add linking flags willy-nilly.
|
| |
|
| |
|
|
|
|
|
| |
Legacy Xext proto versions are automatically detected by the main
Makefile.
|
|
|
|
|
|
|
|
| |
Partly reverts ec30a857eb0d67b232f8d43e63a6370023f4c4d0, but in a
forward-compatible manner.
Legacy libXfont1 versions are automatically detected by the main
Makefile.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
They have been flawed ever since nxagent came up, as they were Xfree
(non-capital f) always, but should have been XFree (capital F, defined
in Xlibint.h and part of libNX_X11).
.
Probably this all should be free() all over the code (bearing in mind,
that XFree() returns int, not void. But still...
Fixes ArcticaProject/nx-libs#553.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as pointers
Picked from this X.org commit:
commit b0dd6be2c8703f7062d45ac9fd646550c7d54e3b
Author: Jamey Sharp <jamey@minilop.net>
Date: Thu Oct 8 13:38:44 2009 +1100
Cast small-int values through intptr_t when passed as pointers
On 64-bit systems, int and pointers don't have the same size, so GCC gives
warnings about casts between int and pointer types. However, in the cases
covered by this patch, it's always a value that fits in int being stored
temporarily as a pointer and then converted back later, which is safe.
Casting through the pointer-sized integer type intptr_t convinces the
compiler that this is OK.
Signed-off-by: Jamey Sharp <jamey@minilop.net>
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Backported-to-NX-by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
(Only appropriate location for backporting: Xserver/GL/glx/glxcmds.c).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 63ccaec2c39f4b5742383472c951ee2cd35c9e14
Author: Adam Jackson <ajax@redhat.com>
Date: Tue Oct 19 11:59:23 2010 -0400
render2.c: In function ‘__glXDisp_Map2d’:
render2.c:127: warning: ‘u1’ may be used uninitialized in this function
render2.c: In function ‘__glXDisp_Map1d’:
render2.c:90: warning: ‘u1’ may be used uninitialized in this function
Remove unnecessary test, and change memcpy to memmove as all users were
doing overlapping copies.
Signed-off-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Daniel Stone <daniel@fooishbar.org>
Backported-to-NX-by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
|
|
|
|
|
|
|
|
| |
glxfb.c: In function '__glXFBMemSwapBuffers':
glxfb.c:117:5: warning: pointer targets in passing argument 10 of 'pGC->ops->PutImage' differ in signedness [-Wpointer-sign]
buf);
^~~
glxfb.c:117:5: note: expected 'char *' but argument is of type 'GLubyte * {aka unsigned char *}'
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Events.c: In function 'nxagentDumpInputDevicesState':
Events.c:4662:58: warning: format '%p' expects argument of type 'void *', but argument 3 has type 'DeviceIntPtr {aka struct _DeviceIntRec *}' [-Wformat=]
fprintf(stderr, "\nKeyboard device state: \n\tdevice [%p]\n\tlast grab time [%lu]"
^
Events.c:4662:82: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'CARD32 {aka unsigned int}' [-Wformat=]
fprintf(stderr, "\nKeyboard device state: \n\tdevice [%p]\n\tlast grab time [%lu]"
^
Events.c:4662:19: warning: format '%p' expects argument of type 'void *', but argument 7 has type 'GrabPtr {aka struct _GrabRec *}' [-Wformat=]
fprintf(stderr, "\nKeyboard device state: \n\tdevice [%p]\n\tlast grab time [%lu]"
^
Events.c:4675:66: warning: format '%p' expects argument of type 'void *', but argument 3 has type 'WindowPtr {aka struct _Window *}' [-Wformat=]
fprintf(stderr, "\nKeyboard grab state: \n\twindow pointer [%p]"
^
Events.c:4689:59: warning: format '%p' expects argument of type 'void *', but argument 3 has type 'DeviceIntPtr {aka struct _DeviceIntRec *}' [-Wformat=]
fprintf(stderr, "\nPassive grab state: \n\tdevice [%p]\n\towner events flag [%s]"
^
Events.c:4689:23: warning: format '%lx' expects argument of type 'long unsigned int', but argument 10 has type 'Mask {aka unsigned int}' [-Wformat=]
fprintf(stderr, "\nPassive grab state: \n\tdevice [%p]\n\towner events flag [%s]"
^
Events.c:4722:57: warning: format '%p' expects argument of type 'void *', but argument 3 has type 'DeviceIntPtr {aka struct _DeviceIntRec *}' [-Wformat=]
fprintf(stderr, "\nPointer device state: \n\tdevice [%p]\n\tlast grab time [%lu]"
^
Events.c:4722:81: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'CARD32 {aka unsigned int}' [-Wformat=]
fprintf(stderr, "\nPointer device state: \n\tdevice [%p]\n\tlast grab time [%lu]"
^
Events.c:4722:19: warning: format '%p' expects argument of type 'void *', but argument 7 has type 'GrabPtr {aka struct _GrabRec *}' [-Wformat=]
fprintf(stderr, "\nPointer device state: \n\tdevice [%p]\n\tlast grab time [%lu]"
^
Events.c:4735:65: warning: format '%p' expects argument of type 'void *', but argument 3 has type 'WindowPtr {aka struct _Window *}' [-Wformat=]
fprintf(stderr, "\nPointer grab state: \n\twindow pointer [%p]"
^
Events.c:4750:61: warning: format '%p' expects argument of type 'void *', but argument 3 has type 'DeviceIntPtr {aka struct _DeviceIntRec *}' [-Wformat=]
fprintf(stderr, "\nPassive grab state: \n\tdevice [%p]\n\towner events flag [%s]"
^
Events.c:4750:25: warning: format '%lx' expects argument of type 'long unsigned int', but argument 10 has type 'Mask {aka unsigned int}' [-Wformat=]
fprintf(stderr, "\nPassive grab state: \n\tdevice [%p]\n\towner events flag [%s]"
^
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NXxvdisp.c: In function 'ProcXvDispatch':
NXxvdisp.c:96:9: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else
^~~~
NXxvdisp.c:99:13: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
break;
^~~~~
NXxvdisp.c:104:9: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else
^~~~
NXxvdisp.c:107:10: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
break;
^~~~~
NXxvdisp.c:118:2: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else
^~~~
NXxvdisp.c:121:13: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
break;
^~~~~
NXxvdisp.c:126:2: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else
^~~~
NXxvdisp.c:129:13: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
break;
^~~~~
NXxvdisp.c:137:2: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else
^~~~
NXxvdisp.c:140:13: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
break;
^~~~~
NXxvdisp.c:146:2: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else
^~~~
NXxvdisp.c:149:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
break;
^~~~~
|
|
|
|
|
|
|
|
|
|
| |
NXdispatch.c: In function 'Dispatch':
NXdispatch.c:309:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (!(dispatchException & DE_TERMINATE))
^~
NXdispatch.c:312:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
while (!dispatchException)
^~~~~
|
|
|
|
|
|
|
|
|
|
| |
chgfctl.c: In function 'ChangeKbdFeedback':
chgfctl.c:359:6: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else
^~~~
chgfctl.c:361:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
kctrl.autoRepeats[inx] =
^~~~~
|
| |
|
|
|
|
|
| |
nxagentInitKeyboardState -> nxagentInitXkbKeyboardState
nxagentHandleKeyboardEvent -> nxagentHandleXkbKeyboardStateEvent
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
If xorg upstream xkb gets extended one day the previous code would not
block new xkb calls even if they would change keyboard settings. So
only act on the currently known calls and throw an error for all
unknown calls.
|
| |
|