Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Window.c: Fix 32bit code path | Ulrich Sibiller | 2021-02-03 | 1 | -10/+10 |
| | | | | | | | | make it compile again Thanks to Simon Matter for reporting this and the patch. Fixes ArcticaProject/nx-libs#993 | ||||
* | nxagent: drop unused nxagentVisibility variables | Ulrich Sibiller | 2021-02-03 | 3 | -6/+0 |
| | |||||
* | Xext: drop NX_ALTERNATIVEPOLICYFILE | Ulrich Sibiller | 2021-01-18 | 1 | -202/+0 |
| | | | | | | We can now also drop all remaining NX specific lines from the security.c see ArcticaProject/nx-libs#988 | ||||
* | Xext: use $USRDATADIR/SecurityPolicy | Ulrich Sibiller | 2021-01-18 | 1 | -3/+2 |
| | | | | | | | | This reflects the path where the file is placed after installation. It also obsoletes the NX_ALTERNATIVEPOLICYFILE. Fixes ArcticaProject/nx-libs#988 | ||||
* | Args.c: improve usage string for -geometry | Ulrich Sibiller | 2021-01-16 | 1 | -1/+1 |
| | |||||
* | Screen.c: remove superflous code that produces a crash | Ulrich Sibiller | 2021-01-16 | 1 | -6/+0 |
| | | | | Fixes ArcticaProject/nx-libs#987 | ||||
* | Xext: include limits.h | Ulrich Sibiller | 2021-01-16 | 1 | -0/+1 |
| | | | | | | Is required for compilations with musl. See ArcticaProjects/nx-libs#975 and ArcticaProjects/nx-libs#976 | ||||
* | Display.c: fix and reformat broken comment | Ulrich Sibiller | 2021-01-16 | 1 | -12/+11 |
| | |||||
* | Window.c: suppress warning | Ulrich Sibiller | 2021-01-16 | 1 | -1/+1 |
| | | | | | | | | This used to be printed only in TEST mode. Some while ago I had changed that to WARNING (because it is a warning...). However, this happens e.g. when running the xscreensaver vfeedback module and it does not look like it is a problem at all. So let's suppress this warning again and leave it to the TEST mode as it used to be. | ||||
* | fix formatting and spelling in various files | Ulrich Sibiller | 2021-01-16 | 8 | -14/+13 |
| | |||||
* | nxagent: Drop unused nxagentRootTileWindow | Ulrich Sibiller | 2021-01-16 | 2 | -4/+0 |
| | |||||
* | Handlers.c: add FIXME | Ulrich Sibiller | 2021-01-16 | 1 | -0/+3 |
| | |||||
* | Screen.c: clarify that characters are compared | Ulrich Sibiller | 2021-01-16 | 1 | -2/+2 |
| | |||||
* | Client.h: conditionally add unused field | Ulrich Sibiller | 2021-01-16 | 1 | -2/+5 |
| | |||||
* | Handlers.c: use the same boolean values as in NXdispatch.c | Ulrich Sibiller | 2021-01-16 | 1 | -2/+2 |
| | | | | although there is no functional difference... | ||||
* | manpage: document defaults for options -defer and -tile | Ulrich Sibiller | 2021-01-16 | 1 | -1/+11 |
| | |||||
* | NXDispatch.c: remove double nxagentFreeAtomMap() | Ulrich Sibiller | 2021-01-16 | 1 | -1/+0 |
| | |||||
* | Window.c: check for malloc failure | Ulrich Sibiller | 2021-01-15 | 1 | -13/+22 |
| | | | | PVS finding: "V522 There might be dereferencing of a potential null pointer 'props'" | ||||
* | Window.c: check for malloc failure | Ulrich Sibiller | 2021-01-15 | 1 | -0/+8 |
| | | | | PVS finding: "V522 There might be dereferencing of a potential null pointer 'nxagentConfiguredWindowList'." | ||||
* | Screen.c: check for malloc failures | Ulrich Sibiller | 2021-01-15 | 1 | -0/+39 |
| | | | | PVS finding: "V522 There might be dereferencing of a potential null pointer" | ||||
* | Splash.c: remove unneccessary check | Ulrich Sibiller | 2021-01-15 | 1 | -9/+4 |
| | | | | PVs finding: "V547 Expression '!nxagentWMPassed' is always true." | ||||
* | Rootless.c: prevent PVS error | Ulrich Sibiller | 2021-01-15 | 1 | -1/+2 |
| | | | | "V547 Expression 'wmHints.input == 1' is always true." | ||||
* | Render.c: Init BoxRec | Ulrich Sibiller | 2021-01-15 | 1 | -1/+1 |
| | | | | PVS Studio: "V614 Potentially uninitialized variable 'glyphBox.*' used." | ||||
* | Reconnect.c: fix possible realloc() memory loss | Ulrich Sibiller | 2021-01-15 | 1 | -2/+6 |
| | | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'nxagentReconnectErrorMessage' is lost. Consider assigning realloc() to a temporary pointer." | ||||
* | NXglyph.c: check for malloc error | Ulrich Sibiller | 2021-01-15 | 1 | -0/+7 |
| | | | | | "V575 The potential null pointer is passed into 'memcpy' function. Inspect the first argument." | ||||
* | Keyboard.c: fix possible NULL pointer dereference | Ulrich Sibiller | 2021-01-15 | 1 | -0/+5 |
| | | | | | found by PVS Studio: "V522 There might be dereferencing of a potential null pointer 'keymap'." | ||||
* | Drawable.c: Prevent PVS Studio warning | Ulrich Sibiller | 2021-01-15 | 1 | -1/+3 |
| | | | | | "V560 A part of conditional expression is always true: oldStatus == NotSynchronized." | ||||
* | Display.c: prevent PVS Studio realloc warning | Ulrich Sibiller | 2021-01-15 | 1 | -5/+11 |
| | | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'nxagentDefaultColormaps' is lost. Consider assigning realloc() to a temporary pointer." | ||||
* | Atoms.c: add explanation for PVS Studio warning | Ulrich Sibiller | 2021-01-15 | 1 | -0/+3 |
| | | | | | "V575 The potential null pointer is passed into 'strlen' function. Inspect the first argument. Check lines: 420, 403." | ||||
* | NXpicture.c: remove unneccessary check | Ulrich Sibiller | 2021-01-15 | 1 | -15/+12 |
| | | | | | | | Code can only be reached if pPicture is non-NULL. Besides, pPicture will be accessed later anyway, regardless of this check. Finding of PVS Studio: "V547 Expression 'pPicture != NULL' is always true." | ||||
* | Keyboard.c: simplify code | Ulrich Sibiller | 2021-01-15 | 1 | -5/+3 |
| | | | | Based on PVS Studio finding: "V547 Expression 'data' is always true." | ||||
* | Colormap.c: remove unneccessary check | Ulrich Sibiller | 2021-01-15 | 1 | -1/+1 |
| | | | | | | | | success would always be true at the beginning of the loop as it is part of the loop condition. Finding from PVS Studio: "V560 A part of conditional expression is always true: success." | ||||
* | Colormap.c: fix parentheses | Ulrich Sibiller | 2021-01-15 | 1 | -1/+1 |
| | | | | | | PVS Studio: "V592 The expression was enclosed by parentheses twice: '((* pRed * (limg + 1)))'. One pair of parentheses is unnecessary or misprint is present." | ||||
* | Atoms.c: silence PVS Studio warning | Ulrich Sibiller | 2021-01-15 | 1 | -2/+6 |
| | | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'privAtomMap' is lost. Consider assigning realloc() to a temporary pointer." | ||||
* | Atoms.c: cosmetics in nxagentWriteAtom() | Ulrich Sibiller | 2021-01-15 | 1 | -1/+2 |
| | |||||
* | Atoms.c: fix strlen(NULL) | Ulrich Sibiller | 2021-01-15 | 1 | -1/+1 |
| | | | | | FIX PVS Studio finding "V575 The potential null pointer is passed into 'strlen' function. Inspect the first argument" | ||||
* | nxagent: make full screen mode selectable at startup | Ulrich Sibiller | 2021-01-15 | 4 | -9/+33 |
| | | | | | | | | fullscreen= now accepts the new value "2" for a fullscreen covering only one screen. -geometry and geometry= now know additional keywords "allscreens" and "onescreen". Fixes ArcticaProject/nx-libs#923 | ||||
* | Revert "CVE-2020-14360: Check SetMap request length carefully." | Mike Gabriel | 2021-01-15 | 1 | -91/+0 |
| | | | | This reverts commit 4eba4f53ad8c62c27c12835e58184d66121ff636. | ||||
* | nxagent: nxagent(Default)WindowIsVisible() are Booleans | Ulrich Sibiller | 2021-01-15 | 4 | -7/+7 |
| | |||||
* | Keyboard.c: noXkbExtension is a Boolean | Ulrich Sibiller | 2021-01-15 | 1 | -2/+2 |
| | |||||
* | Font.c: Use Booleans where appropriate | Ulrich Sibiller | 2021-01-15 | 1 | -16/+16 |
| | |||||
* | nxagent: make nxagentXkbState.Initialized a Boolean | Ulrich Sibiller | 2021-01-15 | 4 | -7/+6 |
| | |||||
* | Events.h: fix wrong prototype | Ulrich Sibiller | 2021-01-15 | 1 | -1/+1 |
| | |||||
* | nxagent: make nxagentXFixesInfo.Initialized a Boolean | Ulrich Sibiller | 2021-01-15 | 3 | -4/+4 |
| | |||||
* | Drawable.c: make doRoundRobin a Boolean | Ulrich Sibiller | 2021-01-15 | 1 | -4/+4 |
| | |||||
* | Handlers.c: make synchronize a Boolean variable | Ulrich Sibiller | 2021-01-15 | 1 | -3/+3 |
| | |||||
* | nxagent: make nxagentSkipImage a Boolean | Ulrich Sibiller | 2021-01-15 | 2 | -3/+3 |
| | |||||
* | nxagent: make nxagentForceSynchronization a Boolean | Ulrich Sibiller | 2021-01-15 | 5 | -6/+6 |
| | |||||
* | Drawable.c: make abort flag a Boolean | Ulrich Sibiller | 2021-01-15 | 2 | -17/+17 |
| | |||||
* | Client.c: cleanup Boolean handling for nxagentNeedWakeup*() macros | Ulrich Sibiller | 2021-01-15 | 1 | -6/+6 |
| |