aboutsummaryrefslogtreecommitdiff
path: root/nx-X11/programs
Commit message (Collapse)AuthorAgeFilesLines
* NXproperty.c: fix comment/formattingUlrich Sibiller2020-05-071-2/+1
|
* Window.c: scope improvementsUlrich Sibiller2020-05-071-66/+42
| | | | plus some whitespace improvements
* NXresource.c: scope improvementsUlrich Sibiller2020-05-071-16/+6
|
* NXresource.c: Fix uninitialized variableUlrich Sibiller2020-05-071-1/+1
| | | | | | Static analyzer reported: (error) Uninitialized variable: elements Attributes ArcticaProject/nx-libs#905
* NXresource.c: rework marked nx codeUlrich Sibiller2020-05-071-61/+29
| | | | | Improve visibility by unindenting. Also move the ifdefs _before_ the according comments. Finally merge ifdefs to fewer blocks.
* NXproperty.c: fix implicit declarationUlrich Sibiller2020-05-071-0/+4
| | | | | | | | | | Fix warning with NX_DEBUG_INPUT: NXproperty.c: In function ‘ProcChangeProperty’: NXproperty.c:210:7: warning: implicit declaration of function ‘nxagentGuessDumpInputInfo’; did you mean ‘nxagentGuessClientHint’? [-Wimplicit-function-declaration] nxagentGuessDumpInputInfo(client, stuff->property, (char *) &stuff[1]); ^~~~~~~~~~~~~~~~~~~~~~~~~ nxagentGuessClientHint
* Display.c: fix implicit declarationUlrich Sibiller2020-05-071-0/+1
| | | | | | | | Display.c: In function ‘nxagentResetDisplayHandlers’: Display.c:901:5: warning: implicit declaration of function ‘nxagentReleaseAllSplits’; did you mean ‘nxagentWakeupBySplit’? [-Wimplicit-function-declaration] nxagentReleaseAllSplits(); ^~~~~~~~~~~~~~~~~~~~~~~ nxagentWakeupBySplit
* Display.c: fix common realloc mistakeUlrich Sibiller2020-05-071-2/+7
| | | | | As reported by static analyzer: (error) Common realloc mistake: 'nxagentVisuals' nulled but not freed upon failure
* Rootless.c: fix common realloc mistakeUlrich Sibiller2020-05-071-2/+1
| | | | | | | As reported by static analyzer: (error) Common realloc mistake: 'ptr' nulled but not freed upon failure Attributes ArcticaProject/nx-libs#905
* NXdispatch.c, Reconnect.c: fix format specifiersUlrich Sibiller2020-05-072-3/+3
| | | | | | | | | | | | | | | | | | | | | | Fix these warnings with NX_DEBUG_INPUT enabled: NXdispatch.c: In function ‘Dispatch’: NXdispatch.c:350:74: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=] fprintf(stderr, "Session: Session started at '%s' timestamp [%lu].\n", ~~^ %u GetTimeAsString(), GetTimeInMillis()); Reconnect.c: In function ‘nxagentHandleConnectionStates’: Reconnect.c:303:74: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=] fprintf(stderr, "Session: Session suspended at '%s' timestamp [%lu].\n", GetTimeAsString(), GetTimeInMillis()); ~~^ ~~~~~~~~~~~~~~~~~ %u Reconnect.c: In function ‘nxagentReconnectSession’: Reconnect.c:673:66: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=] fprintf(stderr, "Session: Session resumed at '%s' timestamp [%lu].\n", GetTimeAsString(), GetTimeInMillis()); ~~^ ~~~~~~~~~~~~~~~~~ %u
* NXdispatch.c: fix invalid number of character '('Ulrich Sibiller2020-05-071-1/+1
| | | | | | As reported by static analyzer. Attributes ArcticaProject/nx-libs#905
* NXdispatch.c: some cleanupUlrich Sibiller2020-05-071-25/+23
|
* NXdispatch.c: whitespace fixUlrich Sibiller2020-05-071-1/+1
|
* Screen.h: improve NXAGENT_ARTSD prototype definitionUlrich Sibiller2020-05-072-3/+2
|
* (NX)property.c: harmonize function nameUlrich Sibiller2020-05-072-2/+2
| | | | Use the "xorg_" prefix as everywhere else, not "Xorg_".
* NXdixfonts.c: mark NX changesUlrich Sibiller2020-05-071-52/+107
| | | | | Also add original code to make NX changes obvious. Also change some lines to match original code.
* NXdixfonts.c: drop NXAGENT_DEBUGUlrich Sibiller2020-05-072-36/+35
| | | | | | | and use DEBUG like everywhere else. There were already some TEST lines using this scheme. Also indent DEBUG and TEST lines to make the code more readable
* NXdixfonts.c: call dix version of SetDefaultFontPathUlrich Sibiller2020-05-072-73/+6
|
* Keystroke.c: fix typoUlrich Sibiller2020-05-071-1/+1
| | | | make compilation work with -DNX_DEBUG_INPUT
* WaitFor.c Implement the intended NX_WAKEUP functionalityUlrich Sibiller2020-05-073-12/+14
| | | | NX_WAKEUP had been non-effective and its effect had been tied to NX_TRANS_WAKEUP.
* os/Waitfor.c: simplify macro handlingUlrich Sibiller2020-05-071-59/+56
| | | | | | | | | | 1. indent ifdefs 2. add some logic at start that unset NX_TRANS_WAKEUP and NX_TRANS_DEBUG if NX_TRANS_SOCKET is unset. This way we only have to check for one macro and not all three. 3. remove redundant macro checks 4. decouple debug printfs by always running the original code and adding the identical check in #ifdef NX_TRANS_DEBUG
* hw/nxagent/Imakefile: explain more macrosUlrich Sibiller2020-05-071-10/+14
| | | | and remove obsolete NX_SPLASH
* Dialog.c: show configured keystrokes in dialogsUlrich Sibiller2020-05-074-33/+144
| | | | | | | | Instead of hardcoding the keystrokes in Dialog.h determine the currently configured keystrokes for the action and insert them into the dialog strings. Fixes ArcticaProject/nx-libs#438
* nxagent: make all traps BooleansUlrich Sibiller2020-05-0714-102/+100
| | | | and use True/False instead of 1/0
* Literals.h: always include in compilationUlrich Sibiller2020-05-074-7/+2
| | | | | | This change ensures Literals.h is always referenced during compilation, effectively hiding it from "unused file" detection we do occasionally to clean up the source code.
* Init.c Use dpmsstubs.c instead of an own copyUlrich Sibiller2020-05-072-27/+2
| | | | | | | | | | | | | | | | | Derived from commit 978f3b496b9951ee8120a0efcc5cd12503e26770 Author: Roland Mainz <roland.mainz@nrubsig.org> Date: Sat Mar 5 21:38:29 2005 +0000 xc/programs/Xserver/Imakefile xc/programs/Xserver/hw/xnest/Imakefile //bugs.freedesktop.org/show_bug.cgi?id=2653) attachment #2020 (https://bugs.freedesktop.org/attachment.cgi?id=2020): Cleanup Xnest usage of the DPMS dummy stub functions from dpmsstubs.c instead of using it's own copy of these functions. Fixes ArcticaProject/nx-libs#901
* dix: also compile ffs.cUlrich Sibiller2020-05-071-0/+2
| | | | | File was missing in Imakefile. We are not using the ffs function, but nevertheless it's a part of dix.
* Clarify use of and need for mffs vs. ffsUlrich Sibiller2020-05-073-3/+5
| | | | | | | | | | | | Backport of this xorg-xserver commit: commit 75c51c67b340548286efd41a53882e2acaf74ab5 Author: Alan Coopersmith <alan.coopersmith@sun.com> Date: Thu Jun 18 09:49:12 2009 -0700 Clarify use of and need for mffs vs. ffs Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
* Drop unused screensaver xpmUlrich Sibiller2020-05-071-711/+0
| | | | See ArcticaProject/nx-libs#263 for discussion
* Drop unused rgb.hUlrich Sibiller2020-05-071-53/+0
|
* Splash.c: reduce number of X calls for logo paintingUlrich Sibiller2020-05-071-117/+20
| | | | Instead of 17 XFillPolygon() calls we now use 5.
* Splash.c: reduce number of Xlib callsUlrich Sibiller2020-05-071-10/+24
|
* Splash.c: always paint background over the whole windowUlrich Sibiller2020-05-071-3/+3
| | | | Was wrong when scale was different from 1
* Splash.c: move the GC to nxagentPaintLogoUlrich Sibiller2020-05-071-5/+7
| | | | It is not needed elsewhere.
* Splash.h: split out xdmcp parts into separate header fileUlrich Sibiller2020-05-074-12/+43
|
* Splash.c: make variables staticUlrich Sibiller2020-05-071-3/+3
| | | | They are not used from the outside.
* Splash.c: use uppercase color definesUlrich Sibiller2020-05-071-10/+10
|
* Splash.c: some reformattingUlrich Sibiller2020-05-071-13/+9
|
* Splash.c: use more Xlib typesUlrich Sibiller2020-05-073-15/+12
|
* Splash.c: add nxagentHaveSplashWindow helperUlrich Sibiller2020-05-074-2/+8
|
* Splash.c: center logoUlrich Sibiller2020-05-071-78/+104
| | | | | | was offset to the right and downwards before Fixes ArcticaProject/nx-libs#892
* Splash.c: fix syntax error in TEST modeUlrich Sibiller2020-05-071-1/+1
|
* xkb/xkbUtils.c: add link to bugreportUlrich Sibiller2020-05-071-1/+5
| | | | | | | | The problem we are fixing (or better "working around") here has also been seen in XQuartz, but no-one has found the reason yet. Point to bugreport so that anyone stumbling over this in future can check if there's a better fix and possibly implement that one.
* Xext: rename saver's EventType to SaverEventType.Ulrich Sibiller2020-05-071-5/+5
| | | | | | | | | | | | | | Backport of this xorg-xserver commit: commit cfd3443fe81685e91a53063dee58e24a5684dc29 Author: Peter Hutterer <peter.hutterer@who-t.net> Date: Wed Jan 28 13:34:10 2009 +1000 Xext: rename saver's EventType to SaverEventType. Avoid namespace clashing with the internal events. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Xext: Fix cursor reference counting hazard.Ulrich Sibiller2020-05-071-1/+1
| | | | | | | | | | | | | | | | | | | Backport of this xorg-xserver patch: commit 3083c5d0c4386cdd7083b7a83ac72fdad2f1e61e Author: Michel Dänzer <daenzer@vmware.com> Date: Mon Mar 22 18:01:17 2010 +0100 Xext: Fix cursor reference counting hazard. Make sure the reference count of the new cursor is increased before the old one is decreased, otherwise bad things will happen if they're one and the same and the reference count is 1 initially. Not sure this can actually happen here, but better safe than sorry. Signed-off-by: Michel Dänzer <daenzer@vmware.com> Reviewed-by: Roland Scheidegger <sroland@vmware.com> Signed-off-by: Keith Packard <keithp@keithp.com>
* Render.c: describe function purposeUlrich Sibiller2020-05-071-0/+1
| | | | (from nxagent changelog)
* Render.c: replace two while loops by shorter for loopsUlrich Sibiller2020-05-071-9/+3
|
* Rootless.c: undo overzealous scope improvementUlrich Sibiller2020-05-071-3/+3
| | | | It is better to create the values array once and not on every iteration..
* nxagent: simplify nxagentFreeRegion macroUlrich Sibiller2020-05-075-23/+22
| | | | | | Does not require two parameters. It could be replaced by RegionDestroy() entirely but we leave it to have a match to nxagentCreateRegion().
* Drawable.c: get rid of goto code in nxagentSynchronizeDrawableDataUlrich Sibiller2020-05-071-16/+4
| | | | | Now all cleanup code at the end of the function is gone so there's no need for the gotos anymore. Just return directly.