Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Display.c: drop helper variable in loop | Ulrich Sibiller | 2018-01-07 | 1 | -4/+2 |
| | |||||
* | Error.c: replace malloc+strcpy by strdup | Ulrich Sibiller | 2018-01-07 | 1 | -5/+3 |
| | |||||
* | Events.c: add FIXME | Ulrich Sibiller | 2018-01-07 | 1 | -0/+1 |
| | |||||
* | Keyboard.c: rework string allocation/building | Ulrich Sibiller | 2018-01-07 | 1 | -14/+10 |
| | |||||
* | Keystroke.c: replace calloc + 2 * strcpy by asprintf | Ulrich Sibiller | 2018-01-07 | 1 | -3/+1 |
| | |||||
* | Font.c: replace malloc + strcpy by strdup + fix memleak | Ulrich Sibiller | 2018-01-07 | 1 | -2/+3 |
| | |||||
* | Font.c: free possibly allocated mem | Ulrich Sibiller | 2018-01-07 | 1 | -0/+5 |
| | | | | even if we issue a FatalError afterwards | ||||
* | Font.c: replace memcpy by sprintf preventing possible buffer overflows | Ulrich Sibiller | 2018-01-07 | 1 | -9/+3 |
| | | | | | | I am not sure about the maximum font name length in X but just in case use snprintf instead of memcpy to be sure nothing dangerous can happen here. | ||||
* | Args.c: simplify nxagentGetDialogName() | Ulrich Sibiller | 2018-01-07 | 1 | -11/+4 |
| | |||||
* | Args.c, Error.[ch]: introduce own length macro for nxagentClientsLogName | Ulrich Sibiller | 2018-01-07 | 3 | -5/+6 |
| | |||||
* | Args.c: use strdup instead of malloc | Ulrich Sibiller | 2018-01-07 | 1 | -35/+7 |
| | |||||
* | Error.c: update nxagentPrintError | Ulrich Sibiller | 2018-01-07 | 1 | -6/+8 |
| | | | | | | | This is a partial copy from XlibInt.c's _XPrintDefaultError, which had some minor changes since being copied. Update to reflect these changes. Also comment some more lines as their result was unused an cluttered the output. | ||||
* | Error.c: replace strcpy/strcat by snprintf | Ulrich Sibiller | 2018-01-07 | 2 | -21/+13 |
| | |||||
* | Error.c: use standard file descriptor macros | Ulrich Sibiller | 2018-01-07 | 1 | -3/+3 |
| | |||||
* | Error.c: remove trailing whitespace | Ulrich Sibiller | 2018-01-07 | 1 | -5/+5 |
| | | | | and insert one single space | ||||
* | Error.c: remove empty ifdef | Ulrich Sibiller | 2018-01-07 | 1 | -4/+0 |
| | |||||
* | Font.c: pass down size | Ulrich Sibiller | 2018-01-07 | 1 | -6/+5 |
| | |||||
* | Display.c: pass down buffer size to nxagentLookForIconFile | Ulrich Sibiller | 2018-01-07 | 1 | -24/+22 |
| | | | | Also comment the code and convert error messages to warnings. | ||||
* | Replace hardcoded string lengths by macros | Ulrich Sibiller | 2018-01-07 | 6 | -69/+43 |
| | |||||
* | Font.c: make nxagentGetFontServerPath more readable | Ulrich Sibiller | 2018-01-07 | 1 | -4/+5 |
| | |||||
* | Screen.c: string handling improvements | Ulrich Sibiller | 2018-01-07 | 1 | -16/+10 |
| | |||||
* | Font.c: shorten string handling | Ulrich Sibiller | 2018-01-07 | 1 | -18/+7 |
| | |||||
* | Keyboard.c: replace malloc + strcpy by asprintf | Ulrich Sibiller | 2018-01-07 | 1 | -6/+4 |
| | |||||
* | Keyboard.c: improve user messages for keyboard file handling | Ulrich Sibiller | 2018-01-07 | 1 | -1/+1 |
| | |||||
* | Keyboard.c: fix memory leak | Ulrich Sibiller | 2018-01-07 | 1 | -1/+3 |
| | |||||
* | Dialog.c: fix possible buffer overflows | Ulrich Sibiller | 2018-01-07 | 1 | -0/+13 |
| | | | | Fix write past the end of singlePath if PATH contains dirs longer than PATH_MAX. | ||||
* | Dialog.c,Display.c,NXdixfonts.c: replace strncpy() by snprintf where appropriate | Ulrich Sibiller | 2018-01-07 | 5 | -17/+11 |
| | |||||
* | Dialog.c,Display.c,Font.c,NXdixfonts.c: don't use hardcoded string buffer ↵ | Ulrich Sibiller | 2018-01-07 | 4 | -20/+18 |
| | | | | lengths | ||||
* | nx-X11: reintroduce creation of libX11 compat symlinks. | Mihai Moldovan | 2017-12-30 | 2 | -0/+25 |
| | | | | | We need this to be able to execute the resulting nxagent binary from within the build directory. | ||||
* | nx-X11: build programs with a temporary RPATH/RUNPATH value and a relinked ↵ | Mihai Moldovan | 2017-12-30 | 7 | -10/+78 |
| | | | | | | | | | version with the system location. While the install target explicitly installs the relinked system-location version of a program, we do not actually use this. Currently, we copy nxagent directly out of the build root. | ||||
* | nx-X11/config/cf/{gnu,lnx}Lib.rules: enable new ELF dtags to force RUNPATH ↵ | Mihai Moldovan | 2017-12-30 | 2 | -6/+6 |
| | | | | creation for nxagent. | ||||
* | nxagent: implement RPATH/RUNPATH override for libX11. | Mihai Moldovan | 2017-12-30 | 3 | -2/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed in ArcticaProject/nx-libs#610, we need a way to load libNX_X11 as a fake version of libX11 into nxagent's address space. For doing so, we have to link against libX11 at build-time and specify a(n) RPATH/RUNPATH to our libX11 -> libNX_X11 compat symlinks. This commit is essentially doing a cross between options 3 and 4 discussed in the provided GH issue. We link libX11 early (before specifying -Lcompat_symlinks_dir), so that the linker finds the "real" libX11 version with the libX11 SONAME. This leads to our binary depending upon both libX11 and libNX_X11 SONAMEs. We already always added RPATH/RUNPATH, but these values are not passed down to dependent libraries. What happens at run-time is that the loader searches for a libX11 SONAME, takes RPATH/RUNPATH into account and loads our libNX_X11 library instead via the compat symlinks. This satisfies the libX11 SONAME and dependent libraries will *not* load the system libX11 version again. Debian's dpkg-shlibdeps isn't quite happy about this mismatching SONAME situation, so instruct to look the other way while we're minding our business. Fixes: ArcticaProject/nx-libs#610 | ||||
* | reduce usage of uninitialised bytes | Ulrich Sibiller | 2017-12-28 | 12 | -104/+86 |
| | | | | as reported by valgrind | ||||
* | nx-X11/programs/Xserver/hw/nxagent/Screen.c: re-enable normal error/warning ↵ | Mihai Moldovan | 2017-12-24 | 1 | -2/+2 |
| | | | | | | output. Was dropped erroneously in cec31e2f06b29b332ee78cfefeefa7bfa136be75. | ||||
* | nx-X11/programs/Xserver/hw/nxagent/Screen.c: update screen size after ↵ | Mihai Moldovan | 2017-12-24 | 1 | -0/+7 |
| | | | | | | | modifying CRTC modes. This should get rid of the infamous "800x600 screen size" issue reproduced in X2Go whole display setups. | ||||
* | nx-X11/extras/Mesa.patches_6.4.2/4002_no-special-glx-memfunctions.patch: ↵ | Mihai Moldovan | 2017-12-19 | 1 | -5/+6 |
| | | | | | | | include stdlib.h and string.h for memset, malloc and free prototypes. Without that they are only implicitly defined - leading to build failures on *SUSE. | ||||
* | Drop SHMNAME workaround again, it *is* defined in shmstr.h, which is ↵ | Mihai Moldovan | 2017-12-16 | 3 | -8/+2 |
| | | | | actually header I was searching for. | ||||
* | nx-X11/programs/Xserver/Xext/shape.c: avoid pulling in Xlib in legacy mode ↵ | Mihai Moldovan | 2017-12-16 | 1 | -0/+7 |
| | | | | via the _SHAPE_SERVER_ macro. | ||||
* | nx-X11/programs/Xserver/Xext/shape.c: pull in shapestr.h for legacy Xext ↵ | Mihai Moldovan | 2017-12-16 | 1 | -1/+1 |
| | | | | proto versions, since shape.h would pull in Xlib. | ||||
* | Handle SHAPE proto splitup gracefully for legacy Xext proto versions. | Mihai Moldovan | 2017-12-16 | 1 | -0/+4 |
| | |||||
* | zlib compatibility: whenever we want -I flags only, assume that the headers ↵ | Mihai Moldovan | 2017-12-16 | 2 | -3/+3 |
| | | | | | | are directly available. Especially don't add linking flags willy-nilly. | ||||
* | nx-X11/programs/Xserver/include/misc.h: add compat define for SHMNAME. | Mihai Moldovan | 2017-12-16 | 1 | -0/+6 |
| | |||||
* | Support building with legacy zlib versions that do not ship a pkg-config file. | Mihai Moldovan | 2017-12-16 | 3 | -4/+4 |
| | |||||
* | Support building with legacy (pre-7.1.0) Xext proto versions. | Mihai Moldovan | 2017-12-16 | 5 | -1/+29 |
| | | | | | Legacy Xext proto versions are automatically detected by the main Makefile. | ||||
* | Support building with legacy (pre-1.4.2) libXfont(1) versions. | Mihai Moldovan | 2017-12-16 | 5 | -0/+28 |
| | | | | | | | | Partly reverts ec30a857eb0d67b232f8d43e63a6370023f4c4d0, but in a forward-compatible manner. Legacy libXfont1 versions are automatically detected by the main Makefile. | ||||
* | {nx-X11/lib,nxproxy}/Makefile.am: also use correct aclocal flags in the ↵ | Mihai Moldovan | 2017-12-15 | 1 | -0/+2 |
| | | | | other locations. | ||||
* | nx-X11/config/cf/linux.cf: recursive macros aren't a thing. | Mihai Moldovan | 2017-12-15 | 1 | -1/+1 |
| | | | | Just copy-paste the initial definition to avoid recursion. | ||||
* | nx-X11/config/cf/linux.cf: don't override default CC options for ↵ | Mihai Moldovan | 2017-12-15 | 1 | -4/+1 |
| | | | | | | {ARM,PPC}{32,64}. We need -std=c99 to be passed through to the build process. | ||||
* | release 3.5.99.123.5.99.12 | Mike Gabriel | 2017-12-15 | 1 | -1/+1 |
| | |||||
* | Xserver/hw/nxagent/Image.c: Fix regression FTBFS after d4465b71 got merged in. | Mike Gabriel | 2017-12-15 | 1 | -4/+4 |
| |