aboutsummaryrefslogtreecommitdiff
path: root/nx-X11
Commit message (Collapse)AuthorAgeFilesLines
* NXdispatch.c: move nxagentWMtimeout into the functionUlrich Sibiller2019-08-271-8/+3
| | | | it is only used there, no need for a global variable
* NXdispatch.c: drop currentDispatch variableUlrich Sibiller2019-08-271-13/+8
| | | | was only used once
* nxagent: move nxagentWMPassed to Splash.cUlrich Sibiller2019-08-274-13/+8
| | | | It is only relevant there.
* nxagent: add NXAGENT_ONSTART where missingUlrich Sibiller2019-08-272-0/+8
| | | | | There were some locations referenceing a variable that was only availabe with NXAGENT_ONSTART set
* nxagent: drop NXAGENT_SPLASHUlrich Sibiller2019-08-272-3/+0
| | | | There was only one (commented) section using it.
* nxagent: rename nxagentWMStart to nxagentReadyAtomUlrich Sibiller2019-08-272-5/+5
| | | | This better reflects its purpose: Tell listeners we are ready.
* Splash.c: move some variables to Splash.cUlrich Sibiller2019-08-272-2/+3
| | | | They belong there...
* Splash.c: make Splash logo work with white background (-wr) mode, tooUlrich Sibiller2019-08-271-22/+31
|
* Splash.c: remove global variables for colorsUlrich Sibiller2019-08-273-30/+8
| | | | Make them defines. Also determine the screen depth dynamically.
* nxagent: drop nxagentRootTileWindowUlrich Sibiller2019-08-274-150/+4
| | | | | | | | We either use a solid black or a white background and no backround pixmap. So nxagentRootTileWindow is always empty and we can drop all stuff around it. remove nxagentSplashCount, too, since it is no longer checked anywhere.
* Splash.c: nxagentRemoveSplashWindow: drop unused parameterUlrich Sibiller2019-08-275-7/+6
|
* Splash.c: code cleanupUlrich Sibiller2019-08-271-22/+22
|
* Splash.c: drop return code of nxagentShowSplashWindowUlrich Sibiller2019-08-272-5/+3
| | | | nobody was checking it.
* Splash.c: do not wait in nxagent modeUlrich Sibiller2019-08-273-17/+20
| | | | | | | The splash window is only shown in x2go mode. In nxagent mode the splash window was also shown, but empty (and thus invisible). And the code waited for the splash window to disappear. Fix this by skipping _all_ the splash stuff in nxagent mode.
* dix: add whiteroot flagUlrich Sibiller2019-08-273-3/+9
| | | | | | | | | | | | | | | | | Before there was no way of getting a white background despite having the approriate code. Backport of this commit: commit cb0a565d2b2cf8823abbd77b4426cc2237731dc1 Author: Daniel Stone <daniel@fooishbar.org> Date: Fri Aug 18 17:04:48 2006 +0300 dix: add whiteroot flag Add a -wr option to use a white root window, and use a BackPixel rather than BackPixmap for both white and black root windows. Fixes ArcticaProject/nx-libs#832
* NXwindow.c: simplify window background codeUlrich Sibiller2019-08-271-8/+4
|
* nxagent: fix main window being garbled without inner windowsUlrich Sibiller2019-08-271-2/+0
| | | | Fixes ArcticaProject/nx-libs#733
* nxagent: simplify nxagentWaitEvents()Ulrich Sibiller2019-08-167-35/+28
| | | | | no more need to pass down a struct, we now only pass the milliseconds and let the function do the rest.
* Keystroke.c: fix wrong return codeUlrich Sibiller2019-08-161-1/+4
| | | | | | The effect of this was that special keystrokes where detected and passed to the nxagent. E.g. pressing ctrl-alt-f for Fullscreen also produced an "f" in the current input window inside the nxagent.
* Events.c: add more comments and TEST outputUlrich Sibiller2019-08-061-3/+25
|
* Events.c: refactor nxagentHandleKeypressUlrich Sibiller2019-08-061-6/+4
|
* release 3.5.99.213.5.99.21Mike Gabriel2019-08-052-1/+1
|
* drop onscreen keyboard supportUlrich Sibiller2019-06-272-75/+1
| | | | | | | | | With the removal of the Ipaq code there's no path anymore to open the onscreen keyboard. Also nxkbd is not available and we do not have tested that feature with any onscreen keyboard yet. So there's no point in integrating that code. Fixes ArcticaProject/nx-libs#405
* Drop Ipaq supportUlrich Sibiller2019-06-276-61/+5
| | | | Did we ever provide a binary?
* Screen.c: use XlibWindow so silence the compilerUlrich Sibiller2019-06-271-2/+2
| | | | | | | | | | | | | | This is a bit weird, I'd expect far more places where the compiler could complain about Window vs Window64... But it does not. Screen.c:306:32: warning: passing argument 3 of ‘XQueryTree’ from incompatible pointer type [-Wincompatible-pointer-types] if (XQueryTree(d, candidate, &root, &parent, &children, &num_children)) ^~~~~ In file included from Screen.c:60: Agent.h:85:25: note: expected ‘Window64 *’ {aka ‘long unsigned int *’} but argument is of type ‘Window *’ {aka ‘unsigned int *’} #define Window Window64 ../../../../exports/include/nx-X11/Xlib.h:3041:5: note: in expansion of macro ‘Window’ Window* /* root_return */,
* Consistently use None instead of 0 for nxagentIconWindow everywhereUlrich Sibiller2019-06-272-2/+2
|
* Screen.c: simplify nxagentMinimizeFromFullscreenUlrich Sibiller2019-06-271-6/+9
|
* nxagentMaximizeToFullScreen: only reparent if necessaryUlrich Sibiller2019-06-271-21/+56
| | | | | | | | This fixes problems with kwin and compiz when using the switch-all-screens keystroke. The fullscreen would appear shortly and then vanish again. Fixes ArcticaProject/nx-libs#458
* Screen.c: add nxagentIsParentOf helperUlrich Sibiller2019-06-271-0/+22
|
* Window.c: rearrange code regarding window decorations sizesUlrich Sibiller2019-06-271-2/+9
|
* Window.c: add some comments about fullscreen handlingUlrich Sibiller2019-06-271-0/+12
|
* rework xkb device private handlingUlrich Sibiller2019-06-224-16/+23
| | | | | | | We can only free the xkbDevicePrivate because we do not know the details of any other (possible) extension. So let's limit to that one private for now and call the new xkbFreePrivates from dix (where such a function is completely missing).
* record/set.c: silence cpp findingUlrich Sibiller2019-06-221-1/+2
| | | | | | | | [nx-X11/programs/Xserver/record/set.c:361]: (warning) Possible null pointer dereference: stackIntervals stackIntervals is only NULL if nIntervals is 0, too. In that case memcpy will do nothing and so it is ok to pass NULL as source. But it is ugly nevertheless...
* Keyboard.c: use existing define instead of hardcoced valueUlrich Sibiller2019-06-221-1/+1
|
* Keyboard.c: fix another cppcheck findingUlrich Sibiller2019-06-221-1/+2
| | | | [Keyboard.c:559]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
* xkb: fix what looks to be a copy-paste error with first vs firstMMUlrich Sibiller2019-06-221-1/+1
| | | | | | | | | | | | commit 758393951233d1b2520cf4cefd33ec4288a3880a Author: Dave Airlie <airlied@redhat.com> Date: Wed Sep 12 11:09:40 2018 +1000 xkb: fix what looks to be a copy-paste error with first vs firstMM Pointed out by coverity. Signed-off-by: Dave Airlie <airlied@redhat.com>
* xkmread.c: fix compiler warningUlrich Sibiller2019-06-221-0/+4
| | | | | | xkmread.c: In function ‘XkmReadFileSectionName’: xkmread.c:1181:25: warning: ‘tmpTOC.type’ may be used uninitialized in this function [-Wmaybe-uninitialized] XkbConfigText(tmpTOC.type,XkbMessage),0);
* xkb: Silence some compiler warningsUlrich Sibiller2019-06-221-5/+6
| | | | | | | | | | | | | | | | | | | | | | commit 83913de25d35709b3ab7b0ab124b73924145d2dd Author: Adam Jackson <ajax@redhat.com> Date: Thu Apr 5 12:59:11 2018 -0400 xkb: Silence some compiler warnings Of the form: ../xkb/XKBGAlloc.c: In function ‘SrvXkbAddGeomKeyAlias’: ../xkb/XKBGAlloc.c:591:13: warning: ‘strncpy’ specified bound 4 equals destination size [-Wstringop-truncation] strncpy(alias->real, realStr, XkbKeyNameLength); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This is intentional; the code that reads from these fields never reads more than 4 bytes anyway. Rephrase things in terms of memcpy so that's clear. Obviously this is awful but in XKB awful is par. Signed-off-by: Adam Jackson <ajax@redhat.com> Acked-by: Keith Packard <keithp@keithp.com>
* xkb: Use snprintf to measure string lengths instead of manual strlen mathUlrich Sibiller2019-06-222-12/+12
| | | | | | | | | | | | commit a4a2e814d5d0e6152307a301eda1d6fc1c555aaa Author: Alan Coopersmith <alan.coopersmith@oracle.com> Date: Sun Feb 13 21:36:02 2011 -0800 xkb: Use snprintf to measure string lengths instead of manual strlen math Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Daniel Stone <daniel@fooishbar.org>
* xkbEvents.c: Fix "warning: unused variable `s'".Ulrich Sibiller2019-06-221-5/+4
| | | | | | | | commit 2391c409a2840d61fed93832650c0d6c82ebebdf Author: Eamon Walsh <ewalsh@tycho.nsa.gov> Date: Fri Jun 13 22:48:17 2008 -0400 Fix "warning: unused variable `s'".
* XKB: Remove a bunch of mad ifdefsUlrich Sibiller2019-06-2215-243/+67
| | | | | | | | | | | commit 534fc5140b039a8c98ab715d0a6740d513b41209 Author: Daniel Stone <daniel@fooishbar.org> Date: Sun Feb 3 23:30:22 2008 +1100 XKB: Remove a bunch of mad ifdefs We have SEEK_SET and size_t, seriously. Also use DebugF instead of ifdef DEBUG, and ditch a couple of random bits that were never used.
* xkb: remove oldState from XkbHandleActions.Ulrich Sibiller2019-06-221-4/+2
| | | | | | | | | | | | | | | | | | | | Fixes this cppcheck finding: [nx-X11/programs/Xserver/xkb/xkbActions.c:1306]: (error) Uninitialized variable: oldState commit 35a4b8e7f4526a92d44cb16a783f21030cd1f6df Author: Peter Hutterer <peter.hutterer@who-t.net> Date: Tue May 5 16:51:59 2009 +1000 xkb: remove oldState from XkbHandleActions. I really don't know what the purpose of this variable is or was, aside from potentially clobbering up our key state since there's a path where it may be used uninitialised. Also, this means that xkbi->prev_state is now accessible from the DIX with meaningful data. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* mi/miexpose.c: add missing free()Ulrich Sibiller2019-06-221-0/+3
|
* compext/Png.c: Nullify after freeUlrich Sibiller2019-06-221-2/+2
|
* compext/Png.c: simplify srcBuf allocationUlrich Sibiller2019-06-221-30/+13
|
* compext/Png.c: late image_index allocationUlrich Sibiller2019-06-221-17/+18
| | | | | | | | Move allocation of image_index close before first_use. This way we do not need to free it if previous step fail. And we cannot forget that free() call. While at it replace malloc+memset by calloc.
* NXdixfonts.c: fix index out of boundsUlrich Sibiller2019-06-221-2/+2
|
* Keyboard.c: rearrange code to make cppcheck happyUlrich Sibiller2019-06-221-1/+4
| | | | Otherwise it will (falsely) report "Memory pointed to by 'sessionpath' is freed twice."
* os/access.c: add missing }Ulrich Sibiller2019-06-221-0/+1
|
* NXpicture.c: code simplificationUlrich Sibiller2019-06-221-6/+2
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 04:06:04 +0000